Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork11.9k
MAINT: Update artful to bionic for i386 testing#11140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
charris commentedMay 22, 2018
LGTM, feel free to commit if the tests pass. A backport to 1.14.x would be helpful. |
mhvk commentedMay 23, 2018
Does look OK, but the tests fail... |
charris commentedMay 23, 2018
Failed with exit code 2, misuse of shell builtins or some such, not sure why. Looked like the failure was in the bootstrap. |
mattip commentedMay 23, 2018
I tried rerunning the travis test run, still fails. I tried running the command |
charris commentedMay 23, 2018
I note that the previous successful runs continued So the failure is immediate on attempting extraction. Maybe we should pip install pytest? |
njsmith commentedMay 23, 2018
Yeah, when@mattip ran it locally then that's what it did too (print "Extracting .. |
charris commentedMay 23, 2018
Could try removing |
mattip commentedMay 25, 2018
I reached out to travis-ci, their response is
Who is our "official" travis-ci POC? |
juliantaylor commentedMay 25, 2018
odd, we should be able to replace this multiarch package installations in a regular non sudo container by now. This would simplify the setup of the test by quite a bit. |
juliantaylor commentedMay 25, 2018
of course doing that would set the test back to whatever travis is actually runing which I think is ubuntu trusty. So we would lose testing newer compilers and libraries. |
njsmith commentedMay 25, 2018
If we want to keep going with debootstrap (as opposed to switching to multiarch packages, or I don't know, using docker or something), then the only thing I can think of to try next is (Possibly with some hacks to avoid printing the whole log, in case that triggers Travis's limit on log output.) |
mattip commentedMay 29, 2018
might have to do with |
mattip commentedMay 29, 2018
What is the procedure to backport a PR ? |
charris commentedMay 29, 2018
Depends. In this case I would rebase the top commit onto Or you could just cherry-pick the commit to a branch based on |
charris commentedMay 30, 2018
Actually, we can probably ignore this for 1.14.4, it was only needed for pytest, correct? |
charris commentedMay 30, 2018
Although it cannot hurt, but I don't think we will do anymore 1.14.x releases. |
mattip commentedMay 30, 2018
This PR is needed only if PR#10142 is merged to update pytest to include warning filters so I hink we can ignore it for 1.14.x, although I am intrigued how to do backports |
charris commentedMay 30, 2018
There is some discussion of backports in You can get the needed hash from the PR by hitting the commits button, then the copy hash button. Backports get more complicated when there are more than one commit, but if you read up on |
As mentioned in PR#10425, now that bionic has been released we should use it for testing