Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork11.9k
REL: Prepare for 1.14.1 release.#10630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
doc/release/1.14.1-notes.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Typo: replacethe could bythat could.
doc/release/1.14.1-notes.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Perhaps "is once more the default", or something emphasizing we're back to the 1.13 behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This was also in 1.13, indeed, since theaxis parameter was introduced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What I mean is I think we should be explicit here that 1.14.1 restores the 1.13.3 behavior
doc/release/1.14.1-notes.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We're choosing to leave this hidden then@ahaldane?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I copied the notes from master, probably this was only in the 1.14.x branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I thought this would be useful info for users, but if it's not part of the standard update-release-note I don't mind skipping it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've added back part of this to the list of problems fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me!
* Update release notes.* Create `1.14.1-changelog.rst`[skip ci]
| * The change in 1.14.0 that multi-field indexing of structured arrays returns a | ||
| view instead of a copy has been reverted but remains on track for NumPy 1.15. | ||
| Affected users should read the 1.14.1 Numpy User Guide section | ||
| "basics/structured arrays/accessing multiple fields" for advice on how to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can we get an rst link for this, so that the sphinx release note page links to it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Unfortunately those docs are inside a.py file:numpy/doc/structured_arrays.py, so I'm not sure that will work out well.
https://github.com/numpy/numpy/blob/maintenance/1.14.x/numpy/doc/structured_arrays.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's not over design this, it's just a release note. The documentation will go up after the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd like to get rid of the*.py documentation files at some point. It is confusing to have the documentation scattered about like that.
1.14.1-changelog.rst[skip ci]