Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork11.9k
BUG: deallocate recursive closure in arrayprint.py (1.14 backport)#10622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
BUG: deallocate recursive closure in arrayprint.py (1.14 backport)#10622
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bdb79d2 to92c23cfComparecharris commentedFeb 18, 2018
I'm going to rely on the tests here and put this in for 1.14. |
charris commentedFeb 18, 2018
Thanks Allan. |
eric-wieser commentedFeb 19, 2018
Do we want to revert this and apply the updated#10620? |
charris commentedFeb 19, 2018
I'm happy to go either way. If the updated version is available and better, go ahead and backport it. If it doesn't differ much, just branch off 1.14 and check it out of master and commit, that works better than cherry-picking when the merge isn't clean and is nicer than a reversion (IMHO). |
ahaldane commentedFeb 19, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It looks easier to me to do revert + cherry-pick, because of the messy diff in _formatArray combined with other changes in that file in master. I think it would be nice to put in the updated patch. I'll wait until we merge that one, and then I'll submit the packport. |
Fixes#10620
Backport of#10621