Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork11.9k
BUG: Fix calling ufuncs with a positional output argument.#10560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Currently, this causes the result to inherit the output's mask.This brings `np.add(a, b, out)` in line with `np.add(a, b, out=out)`.These previously differed becausenumpygh-10459 causes them to call__array_wrap__ in different ways (with and without the output argumentin the context tuple, respectively).Since the data in the `out` argument is never used by ufuncs, it seemsconsistent that the mask should not be either.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Backport of#10479.
Currently, this causes the result to inherit the output's mask.
This brings
np.add(a, b, out)in line withnp.add(a, b, out=out).These previously differed becausegh-10459 causes them to call
array_wrap in different ways (with and without the output argument
in the context tuple, respectively).
Since the data in the
outargument is never used by ufuncs, it seemsconsistent that the mask should not be either.