Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork11.9k
MAINT: Adjust type promotion in linalg.norm#10368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
charris commentedJan 11, 2018
I added the |
mhvk left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks all OK to me
mhvk commentedJan 11, 2018
But the failures of course suggest there is a problem... |
eric-wieser commentedJan 11, 2018
Failures are caused by#10374 |
numpy/linalg/linalg.py Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Don't need reciprocal any more...
mhvk commentedJan 11, 2018
Apart from the nitpick, would seem ready to go in. |
…r speedFixesnumpygh-10364, partly by adjusting the promise in the release notes
eric-wieser commentedJan 12, 2018
Updated with the nit fix |
mhvk commentedJan 12, 2018
OK, will merge now. |
eric-wieser commentedJan 12, 2018
Needs a forward port, which can be done through the GitHub UI alone |
Relates to#10364.
Unfortunately the failing case there still doesn't work when the result is a scalar, due to falling afoul of#10322. We fix this by just not making any promise about the scalar case.
That seems pretty reasonable to me, since numpy makes it very hard to keep float32 scalars around anyway.