Commit0cb5982

committed

BUG: ensure passingnp.dtype to itself doesn't crash

1 parent2f34979 commit0cb5982Copy full SHA for 0cb5982

File tree

+11

-0

lines changed

+11

-0

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1479,6 +1479,11 @@ PyArray_DTypeOrDescrConverterRequired(PyObject obj, npy_dtype_info dt_info)`
`1479`	`1479`	`dt_info->descr=NULL;`
`1480`	`1480`
`1481`	`1481`	`if (PyObject_TypeCheck(obj,&PyArrayDTypeMeta_Type)) {`
	`1482`	`+if (obj== (PyObject*)&PyArrayDescr_Type) {`
	`1483`	`+PyErr_SetString(PyExc_TypeError,`
	`1484`	`+"Cannot convert np.dtype into a dtype.");`
	`1485`	`+returnNPY_FAIL;`
	`1486`	`+ }`
`1482`	`1487`	`Py_INCREF(obj);`
`1483`	`1488`	`dt_info->dtype= (PyArray_DTypeMeta*)obj;`
`1484`	`1489`	`dt_info->descr=NULL;`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1931,3 +1931,9 @@ def test_result_type_integers_and_unitless_timedelta64():`
`1931`	`1931`	`td=np.timedelta64(4)`
`1932`	`1932`	`result=np.result_type(0,td)`
`1933`	`1933`	`assert_dtype_equal(result,td.dtype)`
	`1934`	`+`
	`1935`	`+`
	`1936`	`+deftest_creating_dtype_with_dtype_class_errors():`
	`1937`	+# Regression test for #25031, calling `np.dtype` with itself segfaulted.
	`1938`	`+withpytest.raises(TypeError,match="Cannot convert np.dtype into a dtype"):`
	`1939`	`+np.array(np.ones(10),dtype=np.dtype)`

Comments

(0)