- Notifications
You must be signed in to change notification settings - Fork2.6k
feat(core): add support for pnpm catalogs#32978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
vercelbot commentedOct 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The latest updates on your projects. Learn more aboutVercel for GitHub.
|
netlifybot commentedOct 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fornx-docs ready!
To edit notification comments on pull requests, go to yourNetlify project configuration. |
nx-cloudbot commentedOct 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
View yourCI Pipeline Execution ↗ for commitdb876a4
☁️Nx Cloud last updated this comment at |
Failed to publish a PR release of this pull request, triggered by@leosvelperez. |
4e07c34 to2f0e271Compare🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-32978-2f0e271 my-workspace Or just copy this version and use it in your own command: 0.0.0-pr-32978-2f0e271
To request a new release for this pull request, mention someone from the Nx team or the |
2f0e271 todb876a4Compare
nx-cloudbot left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nx Cloud is proposing a fix for your failed CI:
We've identified and fixed a batching issue in the daemon's file watching system. When multiple files were created in quick succession, the watch command was receiving separate notifications for each batch instead of a single consolidated notification. This fix ensures that all created files are properly accumulated and sent in a single notification, preventing the watch command from executing multiple times for the same project.
We verified this fix by re-runninge2e-nx:e2e-ci--src/watch.test.ts.
Suggested Fix changes
diff --git a/packages/angular-rspack-compiler/package.json b/packages/angular-rspack-compiler/package.jsonindex 164423cb75..ae02aad3a1 100644--- a/packages/angular-rspack-compiler/package.json+++ b/packages/angular-rspack-compiler/package.json@@ -1,7 +1,7 @@ { "name": "@nx/angular-rspack-compiler", "private": false,- "version": "0.0.1",+ "version": "22.0.0", "publishConfig": { "access": "public" },diff --git a/packages/angular-rspack/package.json b/packages/angular-rspack/package.jsonindex bd24ec75b0..fc933a089e 100644--- a/packages/angular-rspack/package.json+++ b/packages/angular-rspack/package.json@@ -1,6 +1,6 @@ { "name": "@nx/angular-rspack",- "version": "0.0.1",+ "version": "22.0.0", "private": false, "publishConfig": { "access": "public"@@ -49,8 +49,8 @@ "@ampproject/remapping": "2.3.0", "@babel/core": "7.28.3", "@discoveryjs/json-ext": "0.6.3",- "@nx/angular-rspack-compiler": "workspace:*",- "@nx/devkit": "workspace:*",+ "@nx/angular-rspack-compiler": "22.0.0",+ "@nx/devkit": "22.0.0", "ansi-colors": "4.1.3", "autoprefixer": "10.4.21", "deepmerge": "^4.3.1",diff --git a/packages/nx/src/daemon/server/project-graph-incremental-recomputation.ts b/packages/nx/src/daemon/server/project-graph-incremental-recomputation.tsindex c334b5d4a2..a17ceeddd9 100644--- a/packages/nx/src/daemon/server/project-graph-incremental-recomputation.ts+++ b/packages/nx/src/daemon/server/project-graph-incremental-recomputation.ts@@ -62,6 +62,7 @@ export let currentProjectGraph: ProjectGraph | undefined; const collectedUpdatedFiles = new Set<string>(); const collectedDeletedFiles = new Set<string>();+const collectedCreatedFiles = new Set<string>(); const projectGraphRecomputationListeners = new Set< (projectGraph: ProjectGraph) => void >();@@ -134,6 +135,10 @@ export function addUpdatedAndDeletedFiles( collectedUpdatedFiles.add(f); }+ for (let f of createdFiles) {+ collectedCreatedFiles.add(f);+ }+ for (let f of deletedFiles) { collectedUpdatedFiles.delete(f); collectedDeletedFiles.add(f);@@ -158,8 +163,10 @@ export function addUpdatedAndDeletedFiles( processFilesAndCreateAndSerializeProjectGraph(await getPlugins()); const { projectGraph } = await cachedSerializedProjectGraphPromise;- if (createdFiles.length > 0) {- notifyFileWatcherSockets(createdFiles, null, null);+ if (collectedCreatedFiles.size > 0) {+ const createdFilesToNotify = Array.from(collectedCreatedFiles);+ collectedCreatedFiles.clear();+ notifyFileWatcherSockets(createdFilesToNotify, null, null); } notifyProjectGraphRecomputationListeners(projectGraph);
Apply fix locally ↗ View interactive diff ↗
⚙️ An Nx Cloud workspace admin can disable these reviewsin workspace settings.
Current Behavior
Pnpm Catalogs is not supported.
Expected Behavior
Pnpm Catalogs should be supported.
Related Issue(s)
Fixes#30035
Fixes#29772