- Notifications
You must be signed in to change notification settings - Fork2.6k
chore(core): wip#32971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
chore(core): wip#32971
Conversation
vercelbot commentedOct 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The latest updates on your projects. Learn more aboutVercel for GitHub.
|
netlifybot commentedOct 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fornx-docs ready!
To edit notification comments on pull requests, go to yourNetlify project configuration. |
nx-cloudbot commentedOct 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
View yourCI Pipeline Execution ↗ for commitc13fda2
☁️Nx Cloud last updated this comment at |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
nx-cloudbot left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nx Cloud is proposing a fix for your failed CI:
These changes fix a critical bug in the release graph implementation where duplicate release groups could be added to thereleaseGroups
array. The issue occurred when filtering logic needed to re-add groups that were initially filtered out, causing object reference checks to fail and resulting in duplicates that broke changelog generation, filter output, and publishing.
We verified this fix by re-runninge2e-esbuild:e2e-ci--src/esbuild-basic-additional-entry-points.test.ts
.
diff --git a/packages/nx/src/command-line/release/utils/release-graph.ts b/packages/nx/src/command-line/release/utils/release-graph.tsindex 9e767ed582..f8b8050061 100644--- a/packages/nx/src/command-line/release/utils/release-graph.ts+++ b/packages/nx/src/command-line/release/utils/release-graph.ts@@ -482,7 +482,10 @@ export class ReleaseGraph { // Track the release group of this dependent const depGroup = this.getReleaseGroupForProject(dep);- if (depGroup && !this.releaseGroups.includes(depGroup)) {+ if (+ depGroup &&+ !this.releaseGroups.some((g) => g.name === depGroup.name)+ ) { additionalGroups.set(depGroup.name, depGroup); } }
Apply fix locally ↗ View interactive diff ↗
⚙️ An Nx Cloud workspace admin can disable these reviewsin workspace settings.
No description provided.