Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/nxPublic

chore(core): wip#32971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
JamesHenry wants to merge1 commit intomaster
base:master
Choose a base branch
Loading
fromrelease-graph
Draft

chore(core): wip#32971

JamesHenry wants to merge1 commit intomasterfromrelease-graph

Conversation

JamesHenry
Copy link
Collaborator

No description provided.

@vercelVercel
Copy link

vercelbot commentedOct 6, 2025
edited
Loading

The latest updates on your projects. Learn more aboutVercel for GitHub.

ProjectDeploymentPreviewUpdated (UTC)
nx-devReadyReadyPreviewOct 7, 2025 3:15pm

@netlifyNetlify
Copy link

netlifybot commentedOct 6, 2025
edited
Loading

Deploy Preview fornx-docs ready!

NameLink
🔨 Latest commit1120b4e
🔍 Latest deploy loghttps://app.netlify.com/projects/nx-docs/deploys/68e52be43255ac000840f937
😎 Deploy Previewhttps://deploy-preview-32971--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link
Contributor

nx-cloudbot commentedOct 6, 2025
edited
Loading

View yourCI Pipeline Execution ↗ for commitc13fda2

CommandStatusDurationResult
nx affected --targets=lint,test,test-kt,build,e...❌ Failed36m 50sView ↗
nx run-many -t check-imports check-commit check...✅ Succeeded2m 10sView ↗
nx-cloud record -- nx-cloud conformance:check✅ Succeeded2sView ↗
nx-cloud record -- nx format:check✅ Succeeded6sView ↗
nx-cloud record -- nx sync:check✅ Succeeded4sView ↗
nx documentation✅ Succeeded1m 31sView ↗

☁️Nx Cloud last updated this comment at2025-10-07 08:37:11 UTC

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

Copy link
Contributor

@nx-cloudnx-cloudbot left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nx Cloud is proposing a fix for your failed CI:

These changes fix a critical bug in the release graph implementation where duplicate release groups could be added to thereleaseGroups array. The issue occurred when filtering logic needed to re-add groups that were initially filtered out, causing object reference checks to fail and resulting in duplicates that broke changelog generation, filter output, and publishing.

We verified this fix by re-runninge2e-esbuild:e2e-ci--src/esbuild-basic-additional-entry-points.test.ts.

diff --git a/packages/nx/src/command-line/release/utils/release-graph.ts b/packages/nx/src/command-line/release/utils/release-graph.tsindex 9e767ed582..f8b8050061 100644--- a/packages/nx/src/command-line/release/utils/release-graph.ts+++ b/packages/nx/src/command-line/release/utils/release-graph.ts@@ -482,7 +482,10 @@ export class ReleaseGraph {              // Track the release group of this dependent             const depGroup = this.getReleaseGroupForProject(dep);-            if (depGroup && !this.releaseGroups.includes(depGroup)) {+            if (+              depGroup &&+              !this.releaseGroups.some((g) => g.name === depGroup.name)+            ) {               additionalGroups.set(depGroup.name, depGroup);             }           }

Apply fix via Nx Cloud  Reject fix via Nx Cloud

Apply fix locally ↗  View interactive diff ↗


⚙️ An Nx Cloud workspace admin can disable these reviewsin workspace settings.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nx-cloudnx-cloud[bot]nx-cloud[bot] left review comments

@Coly010Coly010Awaiting requested review from Coly010Coly010 will be requested when the pull request is marked ready for reviewColy010 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@JamesHenry

[8]ページ先頭

©2009-2025 Movatter.jp