- Notifications
You must be signed in to change notification settings - Fork2.6k
feat(maven): introduce maven plugin WIP#32947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
vercelbot commentedOct 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The latest updates on your projects. Learn more aboutVercel for GitHub.
|
netlifybot commentedOct 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fornx-docs ready!
To edit notification comments on pull requests, go to yourNetlify project configuration. |
nx-cloudbot commentedOct 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
View yourCI Pipeline Execution ↗ for commitb96461c
☁️Nx Cloud last updated this comment at |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Failed to publish a PR release of this pull request, triggered by@FrozenPandaz. |
Failed to publish a PR release of this pull request, triggered by@FrozenPandaz. |
Failed to publish a PR release of this pull request, triggered by@FrozenPandaz. |
Failed to publish a PR release of this pull request, triggered by@FrozenPandaz. |
Failed to publish a PR release of this pull request, triggered by@FrozenPandaz. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
Failure Classification: environment_state
The nx-maven-plugin:install task failed with "/bin/sh: 1: mvn: not found", indicating that the Maven executable is not available in the CI/CD build environment's PATH.
Analysis Details:
- The PR introduces a new Maven plugin with extensive Maven build infrastructure
- A Maven wrapper (mvnw) exists at the repository root and was added in this PR
- The project.json configuration for nx-maven-plugin uses "mvn install" directly
- The build environment does not have Maven installed in PATH
Why This Is environment_state (Not code_change):
- The error is not caused by any code logic in the PR
- This is a missing system dependency in the execution environment
- The Maven wrapper (mvnw) exists and should be used, but the environment is not configured to use it
- No similar failures in other branches suggest this is environment-specific
- The code changes themselves are valid; the issue is purely environmental
Recommendation:
The build environment needs either:
- Maven installed in PATH, OR
- The project.json should be updated to use "./mvnw" instead of "mvn", OR
- The CI/CD pipeline should be configured to set up Maven before running the build
This is not a code fix that should be implemented as part of this PR review. The failure is due to environment configuration, not the PR's code changes.
A code change would likely not resolve this issue, so no action was taken.
⚙️ An Nx Cloud workspace admin can disable these reviewsin workspace settings.
Failed to publish a PR release of this pull request, triggered by@FrozenPandaz. |
Adds automatic detection of Maven projects during nx init by looking for Maven wrapper files (mvnw, mvnw.bat) and pom.xml files. When detected, suggests installing the @nx/maven plugin, similar to how Gradle projects are detected.
Restructures the Java documentation sidebar to have separate subsections for Gradle and Maven plugins, instead of only showing Gradle at the top level. This provides equal visibility to both build tools.
- Move Gradle-specific docs from java/introduction.mdoc to java/gradle/introduction.mdoc- Create new general Java overview at java/introduction.mdoc covering both build tools- Remove special case remapping of gradle to java in plugin-mappings.ts- Both Gradle and Maven now have equal footing in the documentation structureThis addresses the TODO comment about not having Gradle as the default Java docs now that Maven is available.
Fix broken links to Gradle and Maven introduction pages by using the full path including /introduction suffix.
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-32947-aa25f06 my-workspace Or just copy this version and use it in your own command: 0.0.0-pr-32947-aa25f06
To request a new release for this pull request, mention someone from the Nx team or the |
Add index.mdoc landing pages for the Gradle and Maven subdirectories to resolve broken links to /docs/technologies/java/gradle and /docs/technologies/java/maven.
Failed to publish a PR release of this pull request, triggered by@FrozenPandaz. |
This is still WIP
Current Behavior
There is no first-party Maven support for Nx
Expected Behavior
Maven Support is ready for usage.
Related Issue(s)
Fixes #