Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/nxPublic

feat(core): collect resource usage#32946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
leosvelperez wants to merge1 commit intomaster
base:master
Choose a base branch
Loading
fromfix/nxc-3067
Draft

Conversation

leosvelperez
Copy link
Member

Current Behavior

Expected Behavior

@leosvelperezleosvelperez self-assigned thisOct 3, 2025
@netlifyNetlify
Copy link

netlifybot commentedOct 3, 2025
edited
Loading

Deploy Preview fornx-docs ready!

NameLink
🔨 Latest commitb2bcab9
🔍 Latest deploy loghttps://app.netlify.com/projects/nx-docs/deploys/68e4f4ceb678b600089852d6
😎 Deploy Previewhttps://deploy-preview-32946--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify project configuration.

@vercelVercel
Copy link

vercelbot commentedOct 3, 2025
edited
Loading

The latest updates on your projects. Learn more aboutVercel for GitHub.

ProjectDeploymentPreviewUpdated (UTC)
nx-devReadyReadyPreviewOct 7, 2025 11:21am

@nx-cloudNx Cloud
Copy link
Contributor

nx-cloudbot commentedOct 3, 2025
edited
Loading

View yourCI Pipeline Execution ↗ for commitb2bcab9

CommandStatusDurationResult
nx affected --targets=lint,test,test-kt,build,e...✅ Succeeded6m 24sView ↗
nx run-many -t check-imports check-commit check...✅ Succeeded2m 28sView ↗
nx-cloud record -- nx-cloud conformance:check✅ Succeeded2sView ↗
nx-cloud record -- nx format:check✅ Succeeded8sView ↗
nx-cloud record -- nx sync:check✅ Succeeded6sView ↗
nx documentation✅ Succeeded2m 32sView ↗

☁️Nx Cloud last updated this comment at2025-10-07 13:34:24 UTC

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

@github-actionsGitHub Actions
Copy link
Contributor

Failed to publish a PR release of this pull request, triggered by@leosvelperez.
See the failed workflow run at:https://github.com/nrwl/nx/actions/runs/18274180420

@github-actionsGitHub Actions
Copy link
Contributor

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-32946-64cab2a my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-32946-64cab2a
Release details📑
Published version0.0.0-pr-32946-64cab2a
Triggered by@leosvelperez
Branchfix/nxc-3067
Commit64cab2a
Workflow run18274180420

To request a new release for this pull request, mention someone from the Nx team or the@nrwl/nx-pipelines-reviewers.

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

Copy link
Contributor

@nx-cloudnx-cloudbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nx Cloud has identified a possible root cause for your failed CI:

The failing test "should be able to create an web-components workspace" is unrelated to the pull request changes.

The PR introduces a resource usage collection feature that adds metrics tracking for processes during task execution. The implementation includes:

  • Process metrics collector in Rust
  • Registration of CLI, daemon, and task processes
  • Silent failure handling (try-catch blocks) to ensure metrics never break execution

The test failure shows a Corepack error about missing packageManager field during workspace creation with pnpm. This failure is classified as flaky_task because:

  1. No logical connection: The PR modifies process metrics collection during task execution, not workspace creation or package.json handling
  2. Inconsistent behavior: 4 out of 5 similar tests passed (express, react-native, expo, nest), only web-components failed
  3. External tool error: The error originates from Corepack/pnpm, not from Nx code
  4. No reproducibility: The empty similar_task_failures indicates this error doesn't appear consistently
  5. Defensive coding: All metrics registration code is wrapped in try-catch blocks that silently fail

The web-components test is exhibiting non-deterministic behavior likely due to timing issues, Corepack state, or external registry conditions. The PR's metrics collection feature operates independently and cannot cause Corepack to modify packageManager field validation behavior during workspace creation.

A code change would likely not resolve this issue, so no action was taken.

Nx CloudView in Nx Cloud ↗


⚙️ An Nx Cloud workspace admin can disable these reviewsin workspace settings.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nx-cloudnx-cloud[bot]nx-cloud[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@leosvelperezleosvelperez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@leosvelperez

[8]ページ先頭

©2009-2025 Movatter.jp