- Notifications
You must be signed in to change notification settings - Fork3.9k
chore: Command Configs#8776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
reggi wants to merge12 commits intolatestChoose a base branch
base:latest
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
+569 −132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
workspaces/config/lib/index.js Outdated
| } | ||
| if(where!=='default'||key==='npm-version'){ | ||
| this.checkUnknown(where,key,false) |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why even call this if we don't want it to do anything?
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR allows commands to have their own distinct flags. Currently flags are defined globally. It makes it difficult to properly define flags for a given command. To work around this the CLI has often prefixed flags like
--init-namerather than just--name, resulting in verbose and longer flags. In addition to this we should also add the ability for a given flag to NOT look at the.npmrcfile(s) for adefinition(config) and allow for only--flagfor some, more sensitive options. This also means we should find a way within theinistructure to properly namespace flags like theinitones.Test pass but coverage is not filled.