Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork487
Silence a legitimate sanitizer warning that's enabled by default in Android NDK 29#1692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
matthargett wants to merge1 commit intonodejs:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+16 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecov-commenter commentedNov 28, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #1692 +/- ##==========================================+ Coverage 63.48% 63.50% +0.01%========================================== Files 3 3 Lines 2046 2047 +1 Branches 728 728 ==========================================+ Hits 1299 1300 +1 Misses 162 162 Partials 585 585 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silence a legitimate vfptr sanitizer warning that is on by default in Android NDK 29's clang. Stripping RTTI from a vfptr is usually a no-no for debugging and field-supportability reasons, but it's intrinsic to how ObjectWrap works right now.
This was found whilst porting BabylonNative (which implements NAPI for add-ons) to Android XR, and was integrated (and tested) there as a local patch:
https://github.com/BabylonJS/JsRuntimeHost/pull/118/files#diff-a9d53b78150c809d9bf63a90260b4f823918bc6e6d9c3e02eb68d855bf9deda1R4499