NotificationsYou must be signed in to change notification settings
Fork32.2k
Star112k

test_runner: emit 'test:restarted' event when tests are restarted#59115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

OkunadeNaheem wants to merge3 commits intonodejs:mainfromOkunadeNaheem:test_runner/add-restart-timestamp

Closed

test_runner: emit 'test:restarted' event when tests are restarted#59115

OkunadeNaheem wants to merge3 commits intonodejs:mainfromOkunadeNaheem:test_runner/add-restart-timestamp

+33 −0

Conversation

Copy link

OkunadeNaheem commentedJul 18, 2025•
edited by RafaelGSS
Loading

Refs:#57206

OkunadeNaheem added3 commits

July 18, 2025 19:47

test_runner: emit 'test:restarted' event on file restart

84b0c0f

emit a 'test:restarted' event from the test runner when a test file isrestarted due to file changes, if a timestamp reporter is present.this allows custom reporters to handle test restart events for loggingor other behaviors.

test_runner: add timeStamp event emitter to tests_stream

20a058d

add a timeStamp() method to tests_stream that emits a custom'test:restarted' event when invoked. this allows reporters tolog timestamped messages on test restarts.Fixes:nodejs#57206

test: add coverage for test:restarted event in test_runner

b752a22

add a test that verifies the timeStamp event emitter triggerscorrectly when a test file is restarted. this ensures thetest_runner emits the 'test:restarted' event as expected.Fixes:nodejs#57206

Copy link

Collaborator

nodejs-github-bot commentedJul 18, 2025

Review requested:

@nodejs/test_runner

nodejs-github-bot added needs-ci

PRs that need a full CI run.

test_runnerIssues and PRs related to the test runner subsystem. labels

Jul 18, 2025

Copy link

Author

OkunadeNaheem commentedJul 18, 2025

Description
This pull request introduces a test:restarted event in the test_runner module.
The event is emitted whenever a test file is restarted due to file changes during watch mode, allowing reporters (such as a timestamp logger) to hook into the restart event.

Summary of changes:
test_runner/runner.js:
Emit the test:restarted event using the reporter’s timeStamp method when a test file restarts.

test_runner/tests_stream.js:
Added timeStamp() method to TestsStream for emitting timestamped messages. This method uses process.stdout.write following the Node.js guidelines on avoiding console.log in core code.

test/parallel/test-runner-restart-timestamp.js:
Added a test to verify that the test:restarted event is emitted when a test file is restarted.