Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
SQLite Async API#59109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
SQLite Async API#59109
Conversation
Review requested:
|
Concurrency ControlFor concurrency control, SQLiteprovides a few options. Multi-threaded seems to be a good fit.
We just need a way to guarantee that no two threads will be using |
I wonder if, for the first version of this API if the
|
Uh oh!
There was an error while loading.Please reload this page.
Closes#54307
This PR implements an async API for
node:sqlite
module. So far, it contains a very minimal implementation ofexec
method, misses some tests, docs and refactoring but it is good enough to share the whole theory I have for it; with that, anybody can share thoughts about it.Desing
On C++ land, I plan to have the
Database
class determine whether the operations will be asynchronous.Public API
For the public API, I plan to have classes such as
Database
,Statement
, etc., as counterparts to' DatabaseSync', ' StatementSync', and so on.