Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
src: fix compatility with upcoming V8 12.1 APIs#50709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Review requested:
|
V8 11.10 doesn't exist. The Error API changes are in V8 12.0 and the other changes will be in V8 12.1 (I think). |
Thanks for the info! I have changed the title. |
targos approved these changesNov 13, 2023
joyeecheung approved these changesNov 13, 2023
27 tasks
gengjiawen approved these changesNov 14, 2023
26 tasks
Commit Queue failed- Loading data for nodejs/node/pull/50709✔ Done loading data for nodejs/node/pull/50709----------------------------------- PR info ------------------------------------Title src: fix compatility with upcoming V8 12.1 APIs (#50709) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!Branch zcbenz:fix-v8-119-api -> nodejs:mainLabels c++, lib / src, needs-ciCommits 1 - src: fix compatility with upcoming V8 12.1 APIsCommitters 1 - Cheng Zhao PR-URL: https://github.com/nodejs/node/pull/50709Reviewed-By: Michaël Zasso Reviewed-By: Joyee Cheung Reviewed-By: Jiawen Geng ------------------------------ Generated metadata ------------------------------PR-URL: https://github.com/nodejs/node/pull/50709Reviewed-By: Michaël Zasso Reviewed-By: Joyee Cheung Reviewed-By: Jiawen Geng -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 13 Nov 2023 13:19:58 GMT ✔ Approvals: 3 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/50709#pullrequestreview-1727352282 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/50709#pullrequestreview-1727436502 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/50709#pullrequestreview-1728714263 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-11-14T03:27:39Z: https://ci.nodejs.org/job/node-test-pull-request/55629/- Querying data for job/node-test-pull-request/55629/ ✔ Last Jenkins CI successful-------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6877934814 |
targos added a commit that referenced this pull requestNov 15, 2023
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull requestNov 16, 2023
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull requestNov 17, 2023
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull requestNov 18, 2023
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull requestNov 19, 2023
jasnell approved these changesNov 19, 2023
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull requestNov 20, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 28, 2023
RafaelGSS pushed a commit that referenced this pull requestNov 29, 2023
PR-URL:#50709Reviewed-By: Michaël Zasso <targos@protonmail.com>Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere added a commit to electron/electron that referenced this pull requestNov 29, 2023
jkleinsc pushed a commit to electron/electron that referenced this pull requestNov 30, 2023
* chore: upgrade to Node.js v20* src: allow embedders to override NODE_MODULE_VERSIONnodejs/node#49279* src: fix missing trailing ,nodejs/node#46909* src,tools: initialize cppgcnodejs/node#45704* tools: allow passing absolute path of config.gypi in js2cnodejs/node#49162* tools: port js2c.py to C++nodejs/node#46997* doc,lib: disambiguate the old term, NativeModulenodejs/node#45673* chore: fixup Node.js BSSL tests*nodejs/node#49492*nodejs/node#44498* deps: upgrade to libuv 1.45.0nodejs/node#48078* deps: update V8 to 10.7nodejs/node#44741* test: use gcUntil() in test-v8-serialize-leaknodejs/node#49168* module: make CJS load from ESM loadernodejs/node#47999* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* chore: address changes to CJS/ESM loading* module: make CJS load from ESM loader (nodejs/node#47999)* lib: improve esm resolve performance (nodejs/node#46652)* bootstrap: optimize modules loaded in the built-in snapshotnodejs/node#45849* test: mark test-runner-output as flakynodejs/node#49854* lib: lazy-load deps in modules/run_main.jsnodejs/node#45849* url: use private properties for brand checknodejs/node#46904* test: refactor `test-node-output-errors`nodejs/node#48992* assert: deprecate callTrackernodejs/node#47740* src: cast v8::Object::GetInternalField() return value to v8::Valuenodejs/node#48943* test: adapt test-v8-stats for V8 updatenodejs/node#45230* tls: ensure TLS Sockets are closed if the underlying wrapclosesnodejs/node#49327* test: deflake test-tls-socket-closenodejs/node#49575* net: fix crash due to simultaneous close/shutdown on JS Stream Socketsnodejs/node#49400* net: use asserts in JS Socket Stream to catch races in futurenodejs/node#49400* lib: fix BroadcastChannel initialization locationnodejs/node#46864* src: create BaseObject with node::Realmnodejs/node#44348* src: implement DataQueue and non-memory resident Blobnodejs/node#45258* sea: add support for V8 bytecode-only cachingnodejs/node#48191* chore: fixup patch indices* gyp: put filenames in variablesnodejs/node#46965* build: modify js2c.py into GN executable* fix: (WIP) handle string replacement of fs -> original-fs* [v20.x] backport vm-related memoryfixesnodejs/node#49874* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* src: avoid copying string in fs_permissionnodejs/node#47746* look upon my works ye mightyand dispair* chore: patch cleanup* [api] Remove AllCan Read/Writehttps://chromium-review.googlesource.com/c/v8/v8/+/5006387* fix: missing include for NODE_EXTERN* chore: fixup patch indices* fix: fail properly when js2c fails in Node.js* build: fix js2c root_gen_dir* fix: lib/fs.js -> lib/original-fs.js* build: fix original-fs file xforms* fixup! module: make CJS load from ESM loader* build: get rid of CppHeap for now* build: add patch to prevent extra fs lookup on esm load* build: greatly simplify js2c modificationsMoves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c* chore: update to handle moved internal/modules/helpers file* test: update @types/node test* feat: enable preventing cppgc heap creation* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler* fix: no cppgc initialization in the renderer* gyp: put filenames in variablesnodejs/node#46965* test: disable single executable tests* fix: nan tests failing on node headers missing file* tls,http2: send fatal alert on ALPN mismatchnodejs/node#44031* test: disable snapshot tests*nodejs/node#47887*nodejs/node#49684*nodejs/node#44193* build: use deps/v8 for v8/toolsNode.js hard depends on these in their builtins* test: fix edge snapshot stack tracesnodejs/node#49659* build: remove js2c //base dep* build: use electron_js2c_toolchain to build node_js2c* fix: don't create SafeSet outside packageResolveFixes failure in parallel/test-require-delete-array-iterator:=== release test-require-delete-array-iterator ===Path: parallel/test-require-delete-array-iteratornode:internal/per_context/primordials:426 constructor(i) { super(i); } // eslint-disable-line no-useless-constructor ^TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator)) at new Set (<anonymous>) at new SafeSet (node:internal/per_context/primordials:426:22)* fix: failing crashReporter tests on LinuxThese were failing because our change from node::InitializeNodeWithArgs tonode::InitializeOncePerProcess meant that we now inadvertently calledPlatformInit, which reset signal handling. This meant that our intentionalcrash function ElectronBindings::Crash no longer worked and the renderer processno longer crashed when process.crash() was called. We don't want to use Node.js'default signal handling in the renderer process, so we disable it by passingkNoDefaultSignalHandling to node::InitializeOncePerProcess.* build: only create cppgc heap on non-32 bit platforms* chore: clean up util:CompileAndCall* src: fix compatility with upcoming V8 12.1 APIsnodejs/node#50709* fix: use thread_local BuiltinLoader* chore: fixup v8 patch indices---------Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
RafaelGSS pushed a commit that referenced this pull requestNov 30, 2023
PR-URL:#50709Reviewed-By: Michaël Zasso <targos@protonmail.com>Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Reviewed-By: James M Snell <jasnell@gmail.com>
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull requestDec 11, 2023
* chore: upgrade to Node.js v20* src: allow embedders to override NODE_MODULE_VERSIONnodejs/node#49279* src: fix missing trailing ,nodejs/node#46909* src,tools: initialize cppgcnodejs/node#45704* tools: allow passing absolute path of config.gypi in js2cnodejs/node#49162* tools: port js2c.py to C++nodejs/node#46997* doc,lib: disambiguate the old term, NativeModulenodejs/node#45673* chore: fixup Node.js BSSL tests*nodejs/node#49492*nodejs/node#44498* deps: upgrade to libuv 1.45.0nodejs/node#48078* deps: update V8 to 10.7nodejs/node#44741* test: use gcUntil() in test-v8-serialize-leaknodejs/node#49168* module: make CJS load from ESM loadernodejs/node#47999* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* chore: address changes to CJS/ESM loading* module: make CJS load from ESM loader (nodejs/node#47999)* lib: improve esm resolve performance (nodejs/node#46652)* bootstrap: optimize modules loaded in the built-in snapshotnodejs/node#45849* test: mark test-runner-output as flakynodejs/node#49854* lib: lazy-load deps in modules/run_main.jsnodejs/node#45849* url: use private properties for brand checknodejs/node#46904* test: refactor `test-node-output-errors`nodejs/node#48992* assert: deprecate callTrackernodejs/node#47740* src: cast v8::Object::GetInternalField() return value to v8::Valuenodejs/node#48943* test: adapt test-v8-stats for V8 updatenodejs/node#45230* tls: ensure TLS Sockets are closed if the underlying wrapclosesnodejs/node#49327* test: deflake test-tls-socket-closenodejs/node#49575* net: fix crash due to simultaneous close/shutdown on JS Stream Socketsnodejs/node#49400* net: use asserts in JS Socket Stream to catch races in futurenodejs/node#49400* lib: fix BroadcastChannel initialization locationnodejs/node#46864* src: create BaseObject with node::Realmnodejs/node#44348* src: implement DataQueue and non-memory resident Blobnodejs/node#45258* sea: add support for V8 bytecode-only cachingnodejs/node#48191* chore: fixup patch indices* gyp: put filenames in variablesnodejs/node#46965* build: modify js2c.py into GN executable* fix: (WIP) handle string replacement of fs -> original-fs* [v20.x] backport vm-related memoryfixesnodejs/node#49874* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* src: avoid copying string in fs_permissionnodejs/node#47746* look upon my works ye mightyand dispair* chore: patch cleanup* [api] Remove AllCan Read/Writehttps://chromium-review.googlesource.com/c/v8/v8/+/5006387* fix: missing include for NODE_EXTERN* chore: fixup patch indices* fix: fail properly when js2c fails in Node.js* build: fix js2c root_gen_dir* fix: lib/fs.js -> lib/original-fs.js* build: fix original-fs file xforms* fixup! module: make CJS load from ESM loader* build: get rid of CppHeap for now* build: add patch to prevent extra fs lookup on esm load* build: greatly simplify js2c modificationsMoves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c* chore: update to handle moved internal/modules/helpers file* test: update @types/node test* feat: enable preventing cppgc heap creation* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler* fix: no cppgc initialization in the renderer* gyp: put filenames in variablesnodejs/node#46965* test: disable single executable tests* fix: nan tests failing on node headers missing file* tls,http2: send fatal alert on ALPN mismatchnodejs/node#44031* test: disable snapshot tests*nodejs/node#47887*nodejs/node#49684*nodejs/node#44193* build: use deps/v8 for v8/toolsNode.js hard depends on these in their builtins* test: fix edge snapshot stack tracesnodejs/node#49659* build: remove js2c //base dep* build: use electron_js2c_toolchain to build node_js2c* fix: don't create SafeSet outside packageResolveFixes failure in parallel/test-require-delete-array-iterator:=== release test-require-delete-array-iterator ===Path: parallel/test-require-delete-array-iteratornode:internal/per_context/primordials:426 constructor(i) { super(i); } // eslint-disable-line no-useless-constructor ^TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator)) at new Set (<anonymous>) at new SafeSet (node:internal/per_context/primordials:426:22)* fix: failing crashReporter tests on LinuxThese were failing because our change from node::InitializeNodeWithArgs tonode::InitializeOncePerProcess meant that we now inadvertently calledPlatformInit, which reset signal handling. This meant that our intentionalcrash function ElectronBindings::Crash no longer worked and the renderer processno longer crashed when process.crash() was called. We don't want to use Node.js'default signal handling in the renderer process, so we disable it by passingkNoDefaultSignalHandling to node::InitializeOncePerProcess.* build: only create cppgc heap on non-32 bit platforms* chore: clean up util:CompileAndCall* src: fix compatility with upcoming V8 12.1 APIsnodejs/node#50709* fix: use thread_local BuiltinLoader* chore: fixup v8 patch indices---------Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
UlisesGascon pushed a commit that referenced this pull requestDec 11, 2023
PR-URL:#50709Reviewed-By: Michaël Zasso <targos@protonmail.com>Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
UlisesGascon pushed a commit that referenced this pull requestDec 13, 2023
PR-URL:#50709Reviewed-By: Michaël Zasso <targos@protonmail.com>Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Reviewed-By: James M Snell <jasnell@gmail.com>
UlisesGascon pushed a commit that referenced this pull requestDec 15, 2023
PR-URL:#50709Reviewed-By: Michaël Zasso <targos@protonmail.com>Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Reviewed-By: James M Snell <jasnell@gmail.com>
UlisesGascon pushed a commit that referenced this pull requestDec 19, 2023
PR-URL:#50709Reviewed-By: Michaël Zasso <targos@protonmail.com>Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere added a commit to electron/electron that referenced this pull requestJan 10, 2024
codebytere added a commit to electron/electron that referenced this pull requestJan 10, 2024
zcbenz pushed a commit to electron/electron that referenced this pull requestJan 12, 2024
zcbenz pushed a commit to electron/electron that referenced this pull requestJan 12, 2024
zcbenz pushed a commit to electron/electron that referenced this pull requestJan 12, 2024
zcbenz pushed a commit to electron/electron that referenced this pull requestJan 12, 2024
codebytere added a commit to electron/electron that referenced this pull requestJan 15, 2024
codebytere added a commit to electron/electron that referenced this pull requestJan 15, 2024
codebytere added a commit to electron/electron that referenced this pull requestJan 15, 2024
codebytere added a commit to electron/electron that referenced this pull requestJan 15, 2024
codebytere added a commit to electron/electron that referenced this pull requestJan 16, 2024
codebytere added a commit to electron/electron that referenced this pull requestJan 16, 2024
codebytere added a commit to electron/electron that referenced this pull requestJan 18, 2024
codebytere added a commit to electron/electron that referenced this pull requestJan 18, 2024
jkleinsc pushed a commit to electron/electron that referenced this pull requestJan 18, 2024
jkleinsc pushed a commit to electron/electron that referenced this pull requestJan 18, 2024
codebytere added a commit to electron/electron that referenced this pull requestJan 18, 2024
codebytere added a commit to electron/electron that referenced this pull requestJan 18, 2024
jkleinsc pushed a commit to electron/electron that referenced this pull requestJan 18, 2024
* chore: bump node in DEPS to v20.11.0* module: bootstrap module loaders in shadow realmnodejs/node#48655* src: add commit hash shorthand in zlib versionnodejs/node#50158* v8,tools: expose necessary V8 definesnodejs/node#50820* esm: do not call getSource when format is commonjsnodejs/node#50465* esm: fallback to readFileSync when source is nullishnodejs/node#50825* vm: allow dynamic import with a referrer realmnodejs/node#50360* test: skip test-diagnostics-channel-memory-leak.jsnodejs/node#50327* esm: do not call getSource when format is commonjsnodejs/node#50465* lib: fix assert throwing different error messages in ESM and CJSnodejs/node#50634* src: fix compatility with upcoming V8 12.1 APIsnodejs/node#50709* deps: update base64 to 0.5.1nodejs/node#50629* src: avoid silent coercion to signed/unsigned intnodejs/node#50663* src: fix compatility with upcoming V8 12.1 APIsnodejs/node#50709* chore: fix patch indices* chore: update patches* test: disable TLS cipher testThis can't be enabled owing to BoringSSL incompatibilities.nodejs/node#50186* fix: check for Buffer and global definition in shadow realmnodejs/node#51239* test: disable parallel/test-shadow-realm-custom-loaderIncompatible with our asar logic, resulting in the following failure:> Failed to CompileAndCall electron script: electron/js2c/asar_bundle* chore: remove deleted parallel/test-crypto-modp1-error test* test: make test-node-output-v8-warning genericnodejs/node#50421* chore: fixup ModuleWrap patch* test: match wpt/streams/transferable/transform-stream-members.any.js to upstream* fix: sandbox is not enabled on arm* chore: disable v8 sandbox on ia32/arm---------Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the upcoming V8 11.10 there are a few API changes will break building of Node, this PR makes the code compatible with both old and new APIs.
This PR is needed becauseV8's node-ci repo tests latest Node with latest V8, and without this change V8 has to patch Node in their own fork.