Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
esm: unflag extensionless ES module JavaScript and Wasm in module scope#49974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
GeoffreyBooth wants to merge5 commits intonodejs:mainfromGeoffreyBooth:extensionless-in-module-scope
Closed
esm: unflag extensionless ES module JavaScript and Wasm in module scope#49974
GeoffreyBooth wants to merge5 commits intonodejs:mainfromGeoffreyBooth:extensionless-in-module-scope
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
RSLGTM
Maybe add baking-for-lts |
benjamingr approved these changesSep 30, 2023
That’s a good idea, I assume I should use that without the |
16 tasks
12 tasks
@LiviaMedeiros or someone else, do you want to approve this? Then it can land. |
guybedford approved these changesOct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The lookup logic all looks correct to me.
Uh oh!
There was an error while loading.Please reload this page.
targos approved these changesOct 2, 2023
Uh oh!
There was an error while loading.Please reload this page.
LiviaMedeiros pushed a commit that referenced this pull requestOct 3, 2023
PR-URL:#49974Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>Reviewed-By: Guy Bedford <guybedford@gmail.com>Reviewed-By: Michaël Zasso <targos@protonmail.com>
Landed in9c68320 |
This was referencedOct 9, 2023
alexfernandez pushed a commit to alexfernandez/node that referenced this pull requestNov 1, 2023
PR-URL:nodejs#49974Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>Reviewed-By: Guy Bedford <guybedford@gmail.com>Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit to targos/node that referenced this pull requestNov 11, 2023
PR-URL:nodejs#49974Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>Reviewed-By: Guy Bedford <guybedford@gmail.com>Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull requestNov 11, 2023
PR-URL:#49974Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>Reviewed-By: Guy Bedford <guybedford@gmail.com>Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit to targos/node that referenced this pull requestNov 11, 2023
PR-URL:nodejs#49974Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>Reviewed-By: Guy Bedford <guybedford@gmail.com>Reviewed-By: Michaël Zasso <targos@protonmail.com>
codebytere added a commit to electron/electron that referenced this pull requestDec 11, 2023
codebytere added a commit to electron/electron that referenced this pull requestDec 11, 2023
* chore: bump node in DEPS to v20.10.0* chore: update feat_initialize_asar_support.patchno code changes; patch just needed an update due to nearby upstream changesXref:nodejs/node#49986* chore: update pass_all_globals_through_require.patchno manual changes; patch applied with fuzzXref:nodejs/node#49657* chore: update refactor_allow_embedder_overriding_of_internal_fs_callsXref:nodejs/node#49912no code changes; patch just needed an update due to nearby upstream changes* chore: update chore_allow_the_node_entrypoint_to_be_a_builtin_module.patchXref:nodejs/node#49986minor manual changes needed to sync with upstream change* update fix_expose_the_built-in_electron_module_via_the_esm_loader.patchXref:nodejs/node#50096Xref:nodejs/node#50314in lib/internal/modules/esm/load.js, update the code that checks for`format === 'electron'`. I'd like 👀 on thisXref:nodejs/node#49657add braces in lib/internal/modules/esm/translators.js to sync with upstream* fix: lazyload fs in esm loaders to apply asar patches*nodejs/node#50127*nodejs/node#50096* esm: jsdoc for modules codenodejs/node#49523* test: set test-cli-node-options as flakynodejs/node#50296* deps: update c-ares to 1.20.1nodejs/node#50082* esm: bypass CommonJS loader under --default-type=modulenodejs/node#49986* deps: update uvwasi to 0.0.19nodejs/node#49908* lib,test: do not hardcode Buffer.kMaxLengthnodejs/node#49876* crypto: account for disabled SharedArrayBuffernodejs/node#50034* test: fix edge snapshot stack tracesnodejs/node#49659* src: generate snapshot with --predictablenodejs/node#48749* chore: fixup patch indices* fs: throw errors from sync branches instead of separate implementationsnodejs/node#49913* crypto: ensure valid point on elliptic curve in SubtleCrypto.importKeynodejs/node#50234* esm: detect ESM syntax in ambiguous JavaScripnodejs/node#50096* fixup! test: fix edge snapshot stack traces* esm: unflag extensionless ES module JavaScript and Wasm in module scopenodejs/node#49974* [tagged-ptr] Arrowify objectshttps://chromium-review.googlesource.com/c/v8/v8/+/4705331---------Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>Co-authored-by: Charles Kerr <charles@charleskerr.com>Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
debadree25 pushed a commit to debadree25/node that referenced this pull requestApr 15, 2024
PR-URL:nodejs#49974Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>Reviewed-By: Guy Bedford <guybedford@gmail.com>Reviewed-By: Michaël Zasso <targos@protonmail.com>
sercher added a commit to sercher/graaljs that referenced this pull requestApr 25, 2024
PR-URL:nodejs/node#49974Backport-PR-URL:nodejs/node#50669Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>Reviewed-By: Guy Bedford <guybedford@gmail.com>Reviewed-By: Michaël Zasso <targos@protonmail.com>
sercher added a commit to sercher/graaljs that referenced this pull requestApr 25, 2024
PR-URL:nodejs/node#49974Backport-PR-URL:nodejs/node#50669Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>Reviewed-By: Guy Bedford <guybedford@gmail.com>Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
author readyPRs that have at least one approval, no pending requests for changes, and a CI started. errorsIssues and PRs related to JavaScript errors originated in Node.js core. esmIssues and PRs related to the ECMAScript Modules implementation. needs-ciPRs that need a full CI run. wasmIssues and PRs related to WebAssembly.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up from#49869, this PR allows extensionless ESM JavaScript and Wasm files within
"type": "module"package scopes to run as entry points or be imported. This can be done as a semver-minor change because currently such files error when they are within amodulescope. (Outside of such a scope, they are interpreted as CommonJS modules unless--experimental-default-type=moduleis passed.)This was discussed in the most recent TSC meeting,nodejs/TSC#1442. At that meeting it was agreed that this change could go out in 21.0.0, butnot immediately in 20.x or below. It doesn’t need to be restricted from 20.x indefinitely, but there was a request to hold off on backporting it to 20.x until it had been public in 21.x for a bit. I’ve added labels accordingly.
@nodejs/loaders @nodejs/wasi