Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

lib: reset the cwd cache before execution#49684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nodejs-github-bot merged 11 commits intonodejs:mainfromarcanis:mael/cwd-cache-bust
Sep 21, 2023

Conversation

arcanis
Copy link
Contributor

This diff attempts to reset the cwd cache before starting the script execution. This is necessary when a snapshot is used, as otherwise the cwd will be locked at the time of snapshot generate, untilchdir is called (that makes me wonder whether snapshots could lead to information leaks, if similar patterns are found in, say,process.env?).

I'm not entirely sure whether adding a method toprocess.cwd is the right approach - I suspected it was better than attempting torequire the file declaring the cwd cache (since it's a conditional branch), and moving the cwd cache to a dedicated file seemed a little overkill.

Fixes#49675

bricss reacted with thumbs up emoji
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-botnodejs-github-bot added lib / srcIssues and PRs related to general changes in the lib or src directory. needs-ciPRs that need a full CI run. processIssues and PRs related to the process subsystem. labelsSep 17, 2023
@joyeecheung
Copy link
Member

joyeecheung commentedSep 17, 2023
edited
Loading

Regardingprocess.env - that's a dynamic proxy so access to it goes to C++ land and is not part of JS snapshot. Though you could still query and save the states in user land.

I wonder if we should add a switch to warn about access to these properties, and let the users figure out how to handle them during the snapshot building process. It can be possible that users actually want to query about these states during snapshot building for some reason. But at least we can help them check unintentional access.

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
arcanisand others added2 commitsSeptember 18, 2023 14:22
Copy link
Member

@joyeecheungjoyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks for the fix!

@joyeecheungjoyeecheung added the request-ciAdd this label to start a Jenkins CI on a PR. labelSep 18, 2023
@aduh95aduh95 added author readyPRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one. labelsSep 18, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@arcanis
Copy link
ContributorAuthor

Is there a problem in this PR?

@richardlaurichardlau added the commit-queueAdd this label to land a pull request using GitHub Actions. labelSep 21, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queueAdd this label to land a pull request using GitHub Actions. labelSep 21, 2023
@nodejs-github-botnodejs-github-bot merged commitb7d836e intonodejs:mainSep 21, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed inb7d836e

ruyadorno pushed a commit that referenced this pull requestSep 28, 2023
PR-URL:#49684Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>Reviewed-By: LiviaMedeiros <livia@cirno.name>Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referencedSep 28, 2023
alexfernandez pushed a commit to alexfernandez/node that referenced this pull requestNov 1, 2023
PR-URL:nodejs#49684Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>Reviewed-By: LiviaMedeiros <livia@cirno.name>Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere added a commit to electron/electron that referenced this pull requestNov 17, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 21, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 22, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 28, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 29, 2023
jkleinsc pushed a commit to electron/electron that referenced this pull requestNov 30, 2023
* chore: upgrade to Node.js v20* src: allow embedders to override NODE_MODULE_VERSIONnodejs/node#49279* src: fix missing trailing ,nodejs/node#46909* src,tools: initialize cppgcnodejs/node#45704* tools: allow passing absolute path of config.gypi in js2cnodejs/node#49162* tools: port js2c.py to C++nodejs/node#46997* doc,lib: disambiguate the old term, NativeModulenodejs/node#45673* chore: fixup Node.js BSSL tests*nodejs/node#49492*nodejs/node#44498* deps: upgrade to libuv 1.45.0nodejs/node#48078* deps: update V8 to 10.7nodejs/node#44741* test: use gcUntil() in test-v8-serialize-leaknodejs/node#49168* module: make CJS load from ESM loadernodejs/node#47999* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* chore: address changes to CJS/ESM loading* module: make CJS load from ESM loader (nodejs/node#47999)* lib: improve esm resolve performance (nodejs/node#46652)* bootstrap: optimize modules loaded in the built-in snapshotnodejs/node#45849* test: mark test-runner-output as flakynodejs/node#49854* lib: lazy-load deps in modules/run_main.jsnodejs/node#45849* url: use private properties for brand checknodejs/node#46904* test: refactor `test-node-output-errors`nodejs/node#48992* assert: deprecate callTrackernodejs/node#47740* src: cast v8::Object::GetInternalField() return value to v8::Valuenodejs/node#48943* test: adapt test-v8-stats for V8 updatenodejs/node#45230* tls: ensure TLS Sockets are closed if the underlying wrapclosesnodejs/node#49327* test: deflake test-tls-socket-closenodejs/node#49575* net: fix crash due to simultaneous close/shutdown on JS Stream Socketsnodejs/node#49400* net: use asserts in JS Socket Stream to catch races in futurenodejs/node#49400* lib: fix BroadcastChannel initialization locationnodejs/node#46864* src: create BaseObject with node::Realmnodejs/node#44348* src: implement DataQueue and non-memory resident Blobnodejs/node#45258* sea: add support for V8 bytecode-only cachingnodejs/node#48191* chore: fixup patch indices* gyp: put filenames in variablesnodejs/node#46965* build: modify js2c.py into GN executable* fix: (WIP) handle string replacement of fs -> original-fs* [v20.x] backport vm-related memoryfixesnodejs/node#49874* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* src: avoid copying string in fs_permissionnodejs/node#47746* look upon my works ye mightyand dispair* chore: patch cleanup* [api] Remove AllCan Read/Writehttps://chromium-review.googlesource.com/c/v8/v8/+/5006387* fix: missing include for NODE_EXTERN* chore: fixup patch indices* fix: fail properly when js2c fails in Node.js* build: fix js2c root_gen_dir* fix: lib/fs.js -> lib/original-fs.js* build: fix original-fs file xforms* fixup! module: make CJS load from ESM loader* build: get rid of CppHeap for now* build: add patch to prevent extra fs lookup on esm load* build: greatly simplify js2c modificationsMoves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c* chore: update to handle moved internal/modules/helpers file* test: update @types/node test* feat: enable preventing cppgc heap creation* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler* fix: no cppgc initialization in the renderer* gyp: put filenames in variablesnodejs/node#46965* test: disable single executable tests* fix: nan tests failing on node headers missing file* tls,http2: send fatal alert on ALPN mismatchnodejs/node#44031* test: disable snapshot tests*nodejs/node#47887*nodejs/node#49684*nodejs/node#44193* build: use deps/v8 for v8/toolsNode.js hard depends on these in their builtins* test: fix edge snapshot stack tracesnodejs/node#49659* build: remove js2c //base dep* build: use electron_js2c_toolchain to build node_js2c* fix: don't create SafeSet outside packageResolveFixes failure in parallel/test-require-delete-array-iterator:=== release test-require-delete-array-iterator ===Path: parallel/test-require-delete-array-iteratornode:internal/per_context/primordials:426    constructor(i) { super(i); } // eslint-disable-line no-useless-constructor                     ^TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator))    at new Set (<anonymous>)    at new SafeSet (node:internal/per_context/primordials:426:22)* fix: failing crashReporter tests on LinuxThese were failing because our change from node::InitializeNodeWithArgs tonode::InitializeOncePerProcess meant that we now inadvertently calledPlatformInit, which reset signal handling. This meant that our intentionalcrash function ElectronBindings::Crash no longer worked and the renderer processno longer crashed when process.crash() was called. We don't want to use Node.js'default signal handling in the renderer process, so we disable it by passingkNoDefaultSignalHandling to node::InitializeOncePerProcess.* build: only create cppgc heap on non-32 bit platforms* chore: clean up util:CompileAndCall* src: fix compatility with upcoming V8 12.1 APIsnodejs/node#50709* fix: use thread_local BuiltinLoader* chore: fixup v8 patch indices---------Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull requestDec 11, 2023
* chore: upgrade to Node.js v20* src: allow embedders to override NODE_MODULE_VERSIONnodejs/node#49279* src: fix missing trailing ,nodejs/node#46909* src,tools: initialize cppgcnodejs/node#45704* tools: allow passing absolute path of config.gypi in js2cnodejs/node#49162* tools: port js2c.py to C++nodejs/node#46997* doc,lib: disambiguate the old term, NativeModulenodejs/node#45673* chore: fixup Node.js BSSL tests*nodejs/node#49492*nodejs/node#44498* deps: upgrade to libuv 1.45.0nodejs/node#48078* deps: update V8 to 10.7nodejs/node#44741* test: use gcUntil() in test-v8-serialize-leaknodejs/node#49168* module: make CJS load from ESM loadernodejs/node#47999* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* chore: address changes to CJS/ESM loading* module: make CJS load from ESM loader (nodejs/node#47999)* lib: improve esm resolve performance (nodejs/node#46652)* bootstrap: optimize modules loaded in the built-in snapshotnodejs/node#45849* test: mark test-runner-output as flakynodejs/node#49854* lib: lazy-load deps in modules/run_main.jsnodejs/node#45849* url: use private properties for brand checknodejs/node#46904* test: refactor `test-node-output-errors`nodejs/node#48992* assert: deprecate callTrackernodejs/node#47740* src: cast v8::Object::GetInternalField() return value to v8::Valuenodejs/node#48943* test: adapt test-v8-stats for V8 updatenodejs/node#45230* tls: ensure TLS Sockets are closed if the underlying wrapclosesnodejs/node#49327* test: deflake test-tls-socket-closenodejs/node#49575* net: fix crash due to simultaneous close/shutdown on JS Stream Socketsnodejs/node#49400* net: use asserts in JS Socket Stream to catch races in futurenodejs/node#49400* lib: fix BroadcastChannel initialization locationnodejs/node#46864* src: create BaseObject with node::Realmnodejs/node#44348* src: implement DataQueue and non-memory resident Blobnodejs/node#45258* sea: add support for V8 bytecode-only cachingnodejs/node#48191* chore: fixup patch indices* gyp: put filenames in variablesnodejs/node#46965* build: modify js2c.py into GN executable* fix: (WIP) handle string replacement of fs -> original-fs* [v20.x] backport vm-related memoryfixesnodejs/node#49874* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* src: avoid copying string in fs_permissionnodejs/node#47746* look upon my works ye mightyand dispair* chore: patch cleanup* [api] Remove AllCan Read/Writehttps://chromium-review.googlesource.com/c/v8/v8/+/5006387* fix: missing include for NODE_EXTERN* chore: fixup patch indices* fix: fail properly when js2c fails in Node.js* build: fix js2c root_gen_dir* fix: lib/fs.js -> lib/original-fs.js* build: fix original-fs file xforms* fixup! module: make CJS load from ESM loader* build: get rid of CppHeap for now* build: add patch to prevent extra fs lookup on esm load* build: greatly simplify js2c modificationsMoves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c* chore: update to handle moved internal/modules/helpers file* test: update @types/node test* feat: enable preventing cppgc heap creation* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler* fix: no cppgc initialization in the renderer* gyp: put filenames in variablesnodejs/node#46965* test: disable single executable tests* fix: nan tests failing on node headers missing file* tls,http2: send fatal alert on ALPN mismatchnodejs/node#44031* test: disable snapshot tests*nodejs/node#47887*nodejs/node#49684*nodejs/node#44193* build: use deps/v8 for v8/toolsNode.js hard depends on these in their builtins* test: fix edge snapshot stack tracesnodejs/node#49659* build: remove js2c //base dep* build: use electron_js2c_toolchain to build node_js2c* fix: don't create SafeSet outside packageResolveFixes failure in parallel/test-require-delete-array-iterator:=== release test-require-delete-array-iterator ===Path: parallel/test-require-delete-array-iteratornode:internal/per_context/primordials:426    constructor(i) { super(i); } // eslint-disable-line no-useless-constructor                     ^TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator))    at new Set (<anonymous>)    at new SafeSet (node:internal/per_context/primordials:426:22)* fix: failing crashReporter tests on LinuxThese were failing because our change from node::InitializeNodeWithArgs tonode::InitializeOncePerProcess meant that we now inadvertently calledPlatformInit, which reset signal handling. This meant that our intentionalcrash function ElectronBindings::Crash no longer worked and the renderer processno longer crashed when process.crash() was called. We don't want to use Node.js'default signal handling in the renderer process, so we disable it by passingkNoDefaultSignalHandling to node::InitializeOncePerProcess.* build: only create cppgc heap on non-32 bit platforms* chore: clean up util:CompileAndCall* src: fix compatility with upcoming V8 12.1 APIsnodejs/node#50709* fix: use thread_local BuiltinLoader* chore: fixup v8 patch indices---------Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
addaleax added a commit to addaleax/node that referenced this pull requestFeb 27, 2024
Functions registered with `addSerializeCallback()` can access and call`process.cwd()`.b7d836e accounted for the fact that it isnecessary to reset the cwd cache after the snapshot builder script hasrun, but did not account for possible accesses from serializationcallbacks. To properly account for these, add a deserializationcallback as well.As a related drive-by fix, also mention the execution order ofcallbacks in the documentation.Refs:nodejs#49684
nodejs-github-bot pushed a commit that referenced this pull requestFeb 29, 2024
Functions registered with `addSerializeCallback()` can access and call`process.cwd()`.b7d836e accounted for the fact that it isnecessary to reset the cwd cache after the snapshot builder script hasrun, but did not account for possible accesses from serializationcallbacks. To properly account for these, add a deserializationcallback as well.As a related drive-by fix, also mention the execution order ofcallbacks in the documentation.Refs:#49684PR-URL:#51901Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>Reviewed-By: Michaël Zasso <targos@protonmail.com>Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito pushed a commit that referenced this pull requestMar 1, 2024
Functions registered with `addSerializeCallback()` can access and call`process.cwd()`.b7d836e accounted for the fact that it isnecessary to reset the cwd cache after the snapshot builder script hasrun, but did not account for possible accesses from serializationcallbacks. To properly account for these, add a deserializationcallback as well.As a related drive-by fix, also mention the execution order ofcallbacks in the documentation.Refs:#49684PR-URL:#51901Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>Reviewed-By: Michaël Zasso <targos@protonmail.com>Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
richardlau pushed a commit that referenced this pull requestMar 25, 2024
Functions registered with `addSerializeCallback()` can access and call`process.cwd()`.b7d836e accounted for the fact that it isnecessary to reset the cwd cache after the snapshot builder script hasrun, but did not account for possible accesses from serializationcallbacks. To properly account for these, add a deserializationcallback as well.As a related drive-by fix, also mention the execution order ofcallbacks in the documentation.Refs:#49684PR-URL:#51901Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>Reviewed-By: Michaël Zasso <targos@protonmail.com>Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
richardlau pushed a commit that referenced this pull requestMar 25, 2024
Functions registered with `addSerializeCallback()` can access and call`process.cwd()`.b7d836e accounted for the fact that it isnecessary to reset the cwd cache after the snapshot builder script hasrun, but did not account for possible accesses from serializationcallbacks. To properly account for these, add a deserializationcallback as well.As a related drive-by fix, also mention the execution order ofcallbacks in the documentation.Refs:#49684PR-URL:#51901Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>Reviewed-By: Michaël Zasso <targos@protonmail.com>Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
rdw-msft pushed a commit to rdw-msft/node that referenced this pull requestMar 26, 2024
Functions registered with `addSerializeCallback()` can access and call`process.cwd()`.b7d836e accounted for the fact that it isnecessary to reset the cwd cache after the snapshot builder script hasrun, but did not account for possible accesses from serializationcallbacks. To properly account for these, add a deserializationcallback as well.As a related drive-by fix, also mention the execution order ofcallbacks in the documentation.Refs:nodejs#49684PR-URL:nodejs#51901Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>Reviewed-By: Michaël Zasso <targos@protonmail.com>Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aduh95aduh95aduh95 approved these changes

@bnoordhuisbnoordhuisbnoordhuis approved these changes

@joyeecheungjoyeecheungjoyeecheung approved these changes

@BridgeARBridgeARBridgeAR approved these changes

@LiviaMedeirosLiviaMedeirosLiviaMedeiros approved these changes

Assignees
No one assigned
Labels
author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.processIssues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snapshotting is persisting the cwd
8 participants
@arcanis@nodejs-github-bot@joyeecheung@bnoordhuis@BridgeAR@aduh95@LiviaMedeiros@richardlau

[8]ページ先頭

©2009-2025 Movatter.jp