Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test_runner: expose location of tests#48975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cjihrig merged 1 commit intonodejs:mainfromcjihrig:test-location
Aug 11, 2023

Conversation

cjihrig
Copy link
Contributor

This commit adds each test's line and column number to the reporter output. This will aid in debugging test suite failures when error stacks are not helpful, test suites are large, or tests have the same name. This data is also exposed on the spec reporter.

This commit also replaces the filename that was previously being reported, with the filename where the test actually exists. These are normally correct, but could be wrong if tests were run from a file other than the user's entrypoint.

Fixes:#48457

atlowChemi, tonivj5, styfle, and mdrobny reacted with rocket emojibricss reacted with eyes emoji
@cjihrigcjihrig requested a review frommcollinaJuly 30, 2023 23:31
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added lib / srcIssues and PRs related to general changes in the lib or src directory. needs-ciPRs that need a full CI run. labelsJul 30, 2023
@cjihrigcjihrig added semver-minorPRs that contain new features and should be released in the next minor version. test_runnerIssues and PRs related to the test runner subsystem. labelsJul 30, 2023
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Amazing work! Could you add this information to the tap reporter as well? This happens relatively often in CI too.

@benjamingr
Copy link
Member

This probably needs benchmark as taking a trace can be expensive, doesn't it?

@cjihrig
Copy link
ContributorAuthor

This probably needs benchmark as taking a trace can be expensive, doesn't it?

I tried really hard to avoid implementing this because I was worried about that. I tried to make it as fast as possible while being accurate. It only collects two stack frames and does not iterate over them.

I think we actually need this from a correctness standpoint. The reporter emits events with filenames attached to it, which might not be correct. The DX is a secondary improvement for things like#48457 (comment).

@ljharb
Copy link
Member

Usually perf isn’t that important in failure cases, which any failed tests would be. What’s the actual impact here?

@cjihrig
Copy link
ContributorAuthor

The problem is that if you wait until you know that the test failed, you can't get at the original call site, so you have to do it for all tests. If you do know of a way to accurately get the originaltest() call site at failure time, I would love to use that instead.

There's also the issue of reporting the wrong filename if you run a test from a non-main file via, for example,require('./some-other-file-with-tests-in-it').

ljharb, benjamingr, and MoLow reacted with thumbs up emoji

@ljharb
Copy link
Member

Presumably the expensive part is stack generation, and that’s what needs to be done eagerly :-/

@benjamingr
Copy link
Member

I tried really hard to avoid implementing this because I was worried about that. I tried to make it as fast as possible while being accurate. It only collects two stack frames and does not iterate over them.

We would still need a benchmark or alternatively to make this opt in only if you listen to the event + a doc warning?

@cjihrig
Copy link
ContributorAuthor

alternatively to make this opt in only if you listen to the event

I'm not sure how that would work. The filename is already part of the public API. Even if we limited these changes to the'test:fail' event, every meaningful reporter will listen for that event.

MoLow reacted with thumbs up emoji

@rluvaton
Copy link
Member

How would this work with compilers that change the code location (e.g. TypeScript)

meyfa reacted with heart emoji

@cjihrig
Copy link
ContributorAuthor

How would this work with compilers that change the code location (e.g. TypeScript)

It points to the location at runtime (same as the file, which would be the.js file, not the.ts file). Source maps aren't really supported in the test runner yet.

@cjihrig
Copy link
ContributorAuthor

I've updated this PR based on feedback, including updating the TAP reporter.

Here are the benchmark numbers:

test_runner/global-concurrent-tests.js type='async' n=100                                                  ***     -2.39 %       ±1.20% ±1.61% ±2.11%test_runner/global-concurrent-tests.js type='async' n=1000                                                 ***    -15.10 %       ±1.10% ±1.47% ±1.91%test_runner/global-concurrent-tests.js type='async' n=10000                                                ***    -12.71 %       ±1.95% ±2.61% ±3.45%test_runner/global-concurrent-tests.js type='sync' n=100                                                   ***     -2.82 %       ±1.26% ±1.68% ±2.18%test_runner/global-concurrent-tests.js type='sync' n=1000                                                  ***    -14.19 %       ±0.95% ±1.27% ±1.65%test_runner/global-concurrent-tests.js type='sync' n=10000                                                 ***    -13.48 %       ±1.05% ±1.40% ±1.84%test_runner/global-sequential-tests.js type='async' n=100                                                   **      1.91 %       ±1.39% ±1.85% ±2.41%test_runner/global-sequential-tests.js type='async' n=1000                                                          0.91 %       ±2.53% ±3.37% ±4.40%test_runner/global-sequential-tests.js type='async' n=10000                                                         0.71 %       ±1.22% ±1.62% ±2.11%test_runner/global-sequential-tests.js type='sync' n=100                                                            0.78 %       ±1.51% ±2.01% ±2.62%test_runner/global-sequential-tests.js type='sync' n=1000                                                           0.72 %       ±2.06% ±2.74% ±3.57%test_runner/global-sequential-tests.js type='sync' n=10000                                                         -0.11 %       ±1.20% ±1.59% ±2.07%test_runner/suite-tests.js concurrency='no' testType='async' testsPerSuite=10 numberOfSuites=10            ***     -2.83 %       ±0.71% ±0.94% ±1.23%test_runner/suite-tests.js concurrency='no' testType='async' testsPerSuite=10 numberOfSuites=100           ***      3.70 %       ±1.45% ±1.94% ±2.53%test_runner/suite-tests.js concurrency='no' testType='async' testsPerSuite=100 numberOfSuites=10           ***      4.71 %       ±1.37% ±1.83% ±2.41%test_runner/suite-tests.js concurrency='no' testType='async' testsPerSuite=100 numberOfSuites=100          ***     -4.82 %       ±0.70% ±0.94% ±1.22%test_runner/suite-tests.js concurrency='no' testType='async' testsPerSuite=1000 numberOfSuites=10          ***     -4.63 %       ±0.77% ±1.03% ±1.35%test_runner/suite-tests.js concurrency='no' testType='async' testsPerSuite=1000 numberOfSuites=100                 -0.32 %       ±4.42% ±5.92% ±7.79%test_runner/suite-tests.js concurrency='no' testType='sync' testsPerSuite=10 numberOfSuites=10             ***     -3.96 %       ±0.96% ±1.28% ±1.69%test_runner/suite-tests.js concurrency='no' testType='sync' testsPerSuite=10 numberOfSuites=100            ***      5.81 %       ±1.68% ±2.25% ±2.95%test_runner/suite-tests.js concurrency='no' testType='sync' testsPerSuite=100 numberOfSuites=10            ***      4.96 %       ±0.81% ±1.08% ±1.41%test_runner/suite-tests.js concurrency='no' testType='sync' testsPerSuite=100 numberOfSuites=100           ***     -5.29 %       ±0.68% ±0.91% ±1.19%test_runner/suite-tests.js concurrency='no' testType='sync' testsPerSuite=1000 numberOfSuites=10           ***     -4.31 %       ±0.62% ±0.83% ±1.08%test_runner/suite-tests.js concurrency='no' testType='sync' testsPerSuite=1000 numberOfSuites=100            *     -4.90 %       ±4.29% ±5.75% ±7.56%test_runner/suite-tests.js concurrency='yes' testType='async' testsPerSuite=10 numberOfSuites=10           ***     -4.88 %       ±0.71% ±0.94% ±1.23%test_runner/suite-tests.js concurrency='yes' testType='async' testsPerSuite=10 numberOfSuites=100          ***      7.81 %       ±2.02% ±2.69% ±3.50%test_runner/suite-tests.js concurrency='yes' testType='async' testsPerSuite=100 numberOfSuites=10          ***      4.54 %       ±1.33% ±1.77% ±2.31%test_runner/suite-tests.js concurrency='yes' testType='async' testsPerSuite=100 numberOfSuites=100         ***     -4.98 %       ±0.63% ±0.84% ±1.09%test_runner/suite-tests.js concurrency='yes' testType='async' testsPerSuite=1000 numberOfSuites=10         ***     -5.33 %       ±0.68% ±0.91% ±1.18%test_runner/suite-tests.js concurrency='yes' testType='async' testsPerSuite=1000 numberOfSuites=100        ***     -5.40 %       ±2.69% ±3.62% ±4.78%test_runner/suite-tests.js concurrency='yes' testType='sync' testsPerSuite=10 numberOfSuites=10            ***     -5.96 %       ±0.73% ±0.98% ±1.27%test_runner/suite-tests.js concurrency='yes' testType='sync' testsPerSuite=10 numberOfSuites=100           ***      7.47 %       ±1.78% ±2.38% ±3.13%test_runner/suite-tests.js concurrency='yes' testType='sync' testsPerSuite=100 numberOfSuites=10           ***      5.63 %       ±0.86% ±1.14% ±1.49%test_runner/suite-tests.js concurrency='yes' testType='sync' testsPerSuite=100 numberOfSuites=100          ***     -5.14 %       ±0.70% ±0.94% ±1.24%test_runner/suite-tests.js concurrency='yes' testType='sync' testsPerSuite=1000 numberOfSuites=10          ***     -5.06 %       ±0.67% ±0.89% ±1.17%test_runner/suite-tests.js concurrency='yes' testType='sync' testsPerSuite=1000 numberOfSuites=100         ***     -8.32 %       ±2.39% ±3.19% ±4.18%

I'm on the fence because, as expected, there is a performance hit. On the other hand, as previously mentioned, this improves correctness and provides important debugging information. 🤷

benjamingr and MoLow reacted with thumbs up emoji

@mcollina
Copy link
Member

The alternative solution to this issue is to restore printing the file name when more than one file is being run (wrapping it in a suite automatically). It's a less accurate, but at least we can point out where things are broken.

@cjihrig
Copy link
ContributorAuthor

The more I think about this, the more I think we should land this change.

I'm not entirely confident in the benchmarks. For example, why doesglobal-concurrent-tests.js show a bigger perf hit when n=1,000 than when n=10,000? At the same time, running tests sequentially shows a small improvement (although not statistically significant) even though each test is doing more work. Similarly, there are a number ofsuite-tests.js runs that show over a 5% improvement.

atlowChemi and MoLow reacted with thumbs up emoji

Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm

@rluvaton
Copy link
Member

rluvaton commentedAug 8, 2023•
edited
Loading

The more I think about this, the more I think we should land this change.

I'm not entirely confident in the benchmarks. For example, why doesglobal-concurrent-tests.js show a bigger perf hit when n=1,000 than when n=10,000? At the same time, running tests sequentially shows a small improvement (although not statistically significant) even though each test is doing more work. Similarly, there are a number ofsuite-tests.js runs that show over a 5% improvement.

If you think the benchmark would need an improvement I would love to see that... I added those as we did not have anything so we had no data to make a decision

@cjihrig
Copy link
ContributorAuthor

Having the benchmarks is a great improvement. Thank you for that. Unfortunately, I don't have any suggestions for improving them (other than I'm not sureglobal-concurrent-tests.js makes a ton of sense because the test runner has internal concurrency machinery that I don't think that benchmark accounts for). It's good to see numbers and how changes impact them... I'm just having trouble reasoning about some of the results in the context of this change.

@rluvaton
Copy link
Member

Yagiz suggested to improve the benchmark reliability we should extract to test creation an test running but I don't think that's possible but it might give you some idea 😄

cjihrig reacted with rocket emoji

juanarbol pushed a commit that referenced this pull requestSep 4, 2023
Notable changes:deps:  * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc:  * add new TSC members (Michael Dawson)#48841  * add rluvaton to collaborators (Raz Luvaton)#49215esm:  * unflag import.meta.resolve (Guy Bedford)#49028  * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842  * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector:  * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module:  * implement `register` utility (João Lenon)#46826  * make CJS load from ESM loader (Antoine du Hamel)#47999src:  * add built-in `.env` file support (Yagiz Nizipli)#48890  * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
UlisesGascon pushed a commit that referenced this pull requestSep 10, 2023
This commit adds each test's line and column number to the reporteroutput. This will aid in debugging test suite failures when errorstacks are not helpful, test suites are large, or tests have thesame name. This data is also exposed on the spec reporter.This commit also replaces the filename that was previously beingreported, with the filename where the test actually exists. Theseare normally correct, but could be wrong if tests were run froma file other than the user's entrypoint.PR-URL:#48975Backport-PR-URL:#49225Fixes:#48457Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>Reviewed-By: Matteo Collina <matteo.collina@gmail.com>Reviewed-By: Chemi Atlow <chemi@atlow.co.il>Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
UlisesGascon added a commit that referenced this pull requestSep 10, 2023
Notable changes:crypto:  * update root certificates to NSS 3.93 (Node.js GitHub Bot)#49341doc:  * move and rename loaders section (Geoffrey Booth)#49261lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)#46391src,permission:  * add multiple allow-fs-* flags (Carlos Espa)#49047test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL: TODO
@UlisesGasconUlisesGascon mentioned this pull requestSep 10, 2023
UlisesGascon added a commit that referenced this pull requestSep 10, 2023
Notable changes:crypto:  * update root certificates to NSS 3.93 (Node.js GitHub Bot)#49341doc:  * move and rename loaders section (Geoffrey Booth)#49261lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)#46391src,permission:  * add multiple allow-fs-* flags (Carlos Espa)#49047test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49592
UlisesGascon added a commit that referenced this pull requestSep 11, 2023
Notable changes:crypto:  * update root certificates to NSS 3.93 (Node.js GitHub Bot)#49341doc:  * move and rename loaders section (Geoffrey Booth)#49261lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)#46391src,permission:  * add multiple allow-fs-* flags (Carlos Espa)#49047test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49592
UlisesGascon added a commit that referenced this pull requestSep 11, 2023
Notable changes:crypto:  * update root certificates to NSS 3.93 (Node.js GitHub Bot)#49341doc:  * move and rename loaders section (Geoffrey Booth)#49261lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)#46391src:  * support multiple `--env-file` declarations (Yagiz Nizipli)#49542src,permission:  * add multiple allow-fs-* flags (Carlos Espa)#49047test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49592
UlisesGascon added a commit that referenced this pull requestSep 11, 2023
Notable changes:crypto:  * update root certificates to NSS 3.93 (Node.js GitHub Bot)#49341doc:  * move and rename loaders section (Geoffrey Booth)#49261lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)#46391src:  * support multiple `--env-file` declarations (Yagiz Nizipli)#49542src,permission:  * add multiple allow-fs-* flags (Carlos Espa)#49047test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49592
UlisesGascon added a commit that referenced this pull requestSep 11, 2023
Notable changes:crypto:  * update root certificates to NSS 3.93 (Node.js GitHub Bot)#49341doc:  * move and rename loaders section (Geoffrey Booth)#49261lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)#46391src:  * support multiple `--env-file` declarations (Yagiz Nizipli)#49542src,permission:  * add multiple allow-fs-* flags (Carlos Espa)#49047test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49592
UlisesGascon added a commit that referenced this pull requestSep 12, 2023
Notable changes:crypto:  * update root certificates to NSS 3.93 (Node.js GitHub Bot)#49341doc:  * move and rename loaders section (Geoffrey Booth)#49261  * add release key for Ulises Gascon (Ulises Gascón)#49196lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)#46391src:  * support multiple `--env-file` declarations (Yagiz Nizipli)#49542src,permission:  * add multiple allow-fs-* flags (Carlos Espa)#49047test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49592
UlisesGascon added a commit that referenced this pull requestSep 12, 2023
Notable changes:crypto:  * update root certificates to NSS 3.93 (Node.js GitHub Bot)#49341doc:  * move and rename loaders section (Geoffrey Booth)#49261  * add release key for Ulises Gascon (Ulises Gascón)#49196lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)#46391src:  * support multiple `--env-file` declarations (Yagiz Nizipli)#49542src,permission:  * add multiple allow-fs-* flags (Carlos Espa)#49047test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49592
UlisesGascon added a commit that referenced this pull requestSep 13, 2023
Notable changes:crypto:  * update root certificates to NSS 3.93 (Node.js GitHub Bot)#49341doc:  * move and rename loaders section (Geoffrey Booth)#49261  * add release key for Ulises Gascon (Ulises Gascón)#49196lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)#46391src:  * support multiple `--env-file` declarations (Yagiz Nizipli)#49542src,permission:  * add multiple allow-fs-* flags (Carlos Espa)#49047test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49592
UlisesGascon added a commit that referenced this pull requestSep 13, 2023
Notable changes:crypto:  * update root certificates to NSS 3.93 (Node.js GitHub Bot)#49341doc:  * move and rename loaders section (Geoffrey Booth)#49261  * add release key for Ulises Gascon (Ulises Gascón)#49196lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)#46391src:  * support multiple `--env-file` declarations (Yagiz Nizipli)#49542src,permission:  * add multiple allow-fs-* flags (Carlos Espa)#49047test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49592
UlisesGascon added a commit that referenced this pull requestSep 16, 2023
Notable changes:crypto:  * update root certificates to NSS 3.93 (Node.js GitHub Bot)#49341doc:  * move and rename loaders section (Geoffrey Booth)#49261  * add release key for Ulises Gascon (Ulises Gascón)#49196lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)#46391src:  * support multiple `--env-file` declarations (Yagiz Nizipli)#49542src,permission:  * add multiple allow-fs-* flags (Carlos Espa)#49047test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49592
UlisesGascon added a commit that referenced this pull requestSep 18, 2023
Notable changes:crypto:  * update root certificates to NSS 3.93 (Node.js GitHub Bot)#49341deps:  * upgrade npm to 10.0.0 (npm team)#49423  * upgrade npm to 10.1.0 (npm team)#49570doc:  * move and rename loaders section (Geoffrey Booth)#49261  * add release key for Ulises Gascon (Ulises Gascón)#49196lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)#46391src:  * support multiple `--env-file` declarations (Yagiz Nizipli)#49542src,permission:  * add multiple allow-fs-* flags (Carlos Espa)#49047test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49592
UlisesGascon added a commit that referenced this pull requestSep 18, 2023
Notable changes:crypto:  * update root certificates to NSS 3.93 (Node.js GitHub Bot)#49341deps:  * upgrade npm to 10.1.0 (npm team)#49570  * upgrade npm to 10.0.0 (npm team)#49423doc:  * move and rename loaders section (Geoffrey Booth)#49261  * add release key for Ulises Gascon (Ulises Gascón)#49196lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)#46391src:  * support multiple `--env-file` declarations (Yagiz Nizipli)#49542src,permission:  * add multiple allow-fs-* flags (Carlos Espa)#49047test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49592
UlisesGascon added a commit to UlisesGascon/node that referenced this pull requestSep 18, 2023
Notable changes:crypto:  * update root certificates to NSS 3.93 (Node.js GitHub Bot)nodejs#49341deps:  * upgrade npm to 10.1.0 (npm team)nodejs#49570  * upgrade npm to 10.0.0 (npm team)nodejs#49423doc:  * move and rename loaders section (Geoffrey Booth)nodejs#49261  * add release key for Ulises Gascon (Ulises Gascón)nodejs#49196lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)nodejs#46391src:  * support multiple `--env-file` declarations (Yagiz Nizipli)nodejs#49542src,permission:  * add multiple allow-fs-* flags (Carlos Espa)nodejs#49047test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)nodejs#48975PR-URL:nodejs#49592
alexfernandez pushed a commit to alexfernandez/node that referenced this pull requestNov 1, 2023
Notable changes:deps:  * V8: cherry-pick 93275031284c (Joyee Cheung)nodejs#48660doc:  * add new TSC members (Michael Dawson)nodejs#48841  * add rluvaton to collaborators (Raz Luvaton)nodejs#49215esm:  * unflag import.meta.resolve (Guy Bedford)nodejs#49028  * add `initialize` hook, integrate with `register` (Izaak Schroeder)nodejs#48842  * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)nodejs#48559inspector:  * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)nodejs#48765module:  * implement `register` utility (João Lenon)nodejs#46826  * make CJS load from ESM loader (Antoine du Hamel)nodejs#47999src:  * add built-in `.env` file support (Yagiz Nizipli)nodejs#48890  * initialize cppgc (Daryl Haresign and Joyee Cheung)nodejs#48660 andnodejs#45704test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)nodejs#48975PR-URL:nodejs#49185
alexfernandez pushed a commit to alexfernandez/node that referenced this pull requestNov 1, 2023
Notable changes:crypto:  * update root certificates to NSS 3.93 (Node.js GitHub Bot)nodejs#49341deps:  * upgrade npm to 10.1.0 (npm team)nodejs#49570  * upgrade npm to 10.0.0 (npm team)nodejs#49423doc:  * move and rename loaders section (Geoffrey Booth)nodejs#49261  * add release key for Ulises Gascon (Ulises Gascón)nodejs#49196lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)nodejs#46391src:  * support multiple `--env-file` declarations (Yagiz Nizipli)nodejs#49542src,permission:  * add multiple allow-fs-* flags (Carlos Espa)nodejs#49047test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)nodejs#48975PR-URL:nodejs#49592
@targostargos added backported-to-v20.xPRs backported to the v20.x-staging branch. and removed backport-open-v20.xIndicate that the PR has an open backport labelsNov 12, 2023
targos pushed a commit that referenced this pull requestNov 27, 2023
This commit adds each test's line and column number to the reporteroutput. This will aid in debugging test suite failures when errorstacks are not helpful, test suites are large, or tests have thesame name. This data is also exposed on the spec reporter.This commit also replaces the filename that was previously beingreported, with the filename where the test actually exists. Theseare normally correct, but could be wrong if tests were run froma file other than the user's entrypoint.PR-URL:#48975Fixes:#48457Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>Reviewed-By: Matteo Collina <matteo.collina@gmail.com>Reviewed-By: Chemi Atlow <chemi@atlow.co.il>Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos added a commit that referenced this pull requestNov 27, 2023
Notable changes:deps:  * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot)#49908  * (SEMVER-MINOR) upgrade npm to 10.0.0 (npm team)#49423doc:  * add new TSC members (Michael Dawson)#48841  * move and rename loaders section (Geoffrey Booth)#49261esm:  * use import attributes instead of import assertions (Antoine du Hamel)#50140  * --experimental-default-type flag to flip module defaults (Geoffrey Booth)#49869  * unflag import.meta.resolve (Guy Bedford)#49028  * move hook execution to separate thread (Jacob Smith)#44710  * leverage loaders when resolving subsequent loaders (Maël Nison)#43772lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)#46391  * (SEMVER-MINOR) add tracing channel to diagnostics_channel (Stephen Belanger)#44943src:  * (SEMVER-MINOR) add cjs_module_lexer_version base64_version (Jithil P Ponnan)#45629stream:  * use bitmap in readable state (Benjamin Gruenbaum)#49745test_runner:  * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow)#49753  * (SEMVER-MINOR) add junit reporter (Moshe Atlow)#49614  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975  * (SEMVER-MINOR) add shards support (Raz Luvaton)#48639  * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel)#47775test_runner, cli:  * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig)#49996tls:  * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry)#45190vm:  * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel)#50141wasi:  * (SEMVER-MINOR) updates required for latest uvwasi version (Michael Dawson)#49908PR-URL: TODO
targos added a commit that referenced this pull requestNov 28, 2023
Notable changes:deps:  * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot)#49908  * (SEMVER-MINOR) upgrade npm to 10.2.3 (npm team)#50531doc:  * move and rename loaders section (Geoffrey Booth)#49261esm:  * use import attributes instead of import assertions (Antoine du Hamel)#50140  * --experimental-default-type flag to flip module defaults (Geoffrey Booth)#49869  * unflag import.meta.resolve (Guy Bedford)#49028  * move hook execution to separate thread (Jacob Smith)#44710  * leverage loaders when resolving subsequent loaders (Maël Nison)#43772lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)#46391  * (SEMVER-MINOR) add tracing channel to diagnostics_channel (Stephen Belanger)#44943src:  * (SEMVER-MINOR) add cjs_module_lexer_version base64_version (Jithil P Ponnan)#45629stream:  * use bitmap in readable state (Benjamin Gruenbaum)#49745test_runner:  * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow)#49753  * (SEMVER-MINOR) add junit reporter (Moshe Atlow)#49614  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975  * (SEMVER-MINOR) add shards support (Raz Luvaton)#48639  * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel)#47775test_runner, cli:  * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig)#49996tls:  * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry)#45190vm:  * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel)#50141PR-URL:#50953
@targostargos mentioned this pull requestNov 28, 2023
targos added a commit that referenced this pull requestNov 29, 2023
Notable changes:deps:  * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot)#49908  * (SEMVER-MINOR) upgrade npm to 10.2.3 (npm team)#50531doc:  * move and rename loaders section (Geoffrey Booth)#49261esm:  * use import attributes instead of import assertions (Antoine du Hamel)#50140  * --experimental-default-type flag to flip module defaults (Geoffrey Booth)#49869  * unflag import.meta.resolve (Guy Bedford)#49028  * move hook execution to separate thread (Jacob Smith)#44710  * leverage loaders when resolving subsequent loaders (Maël Nison)#43772lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)#46391  * (SEMVER-MINOR) add tracing channel to diagnostics_channel (Stephen Belanger)#44943src:  * (SEMVER-MINOR) add cjs_module_lexer_version base64_version (Jithil P Ponnan)#45629stream:  * use bitmap in readable state (Benjamin Gruenbaum)#49745test_runner:  * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow)#49753  * (SEMVER-MINOR) add junit reporter (Moshe Atlow)#49614  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975  * (SEMVER-MINOR) add shards support (Raz Luvaton)#48639  * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel)#47775test_runner, cli:  * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig)#49996tls:  * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry)#45190vm:  * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel)#50141PR-URL:#50953
sercher added a commit to sercher/graaljs that referenced this pull requestApr 25, 2024
This commit adds each test's line and column number to the reporteroutput. This will aid in debugging test suite failures when errorstacks are not helpful, test suites are large, or tests have thesame name. This data is also exposed on the spec reporter.This commit also replaces the filename that was previously beingreported, with the filename where the test actually exists. Theseare normally correct, but could be wrong if tests were run froma file other than the user's entrypoint.PR-URL:nodejs/node#48975Fixes:nodejs/node#48457Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>Reviewed-By: Matteo Collina <matteo.collina@gmail.com>Reviewed-By: Chemi Atlow <chemi@atlow.co.il>Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull requestApr 25, 2024
Notable changes:deps:  * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot)nodejs/node#49908  * (SEMVER-MINOR) upgrade npm to 10.2.3 (npm team)nodejs/node#50531doc:  * move and rename loaders section (Geoffrey Booth)nodejs/node#49261esm:  * use import attributes instead of import assertions (Antoine du Hamel)nodejs/node#50140  * --experimental-default-type flag to flip module defaults (Geoffrey Booth)nodejs/node#49869  * unflag import.meta.resolve (Guy Bedford)nodejs/node#49028  * move hook execution to separate thread (Jacob Smith)nodejs/node#44710  * leverage loaders when resolving subsequent loaders (Maël Nison)nodejs/node#43772lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)nodejs/node#46391  * (SEMVER-MINOR) add tracing channel to diagnostics_channel (Stephen Belanger)nodejs/node#44943src:  * (SEMVER-MINOR) add cjs_module_lexer_version base64_version (Jithil P Ponnan)nodejs/node#45629stream:  * use bitmap in readable state (Benjamin Gruenbaum)nodejs/node#49745test_runner:  * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow)nodejs/node#49753  * (SEMVER-MINOR) add junit reporter (Moshe Atlow)nodejs/node#49614  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)nodejs/node#48975  * (SEMVER-MINOR) add shards support (Raz Luvaton)nodejs/node#48639  * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel)nodejs/node#47775test_runner, cli:  * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig)nodejs/node#49996tls:  * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry)nodejs/node#45190vm:  * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel)nodejs/node#50141PR-URL:nodejs/node#50953
sercher added a commit to sercher/graaljs that referenced this pull requestApr 25, 2024
This commit adds each test's line and column number to the reporteroutput. This will aid in debugging test suite failures when errorstacks are not helpful, test suites are large, or tests have thesame name. This data is also exposed on the spec reporter.This commit also replaces the filename that was previously beingreported, with the filename where the test actually exists. Theseare normally correct, but could be wrong if tests were run froma file other than the user's entrypoint.PR-URL:nodejs/node#48975Fixes:nodejs/node#48457Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>Reviewed-By: Matteo Collina <matteo.collina@gmail.com>Reviewed-By: Chemi Atlow <chemi@atlow.co.il>Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull requestApr 25, 2024
Notable changes:deps:  * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot)nodejs/node#49908  * (SEMVER-MINOR) upgrade npm to 10.2.3 (npm team)nodejs/node#50531doc:  * move and rename loaders section (Geoffrey Booth)nodejs/node#49261esm:  * use import attributes instead of import assertions (Antoine du Hamel)nodejs/node#50140  * --experimental-default-type flag to flip module defaults (Geoffrey Booth)nodejs/node#49869  * unflag import.meta.resolve (Guy Bedford)nodejs/node#49028  * move hook execution to separate thread (Jacob Smith)nodejs/node#44710  * leverage loaders when resolving subsequent loaders (Maël Nison)nodejs/node#43772lib:  * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green)nodejs/node#46391  * (SEMVER-MINOR) add tracing channel to diagnostics_channel (Stephen Belanger)nodejs/node#44943src:  * (SEMVER-MINOR) add cjs_module_lexer_version base64_version (Jithil P Ponnan)nodejs/node#45629stream:  * use bitmap in readable state (Benjamin Gruenbaum)nodejs/node#49745test_runner:  * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow)nodejs/node#49753  * (SEMVER-MINOR) add junit reporter (Moshe Atlow)nodejs/node#49614  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)nodejs/node#48975  * (SEMVER-MINOR) add shards support (Raz Luvaton)nodejs/node#48639  * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel)nodejs/node#47775test_runner, cli:  * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig)nodejs/node#49996tls:  * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry)nodejs/node#45190vm:  * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel)nodejs/node#50141PR-URL:nodejs/node#50953
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ljharbljharbljharb left review comments

@MoLowMoLowMoLow approved these changes

@mcollinamcollinamcollina approved these changes

@anonriganonriganonrig approved these changes

@atlowChemiatlowChemiatlowChemi approved these changes

Assignees
No one assigned
Labels
backported-to-v20.xPRs backported to the v20.x-staging branch.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.semver-minorPRs that contain new features and should be released in the next minor version.test_runnerIssues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test runner to include the name of the file being run
11 participants
@cjihrig@nodejs-github-bot@benjamingr@ljharb@rluvaton@mcollina@RafaelGSS@anonrig@MoLow@atlowChemi@targos
[8]ページ先頭
©2009-2025 Movatter.jp