It expresses the intent in a clearer way.Refs:nodejs#48191 (comment)Signed-off-by: Darshan Sen <raisinten@gmail.com>

Refs:nodejs#48191 (comment)Signed-off-by: Darshan Sen <raisinten@gmail.com>

Refs:nodejs#48191 (comment)Signed-off-by: Darshan Sen <raisinten@gmail.com>

Refs:nodejs#48191 (comment)Signed-off-by: Darshan Sen <raisinten@gmail.com>

Refs:nodejs#48191 (comment)Signed-off-by: Darshan Sen <raisinten@gmail.com>

Refs:nodejs#48191 (comment)Signed-off-by: Darshan Sen <raisinten@gmail.com>

Original commit message:    [compiler] fix CompileFunction ignoring kEagerCompile    v8::ScriptCompiler::CompileFunction was ignoring kEagerCompile. Unlike    the other functions in v8::ScriptCompiler, it was not actually    propagating kEagerCompile to the parser. The newly updated test fails    without this change.    I did some archeology and found that this was commented out since the    original CL inhttps://crrev.com/c/980944.    As far as I know Node.js is the main consumer of this particular API.    This CL speeds up Node.js's overall startup time by ~13%.    Change-Id: Ifc3cd6653555194d46ca48db14f7ba7a4afe0053    Reviewed-on:https://chromium-review.googlesource.com/c/v8/v8/+/4571822    Commit-Queue: Marja Hölttä <marja@chromium.org>    Reviewed-by: Marja Hölttä <marja@chromium.org>    Cr-Commit-Position: refs/heads/main@{#87944}Refs:v8/v8@cb00db4Refs:nodejs#48191 (comment)Signed-off-by: Darshan Sen <raisinten@gmail.com>

It expresses the intent in a clearer way.Refs:nodejs#48191 (comment)Signed-off-by: Darshan Sen <raisinten@gmail.com>

Refs:nodejs#48191 (comment)Signed-off-by: Darshan Sen <raisinten@gmail.com>

Refs:nodejs#48191 (comment)Signed-off-by: Darshan Sen <raisinten@gmail.com>

Refs:nodejs/single-executable#73Signed-off-by: Darshan Sen <raisinten@gmail.com>PR-URL:nodejs#48191Fixes:nodejs/single-executable#73Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Refs:nodejs/single-executable#73Signed-off-by: Darshan Sen <raisinten@gmail.com>PR-URL:nodejs#48191Fixes:nodejs/single-executable#73Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Refs:nodejs/single-executable#73Signed-off-by: Darshan Sen <raisinten@gmail.com>PR-URL:nodejs#48191Fixes:nodejs/single-executable#73Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Refs:nodejs/single-executable#73Signed-off-by: Darshan Sen <raisinten@gmail.com>PR-URL:nodejs#48191Fixes:nodejs/single-executable#73Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Refs:nodejs/single-executable#73Signed-off-by: Darshan Sen <raisinten@gmail.com>PR-URL:nodejs#48191Fixes:nodejs/single-executable#73Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Refs:nodejs/single-executable#73Signed-off-by: Darshan Sen <raisinten@gmail.com>PR-URL:nodejs#48191Fixes:nodejs/single-executable#73Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Refs:nodejs/single-executable#73Signed-off-by: Darshan Sen <raisinten@gmail.com>PR-URL:#48191Fixes:nodejs/single-executable#73Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Refs:nodejs/single-executable#73Signed-off-by: Darshan Sen <raisinten@gmail.com>PR-URL:#48191Fixes:nodejs/single-executable#73Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

nodejs/node#48191

nodejs/node#48191

nodejs/node#48191

nodejs/node#48191

nodejs/node#48191

nodejs/node#48191

nodejs/node#48191

nodejs/node#48191

* chore: upgrade to Node.js v20* src: allow embedders to override NODE_MODULE_VERSIONnodejs/node#49279* src: fix missing trailing ,nodejs/node#46909* src,tools: initialize cppgcnodejs/node#45704* tools: allow passing absolute path of config.gypi in js2cnodejs/node#49162* tools: port js2c.py to C++nodejs/node#46997* doc,lib: disambiguate the old term, NativeModulenodejs/node#45673* chore: fixup Node.js BSSL tests*nodejs/node#49492*nodejs/node#44498* deps: upgrade to libuv 1.45.0nodejs/node#48078* deps: update V8 to 10.7nodejs/node#44741* test: use gcUntil() in test-v8-serialize-leaknodejs/node#49168* module: make CJS load from ESM loadernodejs/node#47999* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* chore: address changes to CJS/ESM loading* module: make CJS load from ESM loader (nodejs/node#47999)* lib: improve esm resolve performance (nodejs/node#46652)* bootstrap: optimize modules loaded in the built-in snapshotnodejs/node#45849* test: mark test-runner-output as flakynodejs/node#49854* lib: lazy-load deps in modules/run_main.jsnodejs/node#45849* url: use private properties for brand checknodejs/node#46904* test: refactor `test-node-output-errors`nodejs/node#48992* assert: deprecate callTrackernodejs/node#47740* src: cast v8::Object::GetInternalField() return value to v8::Valuenodejs/node#48943* test: adapt test-v8-stats for V8 updatenodejs/node#45230* tls: ensure TLS Sockets are closed if the underlying wrapclosesnodejs/node#49327* test: deflake test-tls-socket-closenodejs/node#49575* net: fix crash due to simultaneous close/shutdown on JS Stream Socketsnodejs/node#49400* net: use asserts in JS Socket Stream to catch races in futurenodejs/node#49400* lib: fix BroadcastChannel initialization locationnodejs/node#46864* src: create BaseObject with node::Realmnodejs/node#44348* src: implement DataQueue and non-memory resident Blobnodejs/node#45258* sea: add support for V8 bytecode-only cachingnodejs/node#48191* chore: fixup patch indices* gyp: put filenames in variablesnodejs/node#46965* build: modify js2c.py into GN executable* fix: (WIP) handle string replacement of fs -> original-fs* [v20.x] backport vm-related memoryfixesnodejs/node#49874* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* src: avoid copying string in fs_permissionnodejs/node#47746* look upon my works ye mightyand dispair* chore: patch cleanup* [api] Remove AllCan Read/Writehttps://chromium-review.googlesource.com/c/v8/v8/+/5006387* fix: missing include for NODE_EXTERN* chore: fixup patch indices* fix: fail properly when js2c fails in Node.js* build: fix js2c root_gen_dir* fix: lib/fs.js -> lib/original-fs.js* build: fix original-fs file xforms* fixup! module: make CJS load from ESM loader* build: get rid of CppHeap for now* build: add patch to prevent extra fs lookup on esm load* build: greatly simplify js2c modificationsMoves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c* chore: update to handle moved internal/modules/helpers file* test: update @types/node test* feat: enable preventing cppgc heap creation* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler* fix: no cppgc initialization in the renderer* gyp: put filenames in variablesnodejs/node#46965* test: disable single executable tests* fix: nan tests failing on node headers missing file* tls,http2: send fatal alert on ALPN mismatchnodejs/node#44031* test: disable snapshot tests*nodejs/node#47887*nodejs/node#49684*nodejs/node#44193* build: use deps/v8 for v8/toolsNode.js hard depends on these in their builtins* test: fix edge snapshot stack tracesnodejs/node#49659* build: remove js2c //base dep* build: use electron_js2c_toolchain to build node_js2c* fix: don't create SafeSet outside packageResolveFixes failure in parallel/test-require-delete-array-iterator:=== release test-require-delete-array-iterator ===Path: parallel/test-require-delete-array-iteratornode:internal/per_context/primordials:426    constructor(i) { super(i); } // eslint-disable-line no-useless-constructor                     ^TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator))    at new Set (<anonymous>)    at new SafeSet (node:internal/per_context/primordials:426:22)* fix: failing crashReporter tests on LinuxThese were failing because our change from node::InitializeNodeWithArgs tonode::InitializeOncePerProcess meant that we now inadvertently calledPlatformInit, which reset signal handling. This meant that our intentionalcrash function ElectronBindings::Crash no longer worked and the renderer processno longer crashed when process.crash() was called. We don't want to use Node.js'default signal handling in the renderer process, so we disable it by passingkNoDefaultSignalHandling to node::InitializeOncePerProcess.* build: only create cppgc heap on non-32 bit platforms* chore: clean up util:CompileAndCall* src: fix compatility with upcoming V8 12.1 APIsnodejs/node#50709* fix: use thread_local BuiltinLoader* chore: fixup v8 patch indices---------Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>

* chore: upgrade to Node.js v20* src: allow embedders to override NODE_MODULE_VERSIONnodejs/node#49279* src: fix missing trailing ,nodejs/node#46909* src,tools: initialize cppgcnodejs/node#45704* tools: allow passing absolute path of config.gypi in js2cnodejs/node#49162* tools: port js2c.py to C++nodejs/node#46997* doc,lib: disambiguate the old term, NativeModulenodejs/node#45673* chore: fixup Node.js BSSL tests*nodejs/node#49492*nodejs/node#44498* deps: upgrade to libuv 1.45.0nodejs/node#48078* deps: update V8 to 10.7nodejs/node#44741* test: use gcUntil() in test-v8-serialize-leaknodejs/node#49168* module: make CJS load from ESM loadernodejs/node#47999* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* chore: address changes to CJS/ESM loading* module: make CJS load from ESM loader (nodejs/node#47999)* lib: improve esm resolve performance (nodejs/node#46652)* bootstrap: optimize modules loaded in the built-in snapshotnodejs/node#45849* test: mark test-runner-output as flakynodejs/node#49854* lib: lazy-load deps in modules/run_main.jsnodejs/node#45849* url: use private properties for brand checknodejs/node#46904* test: refactor `test-node-output-errors`nodejs/node#48992* assert: deprecate callTrackernodejs/node#47740* src: cast v8::Object::GetInternalField() return value to v8::Valuenodejs/node#48943* test: adapt test-v8-stats for V8 updatenodejs/node#45230* tls: ensure TLS Sockets are closed if the underlying wrapclosesnodejs/node#49327* test: deflake test-tls-socket-closenodejs/node#49575* net: fix crash due to simultaneous close/shutdown on JS Stream Socketsnodejs/node#49400* net: use asserts in JS Socket Stream to catch races in futurenodejs/node#49400* lib: fix BroadcastChannel initialization locationnodejs/node#46864* src: create BaseObject with node::Realmnodejs/node#44348* src: implement DataQueue and non-memory resident Blobnodejs/node#45258* sea: add support for V8 bytecode-only cachingnodejs/node#48191* chore: fixup patch indices* gyp: put filenames in variablesnodejs/node#46965* build: modify js2c.py into GN executable* fix: (WIP) handle string replacement of fs -> original-fs* [v20.x] backport vm-related memoryfixesnodejs/node#49874* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* src: avoid copying string in fs_permissionnodejs/node#47746* look upon my works ye mightyand dispair* chore: patch cleanup* [api] Remove AllCan Read/Writehttps://chromium-review.googlesource.com/c/v8/v8/+/5006387* fix: missing include for NODE_EXTERN* chore: fixup patch indices* fix: fail properly when js2c fails in Node.js* build: fix js2c root_gen_dir* fix: lib/fs.js -> lib/original-fs.js* build: fix original-fs file xforms* fixup! module: make CJS load from ESM loader* build: get rid of CppHeap for now* build: add patch to prevent extra fs lookup on esm load* build: greatly simplify js2c modificationsMoves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c* chore: update to handle moved internal/modules/helpers file* test: update @types/node test* feat: enable preventing cppgc heap creation* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler* fix: no cppgc initialization in the renderer* gyp: put filenames in variablesnodejs/node#46965* test: disable single executable tests* fix: nan tests failing on node headers missing file* tls,http2: send fatal alert on ALPN mismatchnodejs/node#44031* test: disable snapshot tests*nodejs/node#47887*nodejs/node#49684*nodejs/node#44193* build: use deps/v8 for v8/toolsNode.js hard depends on these in their builtins* test: fix edge snapshot stack tracesnodejs/node#49659* build: remove js2c //base dep* build: use electron_js2c_toolchain to build node_js2c* fix: don't create SafeSet outside packageResolveFixes failure in parallel/test-require-delete-array-iterator:=== release test-require-delete-array-iterator ===Path: parallel/test-require-delete-array-iteratornode:internal/per_context/primordials:426    constructor(i) { super(i); } // eslint-disable-line no-useless-constructor                     ^TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator))    at new Set (<anonymous>)    at new SafeSet (node:internal/per_context/primordials:426:22)* fix: failing crashReporter tests on LinuxThese were failing because our change from node::InitializeNodeWithArgs tonode::InitializeOncePerProcess meant that we now inadvertently calledPlatformInit, which reset signal handling. This meant that our intentionalcrash function ElectronBindings::Crash no longer worked and the renderer processno longer crashed when process.crash() was called. We don't want to use Node.js'default signal handling in the renderer process, so we disable it by passingkNoDefaultSignalHandling to node::InitializeOncePerProcess.* build: only create cppgc heap on non-32 bit platforms* chore: clean up util:CompileAndCall* src: fix compatility with upcoming V8 12.1 APIsnodejs/node#50709* fix: use thread_local BuiltinLoader* chore: fixup v8 patch indices---------Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>