Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
deps: upgrade to libuv 1.45.0#48078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does the newLICENSE-extra
file present a problem for the license builder?
It seems that this fixes#3020 (at least on some platforms) 🥳 |
santigimeno commentedMay 19, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This is fixed in the uvwasi upgrade#47866 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🚀
CI is still failing on |
8457895
toe28f630
CompareNotable changes:build: * sync libuv header change (Jiawen Geng)#48078crypto: * update root certificates to NSS 3.90 (Node.js GitHub Bot)#48416deps: * add missing thread-common.c in uv.gyp (Santiago Gimeno)#48078 * upgrade to libuv 1.46.0 (Santiago Gimeno)#48078 * upgrade to libuv 1.45.0 (Santiago Gimeno)#48078doc: * add vmoroz to collaborators (Vladimir Morozov)#48527 * add kvakil to collaborators (Keyhan Vakil)#48449esm: * (SEMVER-MINOR) add `--import` flag (Moshe Atlow)#43942events: * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow)#48596fs, stream: * initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow)#48518net: * add autoSelectFamily global getter and setter (Paolo Insogna)#45777url: * (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham)#47885PR-URL:#49220
Notable changes:build: * sync libuv header change (Jiawen Geng)#48078crypto: * update root certificates to NSS 3.93 (Node.js GitHub Bot)#49341 * update root certificates to NSS 3.90 (Node.js GitHub Bot)#48416deps: * add missing thread-common.c in uv.gyp (Santiago Gimeno)#48078 * upgrade to libuv 1.46.0 (Santiago Gimeno)#48078 * upgrade to libuv 1.45.0 (Santiago Gimeno)#48078doc: * add atlowChemi to collaborators (atlowChemi)#48757 * add vmoroz to collaborators (Vladimir Morozov)#48527 * add kvakil to collaborators (Keyhan Vakil)#48449esm: * (SEMVER-MINOR) add `--import` flag (Moshe Atlow)#43942events: * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow)#48596fs, stream: * initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow)#48518net: * add autoSelectFamily global getter and setter (Paolo Insogna)#45777url: * (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham)#47885PR-URL:#49220
- linux: introduce io_uring supportlibuv/libuv#3952- src: add new metrics APIslibuv/libuv#3749- unix,win: give thread pool threads an 8 MB stacklibuv/libuv#3787- win,unix: change execution order of timerslibuv/libuv#3927Fixes:#43931Fixes:#42496Fixes:#47715Fixes:#47259Fixes:#47241PR-URL:#48078Backport-PR-URL:#49591Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>Reviewed-By: Luigi Pinca <luigipinca@gmail.com>Reviewed-By: Colin Ihrig <cjihrig@gmail.com>Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>Reviewed-By: Michaël Zasso <targos@protonmail.com>Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>Reviewed-By: Richard Lau <rlau@redhat.com>Reviewed-By: Tobias Nießen <tniessen@tnie.de>Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Notable changes- fs: use WTF-8 on Windows:libuv/libuv#2970- linux: add some more iouring backed fs ops:libuv/libuv#4012Important bugs fixed- linux: work around io_uring IORING_OP_CLOSE bug:libuv/libuv#4059- src: don't run timers if loop is stopped/unref'd:libuv/libuv#4048PR-URL:#48618Backport-PR-URL:#49591Fixes:#48512Reviewed-By: Colin Ihrig <cjihrig@gmail.com>Reviewed-By: Richard Lau <rlau@redhat.com>Reviewed-By: Luigi Pinca <luigipinca@gmail.com>Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>PR-URL:#48078
Notable changes:build: * sync libuv header change (Jiawen Geng)#48078crypto: * update root certificates to NSS 3.93 (Node.js GitHub Bot)#49341 * update root certificates to NSS 3.90 (Node.js GitHub Bot)#48416deps: * add missing thread-common.c in uv.gyp (Santiago Gimeno)#48078 * upgrade to libuv 1.46.0 (Santiago Gimeno)#48078 * upgrade to libuv 1.45.0 (Santiago Gimeno)#48078doc: * add atlowChemi to collaborators (atlowChemi)#48757 * add vmoroz to collaborators (Vladimir Morozov)#48527 * add kvakil to collaborators (Keyhan Vakil)#48449esm: * (SEMVER-MINOR) add `--import` flag (Moshe Atlow)#43942events: * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow)#48596fs, stream: * initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow)#48518net: * add autoSelectFamily global getter and setter (Paolo Insogna)#45777url: * (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham)#47885PR-URL:#49220
- linux: introduce io_uring supportlibuv/libuv#3952- src: add new metrics APIslibuv/libuv#3749- unix,win: give thread pool threads an 8 MB stacklibuv/libuv#3787- win,unix: change execution order of timerslibuv/libuv#3927Fixes:#43931Fixes:#42496Fixes:#47715Fixes:#47259Fixes:#47241PR-URL:#48078Backport-PR-URL:#49591Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>Reviewed-By: Luigi Pinca <luigipinca@gmail.com>Reviewed-By: Colin Ihrig <cjihrig@gmail.com>Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>Reviewed-By: Michaël Zasso <targos@protonmail.com>Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>Reviewed-By: Richard Lau <rlau@redhat.com>Reviewed-By: Tobias Nießen <tniessen@tnie.de>Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Notable changes- fs: use WTF-8 on Windows:libuv/libuv#2970- linux: add some more iouring backed fs ops:libuv/libuv#4012Important bugs fixed- linux: work around io_uring IORING_OP_CLOSE bug:libuv/libuv#4059- src: don't run timers if loop is stopped/unref'd:libuv/libuv#4048PR-URL:#48618Backport-PR-URL:#49591Fixes:#48512Reviewed-By: Colin Ihrig <cjihrig@gmail.com>Reviewed-By: Richard Lau <rlau@redhat.com>Reviewed-By: Luigi Pinca <luigipinca@gmail.com>Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>PR-URL:#48078
Notable changes:build: * sync libuv header change (Jiawen Geng)#48078crypto: * update root certificates to NSS 3.93 (Node.js GitHub Bot)#49341 * update root certificates to NSS 3.90 (Node.js GitHub Bot)#48416deps: * add missing thread-common.c in uv.gyp (Santiago Gimeno)#48078 * upgrade to libuv 1.46.0 (Santiago Gimeno)#48078 * upgrade to libuv 1.45.0 (Santiago Gimeno)#48078doc: * add atlowChemi to collaborators (atlowChemi)#48757 * add vmoroz to collaborators (Vladimir Morozov)#48527 * add kvakil to collaborators (Keyhan Vakil)#48449esm: * (SEMVER-MINOR) add `--import` flag (Moshe Atlow)#43942events: * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow)#48596fs, stream: * initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow)#48518net: * add autoSelectFamily global getter and setter (Paolo Insogna)#45777url: * (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham)#47885PR-URL:#49220
Notable changes:build: * sync libuv header change (Jiawen Geng)#48078crypto: * update root certificates to NSS 3.93 (Node.js GitHub Bot)#49341 * update root certificates to NSS 3.90 (Node.js GitHub Bot)#48416deps: * add missing thread-common.c in uv.gyp (Santiago Gimeno)#48078 * upgrade to libuv 1.46.0 (Santiago Gimeno)#48078 * upgrade to libuv 1.45.0 (Santiago Gimeno)#48078doc: * add atlowChemi to collaborators (atlowChemi)#48757 * add vmoroz to collaborators (Vladimir Morozov)#48527 * add kvakil to collaborators (Keyhan Vakil)#48449esm: * (SEMVER-MINOR) add `--import` flag (Moshe Atlow)#43942events: * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow)#48596fs, stream: * initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow)#48518net: * add autoSelectFamily global getter and setter (Paolo Insogna)#45777url: * (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham)#47885PR-URL:#49220
Notable changes:build: * sync libuv header change (Jiawen Geng)nodejs#48078crypto: * update root certificates to NSS 3.93 (Node.js GitHub Bot)nodejs#49341 * update root certificates to NSS 3.90 (Node.js GitHub Bot)nodejs#48416deps: * add missing thread-common.c in uv.gyp (Santiago Gimeno)nodejs#48078 * upgrade to libuv 1.46.0 (Santiago Gimeno)nodejs#48078 * upgrade to libuv 1.45.0 (Santiago Gimeno)nodejs#48078doc: * add atlowChemi to collaborators (atlowChemi)nodejs#48757 * add vmoroz to collaborators (Vladimir Morozov)nodejs#48527 * add kvakil to collaborators (Keyhan Vakil)nodejs#48449esm: * (SEMVER-MINOR) add `--import` flag (Moshe Atlow)nodejs#43942events: * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow)nodejs#48596fs, stream: * initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow)nodejs#48518net: * add autoSelectFamily global getter and setter (Paolo Insogna)nodejs#45777url: * (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham)nodejs#47885PR-URL:nodejs#49220
* chore: upgrade to Node.js v20* src: allow embedders to override NODE_MODULE_VERSIONnodejs/node#49279* src: fix missing trailing ,nodejs/node#46909* src,tools: initialize cppgcnodejs/node#45704* tools: allow passing absolute path of config.gypi in js2cnodejs/node#49162* tools: port js2c.py to C++nodejs/node#46997* doc,lib: disambiguate the old term, NativeModulenodejs/node#45673* chore: fixup Node.js BSSL tests*nodejs/node#49492*nodejs/node#44498* deps: upgrade to libuv 1.45.0nodejs/node#48078* deps: update V8 to 10.7nodejs/node#44741* test: use gcUntil() in test-v8-serialize-leaknodejs/node#49168* module: make CJS load from ESM loadernodejs/node#47999* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* chore: address changes to CJS/ESM loading* module: make CJS load from ESM loader (nodejs/node#47999)* lib: improve esm resolve performance (nodejs/node#46652)* bootstrap: optimize modules loaded in the built-in snapshotnodejs/node#45849* test: mark test-runner-output as flakynodejs/node#49854* lib: lazy-load deps in modules/run_main.jsnodejs/node#45849* url: use private properties for brand checknodejs/node#46904* test: refactor `test-node-output-errors`nodejs/node#48992* assert: deprecate callTrackernodejs/node#47740* src: cast v8::Object::GetInternalField() return value to v8::Valuenodejs/node#48943* test: adapt test-v8-stats for V8 updatenodejs/node#45230* tls: ensure TLS Sockets are closed if the underlying wrapclosesnodejs/node#49327* test: deflake test-tls-socket-closenodejs/node#49575* net: fix crash due to simultaneous close/shutdown on JS Stream Socketsnodejs/node#49400* net: use asserts in JS Socket Stream to catch races in futurenodejs/node#49400* lib: fix BroadcastChannel initialization locationnodejs/node#46864* src: create BaseObject with node::Realmnodejs/node#44348* src: implement DataQueue and non-memory resident Blobnodejs/node#45258* sea: add support for V8 bytecode-only cachingnodejs/node#48191* chore: fixup patch indices* gyp: put filenames in variablesnodejs/node#46965* build: modify js2c.py into GN executable* fix: (WIP) handle string replacement of fs -> original-fs* [v20.x] backport vm-related memoryfixesnodejs/node#49874* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* src: avoid copying string in fs_permissionnodejs/node#47746* look upon my works ye mightyand dispair* chore: patch cleanup* [api] Remove AllCan Read/Writehttps://chromium-review.googlesource.com/c/v8/v8/+/5006387* fix: missing include for NODE_EXTERN* chore: fixup patch indices* fix: fail properly when js2c fails in Node.js* build: fix js2c root_gen_dir* fix: lib/fs.js -> lib/original-fs.js* build: fix original-fs file xforms* fixup! module: make CJS load from ESM loader* build: get rid of CppHeap for now* build: add patch to prevent extra fs lookup on esm load* build: greatly simplify js2c modificationsMoves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c* chore: update to handle moved internal/modules/helpers file* test: update @types/node test* feat: enable preventing cppgc heap creation* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler* fix: no cppgc initialization in the renderer* gyp: put filenames in variablesnodejs/node#46965* test: disable single executable tests* fix: nan tests failing on node headers missing file* tls,http2: send fatal alert on ALPN mismatchnodejs/node#44031* test: disable snapshot tests*nodejs/node#47887*nodejs/node#49684*nodejs/node#44193* build: use deps/v8 for v8/toolsNode.js hard depends on these in their builtins* test: fix edge snapshot stack tracesnodejs/node#49659* build: remove js2c //base dep* build: use electron_js2c_toolchain to build node_js2c* fix: don't create SafeSet outside packageResolveFixes failure in parallel/test-require-delete-array-iterator:=== release test-require-delete-array-iterator ===Path: parallel/test-require-delete-array-iteratornode:internal/per_context/primordials:426 constructor(i) { super(i); } // eslint-disable-line no-useless-constructor ^TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator)) at new Set (<anonymous>) at new SafeSet (node:internal/per_context/primordials:426:22)* fix: failing crashReporter tests on LinuxThese were failing because our change from node::InitializeNodeWithArgs tonode::InitializeOncePerProcess meant that we now inadvertently calledPlatformInit, which reset signal handling. This meant that our intentionalcrash function ElectronBindings::Crash no longer worked and the renderer processno longer crashed when process.crash() was called. We don't want to use Node.js'default signal handling in the renderer process, so we disable it by passingkNoDefaultSignalHandling to node::InitializeOncePerProcess.* build: only create cppgc heap on non-32 bit platforms* chore: clean up util:CompileAndCall* src: fix compatility with upcoming V8 12.1 APIsnodejs/node#50709* fix: use thread_local BuiltinLoader* chore: fixup v8 patch indices---------Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
* chore: upgrade to Node.js v20* src: allow embedders to override NODE_MODULE_VERSIONnodejs/node#49279* src: fix missing trailing ,nodejs/node#46909* src,tools: initialize cppgcnodejs/node#45704* tools: allow passing absolute path of config.gypi in js2cnodejs/node#49162* tools: port js2c.py to C++nodejs/node#46997* doc,lib: disambiguate the old term, NativeModulenodejs/node#45673* chore: fixup Node.js BSSL tests*nodejs/node#49492*nodejs/node#44498* deps: upgrade to libuv 1.45.0nodejs/node#48078* deps: update V8 to 10.7nodejs/node#44741* test: use gcUntil() in test-v8-serialize-leaknodejs/node#49168* module: make CJS load from ESM loadernodejs/node#47999* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* chore: address changes to CJS/ESM loading* module: make CJS load from ESM loader (nodejs/node#47999)* lib: improve esm resolve performance (nodejs/node#46652)* bootstrap: optimize modules loaded in the built-in snapshotnodejs/node#45849* test: mark test-runner-output as flakynodejs/node#49854* lib: lazy-load deps in modules/run_main.jsnodejs/node#45849* url: use private properties for brand checknodejs/node#46904* test: refactor `test-node-output-errors`nodejs/node#48992* assert: deprecate callTrackernodejs/node#47740* src: cast v8::Object::GetInternalField() return value to v8::Valuenodejs/node#48943* test: adapt test-v8-stats for V8 updatenodejs/node#45230* tls: ensure TLS Sockets are closed if the underlying wrapclosesnodejs/node#49327* test: deflake test-tls-socket-closenodejs/node#49575* net: fix crash due to simultaneous close/shutdown on JS Stream Socketsnodejs/node#49400* net: use asserts in JS Socket Stream to catch races in futurenodejs/node#49400* lib: fix BroadcastChannel initialization locationnodejs/node#46864* src: create BaseObject with node::Realmnodejs/node#44348* src: implement DataQueue and non-memory resident Blobnodejs/node#45258* sea: add support for V8 bytecode-only cachingnodejs/node#48191* chore: fixup patch indices* gyp: put filenames in variablesnodejs/node#46965* build: modify js2c.py into GN executable* fix: (WIP) handle string replacement of fs -> original-fs* [v20.x] backport vm-related memoryfixesnodejs/node#49874* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* src: avoid copying string in fs_permissionnodejs/node#47746* look upon my works ye mightyand dispair* chore: patch cleanup* [api] Remove AllCan Read/Writehttps://chromium-review.googlesource.com/c/v8/v8/+/5006387* fix: missing include for NODE_EXTERN* chore: fixup patch indices* fix: fail properly when js2c fails in Node.js* build: fix js2c root_gen_dir* fix: lib/fs.js -> lib/original-fs.js* build: fix original-fs file xforms* fixup! module: make CJS load from ESM loader* build: get rid of CppHeap for now* build: add patch to prevent extra fs lookup on esm load* build: greatly simplify js2c modificationsMoves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c* chore: update to handle moved internal/modules/helpers file* test: update @types/node test* feat: enable preventing cppgc heap creation* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler* fix: no cppgc initialization in the renderer* gyp: put filenames in variablesnodejs/node#46965* test: disable single executable tests* fix: nan tests failing on node headers missing file* tls,http2: send fatal alert on ALPN mismatchnodejs/node#44031* test: disable snapshot tests*nodejs/node#47887*nodejs/node#49684*nodejs/node#44193* build: use deps/v8 for v8/toolsNode.js hard depends on these in their builtins* test: fix edge snapshot stack tracesnodejs/node#49659* build: remove js2c //base dep* build: use electron_js2c_toolchain to build node_js2c* fix: don't create SafeSet outside packageResolveFixes failure in parallel/test-require-delete-array-iterator:=== release test-require-delete-array-iterator ===Path: parallel/test-require-delete-array-iteratornode:internal/per_context/primordials:426 constructor(i) { super(i); } // eslint-disable-line no-useless-constructor ^TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator)) at new Set (<anonymous>) at new SafeSet (node:internal/per_context/primordials:426:22)* fix: failing crashReporter tests on LinuxThese were failing because our change from node::InitializeNodeWithArgs tonode::InitializeOncePerProcess meant that we now inadvertently calledPlatformInit, which reset signal handling. This meant that our intentionalcrash function ElectronBindings::Crash no longer worked and the renderer processno longer crashed when process.crash() was called. We don't want to use Node.js'default signal handling in the renderer process, so we disable it by passingkNoDefaultSignalHandling to node::InitializeOncePerProcess.* build: only create cppgc heap on non-32 bit platforms* chore: clean up util:CompileAndCall* src: fix compatility with upcoming V8 12.1 APIsnodejs/node#50709* fix: use thread_local BuiltinLoader* chore: fixup v8 patch indices---------Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
Uh oh!
There was an error while loading.Please reload this page.
Still I need to add the list of notable changes and bugs this fixes, but let's see how the CI goes.Notable changes
Fixes
dgram
sockets can only receive one UDP datagram per event loop iteration #43931