Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

src,tools: initialize cppgc#45704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfromdharesign:initialize-cppgc
Aug 11, 2023

Conversation

dharesign
Copy link
Contributor

@dharesigndharesign commentedDec 1, 2022
edited by joyeecheung
Loading

This patch:

  • Initializes cppgc in InitializeOncePerProcess() when
    kNoInitializeCppgc is not set
  • Create a CppHeap and attach it to the Isolate when
    there isn't one already during IsolateData initialization.
    The CppHeap is detached and terminated when IsolateData
    is freed.
  • Publishes the cppgc headers in the tarball.

This allows C++ addons to start using cppgc to manage objects.

A helper node::SetCppgcReference() is also added to help addons
enable cppgc tracing in a user-defined object.

Refs:#40786
Refs:https://docs.google.com/document/d/1ny2Qz_EsUnXGKJRGxoA-FXIE2xpLgaMAN6jD7eAkqFQ/edit

addaleax, bricss, kvakil, and gengjiawen reacted with eyes emoji
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-botnodejs-github-bot added c++Issues and PRs that require attention from people who are familiar with C++. lib / srcIssues and PRs related to general changes in the lib or src directory. needs-ciPRs that need a full CI run. labelsDec 1, 2022
@dharesigndharesign marked this pull request as ready for reviewDecember 10, 2022 01:00
@dharesign
Copy link
ContributorAuthor

In Electron, the cppgc heap will be initialized by Chromium. I don't think anything in this PR clashes with what Electron will want.

When they initialize node, they can usekNoInitializeCppgc here:
https://github.com/electron/electron/blob/4e661842879ae0cb01a9fc251d56c8cabc958466/shell/app/node_main.cc#L161-L165

They don't useNodeMainInstance orCommonEnvironmentSetup.

CC:@codebytere /@nornagon for awareness

@nornagon
Copy link
Contributor

FYI I believe we don't currently initialize cppgc in the main process in Electron (though Blink does of course initialize it). So we would want to be able to initialize Nodewith cppgc initialization in the main process (either by doing it ourselves or through this initialization option), andwithout cppgc initialization in the renderer process (since that would clash with Blink's initialization).

@dharesign
Copy link
ContributorAuthor

Erp, I hit the close button by mistake. Please re-approve running the workflows >_<

@dharesign
Copy link
ContributorAuthor

The previous test runs seemed to fail, and actually running my local build of node likewise fails. It seems to be due to a bug in v8:

https://github.com/v8/v8/blob/main/src/heap/cppgc/heap-base.cc#L104

I believe this should bedelgate_ notdelegate: the latter is moved from.

CC:@mlippautz

@dharesign
Copy link
ContributorAuthor

The previous test runs seemed to fail, and actually running my local build of node likewise fails. It seems to be due to a bug in v8:

https://github.com/v8/v8/blob/main/src/heap/cppgc/heap-base.cc#L104

I believe this should bedelgate_ notdelegate: the latter is moved from.

CC:@mlippautz

Yep, changing that fixes my local build.

@dharesign
Copy link
ContributorAuthor

The previous test runs seemed to fail, and actually running my local build of node likewise fails. It seems to be due to a bug in v8:
https://github.com/v8/v8/blob/main/src/heap/cppgc/heap-base.cc#L104
I believe this should bedelgate_ notdelegate: the latter is moved from.
CC:@mlippautz

Yep, changing that fixes my local build.

I added a second commit to this PR which fixes the above. We can switch the commit to cherry-pick the v8 commit once it gets fixed there. Hopefully the CI checks will proceed now.

@nodejs-github-bot
Copy link
Collaborator

@dharesign
Copy link
ContributorAuthor

Node is still segfaulting when I run it locally:

* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)    frame #0: 0x0000000100a5c14c node`cppgc::internal::MarkerBase::EnterAtomicPause(cppgc::EmbedderStackState) [inlined] cppgc::internal::SingleThreadedHandle::Cancel(this=<unavailable>) at task-handle.h:27:20 [opt]   24   25    void Cancel() {   26      DCHECK(is_cancelled_);-> 27      *is_cancelled_ = true;   28    }   29   30    bool IsCanceled() const {Target 0: (node) stopped.(lldb) frame sel 1frame #1: 0x0000000100a5c144 node`cppgc::internal::MarkerBase::EnterAtomicPause(this=0x0000000106808200, stack_state=kNoHeapPointers) at marker.cc:260:33 [opt]   257     // Cancel remaining incremental tasks. Concurrent marking jobs are left to   258     // run in parallel with the atomic pause until the mutator thread runs out   259     // of work.-> 260     incremental_marking_handle_.Cancel();   261     heap().stats_collector()->UnregisterObserver(   262         incremental_marking_allocation_observer_.get());   263     incremental_marking_allocation_observer_.reset();(lldb) print incremental_marking_handle_(cppgc::internal::MarkerBase::IncrementalMarkingTaskHandle) $0 = {  is_cancelled_ = nullptr {    __ptr_ = 0x0000000000000000  }}

It looks likeforeground_task_runner_ isnullptr, soMarkerBase::ScheduleIncrementalTaskRunner exits early before initializingincremental_marking_handle_. Later,MarkerBase::EnterAtomicPause assumes thatincremental_marking_handle_ is set such that it can call.Cancel(), but it's not.

@dharesign
Copy link
ContributorAuthor

Looks like there's noisolate_ set in theCppgcPlatformAdapter, which impliesCppHeap::AttachIsolate has not been called, though it has.

After digging a bit, it's becauseCppHeap::AttachIsolate doesstatic_cast<CppgcPlatformAdapter*>(platform()), whereplatform() in this case is actuallyPlatformWithPageAllocator. Thestatic_cast is therefore invalid.

CC:@mlippautz

@dharesign
Copy link
ContributorAuthor

@dharesign
Copy link
ContributorAuthor

I added a commit to addSetIsolate as a virtual method on thecppgc::Platform protocol. Not sure if that's the direction v8 will go to fix the issue, but it should help get us past that issue and check the rest of the CI passes.

@dharesign
Copy link
ContributorAuthor

Please re-approve running the workflows 😅

UlisesGascon pushed a commit that referenced this pull requestAug 18, 2023
This patch:- Initializes cppgc in InitializeOncePerProcess() when  kNoInitializeCppgc is not set- Create a CppHeap and attach it to the Isolate when  there isn't one already during IsolateData initialization.  The CppHeap is detached and terminated when IsolateData  is freed.- Publishes the cppgc headers in the tarball.This allows C++ addons to start using cppgc to manage objects.A helper node::SetCppgcReference() is also added to help addonsenable cppgc tracing in a user-defined object.Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>Refs:#40786PR-URL:#45704Backport-PR-URL:#49187Refs:https://docs.google.com/document/d/1ny2Qz_EsUnXGKJRGxoA-FXIE2xpLgaMAN6jD7eAkqFQ/editReviewed-By: Stephen Belanger <admin@stephenbelanger.com>Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>PR-URL:#48660Refs:v8/v8@9327503
UlisesGascon added a commit that referenced this pull requestAug 22, 2023
deps:  * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc:  * add new TSC members (Michael Dawson)#48841  * add rluvaton to collaborators (Raz Luvaton)#49215esm:  * unflag import.meta.resolve (Guy Bedford)#49028  * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842  * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector:  * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module:  * implement `register` utility (João Lenon)#46826  * make CJS load from ESM loader (Antoine du Hamel)#47999src:  * add built-in `.env` file support (Yagiz Nizipli)#48890  * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
@UlisesGasconUlisesGascon mentioned this pull requestAug 22, 2023
UlisesGascon added a commit that referenced this pull requestAug 22, 2023
Notable changes:deps:  * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc:  * add new TSC members (Michael Dawson)#48841  * add rluvaton to collaborators (Raz Luvaton)#49215esm:  * unflag import.meta.resolve (Guy Bedford)#49028  * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842  * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector:  * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module:  * implement `register` utility (João Lenon)#46826  * make CJS load from ESM loader (Antoine du Hamel)#47999src:  * add built-in `.env` file support (Yagiz Nizipli)#48890  * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
UlisesGascon added a commit that referenced this pull requestAug 22, 2023
Notable changes:deps:  * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc:  * add new TSC members (Michael Dawson)#48841  * add rluvaton to collaborators (Raz Luvaton)#49215esm:  * unflag import.meta.resolve (Guy Bedford)#49028  * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842  * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector:  * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module:  * implement `register` utility (João Lenon)#46826  * make CJS load from ESM loader (Antoine du Hamel)#47999src:  * add built-in `.env` file support (Yagiz Nizipli)#48890  * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
UlisesGascon added a commit that referenced this pull requestAug 22, 2023
Notable changes:deps:  * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc:  * add new TSC members (Michael Dawson)#48841  * add rluvaton to collaborators (Raz Luvaton)#49215esm:  * unflag import.meta.resolve (Guy Bedford)#49028  * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842  * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector:  * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module:  * implement `register` utility (João Lenon)#46826  * make CJS load from ESM loader (Antoine du Hamel)#47999src:  * add built-in `.env` file support (Yagiz Nizipli)#48890  * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
UlisesGascon added a commit that referenced this pull requestAug 22, 2023
Notable changes:deps:  * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc:  * add new TSC members (Michael Dawson)#48841  * add rluvaton to collaborators (Raz Luvaton)#49215esm:  * unflag import.meta.resolve (Guy Bedford)#49028  * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842  * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector:  * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module:  * implement `register` utility (João Lenon)#46826  * make CJS load from ESM loader (Antoine du Hamel)#47999src:  * add built-in `.env` file support (Yagiz Nizipli)#48890  * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
UlisesGascon added a commit that referenced this pull requestAug 22, 2023
Notable changes:deps:  * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc:  * add new TSC members (Michael Dawson)#48841  * add rluvaton to collaborators (Raz Luvaton)#49215esm:  * unflag import.meta.resolve (Guy Bedford)#49028  * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842  * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector:  * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module:  * implement `register` utility (João Lenon)#46826  * make CJS load from ESM loader (Antoine du Hamel)#47999src:  * add built-in `.env` file support (Yagiz Nizipli)#48890  * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
UlisesGascon added a commit that referenced this pull requestAug 24, 2023
Notable changes:deps:  * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc:  * add new TSC members (Michael Dawson)#48841  * add rluvaton to collaborators (Raz Luvaton)#49215esm:  * unflag import.meta.resolve (Guy Bedford)#49028  * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842  * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector:  * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module:  * implement `register` utility (João Lenon)#46826  * make CJS load from ESM loader (Antoine du Hamel)#47999src:  * add built-in `.env` file support (Yagiz Nizipli)#48890  * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
UlisesGascon added a commit that referenced this pull requestAug 29, 2023
Notable changes:deps:  * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc:  * add new TSC members (Michael Dawson)#48841  * add rluvaton to collaborators (Raz Luvaton)#49215esm:  * unflag import.meta.resolve (Guy Bedford)#49028  * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842  * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector:  * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module:  * implement `register` utility (João Lenon)#46826  * make CJS load from ESM loader (Antoine du Hamel)#47999src:  * add built-in `.env` file support (Yagiz Nizipli)#48890  * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
UlisesGascon added a commit that referenced this pull requestAug 31, 2023
Notable changes:deps:  * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc:  * add new TSC members (Michael Dawson)#48841  * add rluvaton to collaborators (Raz Luvaton)#49215esm:  * unflag import.meta.resolve (Guy Bedford)#49028  * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842  * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector:  * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module:  * implement `register` utility (João Lenon)#46826  * make CJS load from ESM loader (Antoine du Hamel)#47999src:  * add built-in `.env` file support (Yagiz Nizipli)#48890  * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
UlisesGascon added a commit that referenced this pull requestSep 1, 2023
Notable changes:deps:  * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc:  * add new TSC members (Michael Dawson)#48841  * add rluvaton to collaborators (Raz Luvaton)#49215esm:  * unflag import.meta.resolve (Guy Bedford)#49028  * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842  * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector:  * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module:  * implement `register` utility (João Lenon)#46826  * make CJS load from ESM loader (Antoine du Hamel)#47999src:  * add built-in `.env` file support (Yagiz Nizipli)#48890  * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
juanarbol pushed a commit that referenced this pull requestSep 4, 2023
Notable changes:deps:  * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc:  * add new TSC members (Michael Dawson)#48841  * add rluvaton to collaborators (Raz Luvaton)#49215esm:  * unflag import.meta.resolve (Guy Bedford)#49028  * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842  * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector:  * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module:  * implement `register` utility (João Lenon)#46826  * make CJS load from ESM loader (Antoine du Hamel)#47999src:  * add built-in `.env` file support (Yagiz Nizipli)#48890  * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
alexfernandez pushed a commit to alexfernandez/node that referenced this pull requestNov 1, 2023
Notable changes:deps:  * V8: cherry-pick 93275031284c (Joyee Cheung)nodejs#48660doc:  * add new TSC members (Michael Dawson)nodejs#48841  * add rluvaton to collaborators (Raz Luvaton)nodejs#49215esm:  * unflag import.meta.resolve (Guy Bedford)nodejs#49028  * add `initialize` hook, integrate with `register` (Izaak Schroeder)nodejs#48842  * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)nodejs#48559inspector:  * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)nodejs#48765module:  * implement `register` utility (João Lenon)nodejs#46826  * make CJS load from ESM loader (Antoine du Hamel)nodejs#47999src:  * add built-in `.env` file support (Yagiz Nizipli)nodejs#48890  * initialize cppgc (Daryl Haresign and Joyee Cheung)nodejs#48660 andnodejs#45704test_runner:  * (SEMVER-MINOR) expose location of tests (Colin Ihrig)nodejs#48975PR-URL:nodejs#49185
codebytere added a commit to electron/electron that referenced this pull requestNov 2, 2023
@targostargos added backported-to-v20.xPRs backported to the v20.x-staging branch. and removed backport-requested-v20.xPRs awaiting manual backport to the v20.x-staging branch. labelsNov 11, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 14, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 15, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 16, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 21, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 22, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 28, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 29, 2023
jkleinsc pushed a commit to electron/electron that referenced this pull requestNov 30, 2023
* chore: upgrade to Node.js v20* src: allow embedders to override NODE_MODULE_VERSIONnodejs/node#49279* src: fix missing trailing ,nodejs/node#46909* src,tools: initialize cppgcnodejs/node#45704* tools: allow passing absolute path of config.gypi in js2cnodejs/node#49162* tools: port js2c.py to C++nodejs/node#46997* doc,lib: disambiguate the old term, NativeModulenodejs/node#45673* chore: fixup Node.js BSSL tests*nodejs/node#49492*nodejs/node#44498* deps: upgrade to libuv 1.45.0nodejs/node#48078* deps: update V8 to 10.7nodejs/node#44741* test: use gcUntil() in test-v8-serialize-leaknodejs/node#49168* module: make CJS load from ESM loadernodejs/node#47999* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* chore: address changes to CJS/ESM loading* module: make CJS load from ESM loader (nodejs/node#47999)* lib: improve esm resolve performance (nodejs/node#46652)* bootstrap: optimize modules loaded in the built-in snapshotnodejs/node#45849* test: mark test-runner-output as flakynodejs/node#49854* lib: lazy-load deps in modules/run_main.jsnodejs/node#45849* url: use private properties for brand checknodejs/node#46904* test: refactor `test-node-output-errors`nodejs/node#48992* assert: deprecate callTrackernodejs/node#47740* src: cast v8::Object::GetInternalField() return value to v8::Valuenodejs/node#48943* test: adapt test-v8-stats for V8 updatenodejs/node#45230* tls: ensure TLS Sockets are closed if the underlying wrapclosesnodejs/node#49327* test: deflake test-tls-socket-closenodejs/node#49575* net: fix crash due to simultaneous close/shutdown on JS Stream Socketsnodejs/node#49400* net: use asserts in JS Socket Stream to catch races in futurenodejs/node#49400* lib: fix BroadcastChannel initialization locationnodejs/node#46864* src: create BaseObject with node::Realmnodejs/node#44348* src: implement DataQueue and non-memory resident Blobnodejs/node#45258* sea: add support for V8 bytecode-only cachingnodejs/node#48191* chore: fixup patch indices* gyp: put filenames in variablesnodejs/node#46965* build: modify js2c.py into GN executable* fix: (WIP) handle string replacement of fs -> original-fs* [v20.x] backport vm-related memoryfixesnodejs/node#49874* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* src: avoid copying string in fs_permissionnodejs/node#47746* look upon my works ye mightyand dispair* chore: patch cleanup* [api] Remove AllCan Read/Writehttps://chromium-review.googlesource.com/c/v8/v8/+/5006387* fix: missing include for NODE_EXTERN* chore: fixup patch indices* fix: fail properly when js2c fails in Node.js* build: fix js2c root_gen_dir* fix: lib/fs.js -> lib/original-fs.js* build: fix original-fs file xforms* fixup! module: make CJS load from ESM loader* build: get rid of CppHeap for now* build: add patch to prevent extra fs lookup on esm load* build: greatly simplify js2c modificationsMoves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c* chore: update to handle moved internal/modules/helpers file* test: update @types/node test* feat: enable preventing cppgc heap creation* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler* fix: no cppgc initialization in the renderer* gyp: put filenames in variablesnodejs/node#46965* test: disable single executable tests* fix: nan tests failing on node headers missing file* tls,http2: send fatal alert on ALPN mismatchnodejs/node#44031* test: disable snapshot tests*nodejs/node#47887*nodejs/node#49684*nodejs/node#44193* build: use deps/v8 for v8/toolsNode.js hard depends on these in their builtins* test: fix edge snapshot stack tracesnodejs/node#49659* build: remove js2c //base dep* build: use electron_js2c_toolchain to build node_js2c* fix: don't create SafeSet outside packageResolveFixes failure in parallel/test-require-delete-array-iterator:=== release test-require-delete-array-iterator ===Path: parallel/test-require-delete-array-iteratornode:internal/per_context/primordials:426    constructor(i) { super(i); } // eslint-disable-line no-useless-constructor                     ^TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator))    at new Set (<anonymous>)    at new SafeSet (node:internal/per_context/primordials:426:22)* fix: failing crashReporter tests on LinuxThese were failing because our change from node::InitializeNodeWithArgs tonode::InitializeOncePerProcess meant that we now inadvertently calledPlatformInit, which reset signal handling. This meant that our intentionalcrash function ElectronBindings::Crash no longer worked and the renderer processno longer crashed when process.crash() was called. We don't want to use Node.js'default signal handling in the renderer process, so we disable it by passingkNoDefaultSignalHandling to node::InitializeOncePerProcess.* build: only create cppgc heap on non-32 bit platforms* chore: clean up util:CompileAndCall* src: fix compatility with upcoming V8 12.1 APIsnodejs/node#50709* fix: use thread_local BuiltinLoader* chore: fixup v8 patch indices---------Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull requestDec 11, 2023
* chore: upgrade to Node.js v20* src: allow embedders to override NODE_MODULE_VERSIONnodejs/node#49279* src: fix missing trailing ,nodejs/node#46909* src,tools: initialize cppgcnodejs/node#45704* tools: allow passing absolute path of config.gypi in js2cnodejs/node#49162* tools: port js2c.py to C++nodejs/node#46997* doc,lib: disambiguate the old term, NativeModulenodejs/node#45673* chore: fixup Node.js BSSL tests*nodejs/node#49492*nodejs/node#44498* deps: upgrade to libuv 1.45.0nodejs/node#48078* deps: update V8 to 10.7nodejs/node#44741* test: use gcUntil() in test-v8-serialize-leaknodejs/node#49168* module: make CJS load from ESM loadernodejs/node#47999* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* chore: address changes to CJS/ESM loading* module: make CJS load from ESM loader (nodejs/node#47999)* lib: improve esm resolve performance (nodejs/node#46652)* bootstrap: optimize modules loaded in the built-in snapshotnodejs/node#45849* test: mark test-runner-output as flakynodejs/node#49854* lib: lazy-load deps in modules/run_main.jsnodejs/node#45849* url: use private properties for brand checknodejs/node#46904* test: refactor `test-node-output-errors`nodejs/node#48992* assert: deprecate callTrackernodejs/node#47740* src: cast v8::Object::GetInternalField() return value to v8::Valuenodejs/node#48943* test: adapt test-v8-stats for V8 updatenodejs/node#45230* tls: ensure TLS Sockets are closed if the underlying wrapclosesnodejs/node#49327* test: deflake test-tls-socket-closenodejs/node#49575* net: fix crash due to simultaneous close/shutdown on JS Stream Socketsnodejs/node#49400* net: use asserts in JS Socket Stream to catch races in futurenodejs/node#49400* lib: fix BroadcastChannel initialization locationnodejs/node#46864* src: create BaseObject with node::Realmnodejs/node#44348* src: implement DataQueue and non-memory resident Blobnodejs/node#45258* sea: add support for V8 bytecode-only cachingnodejs/node#48191* chore: fixup patch indices* gyp: put filenames in variablesnodejs/node#46965* build: modify js2c.py into GN executable* fix: (WIP) handle string replacement of fs -> original-fs* [v20.x] backport vm-related memoryfixesnodejs/node#49874* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* src: avoid copying string in fs_permissionnodejs/node#47746* look upon my works ye mightyand dispair* chore: patch cleanup* [api] Remove AllCan Read/Writehttps://chromium-review.googlesource.com/c/v8/v8/+/5006387* fix: missing include for NODE_EXTERN* chore: fixup patch indices* fix: fail properly when js2c fails in Node.js* build: fix js2c root_gen_dir* fix: lib/fs.js -> lib/original-fs.js* build: fix original-fs file xforms* fixup! module: make CJS load from ESM loader* build: get rid of CppHeap for now* build: add patch to prevent extra fs lookup on esm load* build: greatly simplify js2c modificationsMoves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c* chore: update to handle moved internal/modules/helpers file* test: update @types/node test* feat: enable preventing cppgc heap creation* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler* fix: no cppgc initialization in the renderer* gyp: put filenames in variablesnodejs/node#46965* test: disable single executable tests* fix: nan tests failing on node headers missing file* tls,http2: send fatal alert on ALPN mismatchnodejs/node#44031* test: disable snapshot tests*nodejs/node#47887*nodejs/node#49684*nodejs/node#44193* build: use deps/v8 for v8/toolsNode.js hard depends on these in their builtins* test: fix edge snapshot stack tracesnodejs/node#49659* build: remove js2c //base dep* build: use electron_js2c_toolchain to build node_js2c* fix: don't create SafeSet outside packageResolveFixes failure in parallel/test-require-delete-array-iterator:=== release test-require-delete-array-iterator ===Path: parallel/test-require-delete-array-iteratornode:internal/per_context/primordials:426    constructor(i) { super(i); } // eslint-disable-line no-useless-constructor                     ^TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator))    at new Set (<anonymous>)    at new SafeSet (node:internal/per_context/primordials:426:22)* fix: failing crashReporter tests on LinuxThese were failing because our change from node::InitializeNodeWithArgs tonode::InitializeOncePerProcess meant that we now inadvertently calledPlatformInit, which reset signal handling. This meant that our intentionalcrash function ElectronBindings::Crash no longer worked and the renderer processno longer crashed when process.crash() was called. We don't want to use Node.js'default signal handling in the renderer process, so we disable it by passingkNoDefaultSignalHandling to node::InitializeOncePerProcess.* build: only create cppgc heap on non-32 bit platforms* chore: clean up util:CompileAndCall* src: fix compatility with upcoming V8 12.1 APIsnodejs/node#50709* fix: use thread_local BuiltinLoader* chore: fixup v8 patch indices---------Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
minglechen pushed a commit to CTSRD-CHERI/node that referenced this pull requestDec 11, 2024
Original commit message:    [cppgc] expose wrapper descriptor on CppHeap    This makes it possible for embedders to:    1. Avoid creating wrapper objects that happen to have a layout that      leads V8 to consider the object cppgc-managed while it's not.      Refs:nodejs#43521    2. Create cppgc-managed wrapper objects when they do not own the       CppHeap. Refs:nodejs#45704    Bug: v8:13960    Change-Id: If31f4d56c5ead59dc0d56f937494d23d631f7438    Reviewed-on:https://chromium-review.googlesource.com/c/v8/v8/+/4598833    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>    Cr-Commit-Position: refs/heads/main@{#88490}Refs:v8/v8@9327503PR-URL:nodejs#48660Backport-PR-URL:nodejs#49187Reviewed-By: Chengzhong Wu <legendecas@gmail.com>Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Refs:nodejs#40786Refs:https://docs.google.com/document/d/1ny2Qz_EsUnXGKJRGxoA-FXIE2xpLgaMAN6jD7eAkqFQ/edit
@glaubitz
Copy link

glaubitz commentedMay 17, 2025
edited
Loading

This change broke NodeJS on big-endian ppc64 on Linux for me. (see:#58277)

@joyeecheung
Copy link
Member

joyeecheung commentedMay 18, 2025
edited
Loading

I don't think V8 tests for ppc64be on their CI, nor does Node.js support ppc64be + Linux, from the stack trace it looks like a V8 support issue and the fix probably won't be in Node.js.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jasnelljasnelljasnell left review comments

@addaleaxaddaleaxaddaleax left review comments

@targostargostargos left review comments

@joyeecheungjoyeecheungjoyeecheung left review comments

@QardQardQard approved these changes

@RafaelGSSRafaelGSSRafaelGSS approved these changes

Assignees
No one assigned
Labels
backported-to-v20.xPRs backported to the v20.x-staging branch.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

11 participants
@dharesign@nodejs-github-bot@nornagon@joyeecheung@UlisesGascon@glaubitz@Qard@jasnell@addaleax@targos@RafaelGSS

[8]ページ先頭

©2009-2025 Movatter.jp