Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
src,tools: initialize cppgc#45704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Review requested:
|
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
3860b21
to97c248b
CompareIn Electron, the cppgc heap will be initialized by Chromium. I don't think anything in this PR clashes with what Electron will want. When they initialize node, they can use They don't use CC:@codebytere /@nornagon for awareness |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
FYI I believe we don't currently initialize cppgc in the main process in Electron (though Blink does of course initialize it). So we would want to be able to initialize Nodewith cppgc initialization in the main process (either by doing it ourselves or through this initialization option), andwithout cppgc initialization in the renderer process (since that would clash with Blink's initialization). |
Erp, I hit the close button by mistake. Please re-approve running the workflows >_< |
97c248b
toa4f84b2
CompareThe previous test runs seemed to fail, and actually running my local build of node likewise fails. It seems to be due to a bug in v8: https://github.com/v8/v8/blob/main/src/heap/cppgc/heap-base.cc#L104 I believe this should be CC:@mlippautz |
Yep, changing that fixes my local build. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
a4f84b2
toa00a060
Compare
I added a second commit to this PR which fixes the above. We can switch the commit to cherry-pick the v8 commit once it gets fixed there. Hopefully the CI checks will proceed now. |
Node is still segfaulting when I run it locally:
It looks like |
Looks like there's no After digging a bit, it's because CC:@mlippautz |
Submitted the following v8 bugs: |
I added a commit to add |
Please re-approve running the workflows 😅 |
This patch:- Initializes cppgc in InitializeOncePerProcess() when kNoInitializeCppgc is not set- Create a CppHeap and attach it to the Isolate when there isn't one already during IsolateData initialization. The CppHeap is detached and terminated when IsolateData is freed.- Publishes the cppgc headers in the tarball.This allows C++ addons to start using cppgc to manage objects.A helper node::SetCppgcReference() is also added to help addonsenable cppgc tracing in a user-defined object.Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>Refs:#40786PR-URL:#45704Backport-PR-URL:#49187Refs:https://docs.google.com/document/d/1ny2Qz_EsUnXGKJRGxoA-FXIE2xpLgaMAN6jD7eAkqFQ/editReviewed-By: Stephen Belanger <admin@stephenbelanger.com>Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>PR-URL:#48660Refs:v8/v8@9327503
deps: * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc: * add new TSC members (Michael Dawson)#48841 * add rluvaton to collaborators (Raz Luvaton)#49215esm: * unflag import.meta.resolve (Guy Bedford)#49028 * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842 * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector: * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module: * implement `register` utility (João Lenon)#46826 * make CJS load from ESM loader (Antoine du Hamel)#47999src: * add built-in `.env` file support (Yagiz Nizipli)#48890 * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner: * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
Notable changes:deps: * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc: * add new TSC members (Michael Dawson)#48841 * add rluvaton to collaborators (Raz Luvaton)#49215esm: * unflag import.meta.resolve (Guy Bedford)#49028 * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842 * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector: * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module: * implement `register` utility (João Lenon)#46826 * make CJS load from ESM loader (Antoine du Hamel)#47999src: * add built-in `.env` file support (Yagiz Nizipli)#48890 * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner: * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
Notable changes:deps: * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc: * add new TSC members (Michael Dawson)#48841 * add rluvaton to collaborators (Raz Luvaton)#49215esm: * unflag import.meta.resolve (Guy Bedford)#49028 * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842 * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector: * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module: * implement `register` utility (João Lenon)#46826 * make CJS load from ESM loader (Antoine du Hamel)#47999src: * add built-in `.env` file support (Yagiz Nizipli)#48890 * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner: * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
Notable changes:deps: * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc: * add new TSC members (Michael Dawson)#48841 * add rluvaton to collaborators (Raz Luvaton)#49215esm: * unflag import.meta.resolve (Guy Bedford)#49028 * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842 * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector: * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module: * implement `register` utility (João Lenon)#46826 * make CJS load from ESM loader (Antoine du Hamel)#47999src: * add built-in `.env` file support (Yagiz Nizipli)#48890 * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner: * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
Notable changes:deps: * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc: * add new TSC members (Michael Dawson)#48841 * add rluvaton to collaborators (Raz Luvaton)#49215esm: * unflag import.meta.resolve (Guy Bedford)#49028 * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842 * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector: * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module: * implement `register` utility (João Lenon)#46826 * make CJS load from ESM loader (Antoine du Hamel)#47999src: * add built-in `.env` file support (Yagiz Nizipli)#48890 * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner: * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
Notable changes:deps: * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc: * add new TSC members (Michael Dawson)#48841 * add rluvaton to collaborators (Raz Luvaton)#49215esm: * unflag import.meta.resolve (Guy Bedford)#49028 * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842 * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector: * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module: * implement `register` utility (João Lenon)#46826 * make CJS load from ESM loader (Antoine du Hamel)#47999src: * add built-in `.env` file support (Yagiz Nizipli)#48890 * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner: * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
Notable changes:deps: * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc: * add new TSC members (Michael Dawson)#48841 * add rluvaton to collaborators (Raz Luvaton)#49215esm: * unflag import.meta.resolve (Guy Bedford)#49028 * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842 * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector: * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module: * implement `register` utility (João Lenon)#46826 * make CJS load from ESM loader (Antoine du Hamel)#47999src: * add built-in `.env` file support (Yagiz Nizipli)#48890 * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner: * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
Notable changes:deps: * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc: * add new TSC members (Michael Dawson)#48841 * add rluvaton to collaborators (Raz Luvaton)#49215esm: * unflag import.meta.resolve (Guy Bedford)#49028 * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842 * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector: * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module: * implement `register` utility (João Lenon)#46826 * make CJS load from ESM loader (Antoine du Hamel)#47999src: * add built-in `.env` file support (Yagiz Nizipli)#48890 * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner: * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
Notable changes:deps: * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc: * add new TSC members (Michael Dawson)#48841 * add rluvaton to collaborators (Raz Luvaton)#49215esm: * unflag import.meta.resolve (Guy Bedford)#49028 * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842 * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector: * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module: * implement `register` utility (João Lenon)#46826 * make CJS load from ESM loader (Antoine du Hamel)#47999src: * add built-in `.env` file support (Yagiz Nizipli)#48890 * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner: * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
Notable changes:deps: * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc: * add new TSC members (Michael Dawson)#48841 * add rluvaton to collaborators (Raz Luvaton)#49215esm: * unflag import.meta.resolve (Guy Bedford)#49028 * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842 * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector: * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module: * implement `register` utility (João Lenon)#46826 * make CJS load from ESM loader (Antoine du Hamel)#47999src: * add built-in `.env` file support (Yagiz Nizipli)#48890 * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner: * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
Notable changes:deps: * V8: cherry-pick 93275031284c (Joyee Cheung)#48660doc: * add new TSC members (Michael Dawson)#48841 * add rluvaton to collaborators (Raz Luvaton)#49215esm: * unflag import.meta.resolve (Guy Bedford)#49028 * add `initialize` hook, integrate with `register` (Izaak Schroeder)#48842 * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)#48559inspector: * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)#48765module: * implement `register` utility (João Lenon)#46826 * make CJS load from ESM loader (Antoine du Hamel)#47999src: * add built-in `.env` file support (Yagiz Nizipli)#48890 * initialize cppgc (Daryl Haresign and Joyee Cheung)#48660 and#45704test_runner: * (SEMVER-MINOR) expose location of tests (Colin Ihrig)#48975PR-URL:#49185
Notable changes:deps: * V8: cherry-pick 93275031284c (Joyee Cheung)nodejs#48660doc: * add new TSC members (Michael Dawson)nodejs#48841 * add rluvaton to collaborators (Raz Luvaton)nodejs#49215esm: * unflag import.meta.resolve (Guy Bedford)nodejs#49028 * add `initialize` hook, integrate with `register` (Izaak Schroeder)nodejs#48842 * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder)nodejs#48559inspector: * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow)nodejs#48765module: * implement `register` utility (João Lenon)nodejs#46826 * make CJS load from ESM loader (Antoine du Hamel)nodejs#47999src: * add built-in `.env` file support (Yagiz Nizipli)nodejs#48890 * initialize cppgc (Daryl Haresign and Joyee Cheung)nodejs#48660 andnodejs#45704test_runner: * (SEMVER-MINOR) expose location of tests (Colin Ihrig)nodejs#48975PR-URL:nodejs#49185
* chore: upgrade to Node.js v20* src: allow embedders to override NODE_MODULE_VERSIONnodejs/node#49279* src: fix missing trailing ,nodejs/node#46909* src,tools: initialize cppgcnodejs/node#45704* tools: allow passing absolute path of config.gypi in js2cnodejs/node#49162* tools: port js2c.py to C++nodejs/node#46997* doc,lib: disambiguate the old term, NativeModulenodejs/node#45673* chore: fixup Node.js BSSL tests*nodejs/node#49492*nodejs/node#44498* deps: upgrade to libuv 1.45.0nodejs/node#48078* deps: update V8 to 10.7nodejs/node#44741* test: use gcUntil() in test-v8-serialize-leaknodejs/node#49168* module: make CJS load from ESM loadernodejs/node#47999* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* chore: address changes to CJS/ESM loading* module: make CJS load from ESM loader (nodejs/node#47999)* lib: improve esm resolve performance (nodejs/node#46652)* bootstrap: optimize modules loaded in the built-in snapshotnodejs/node#45849* test: mark test-runner-output as flakynodejs/node#49854* lib: lazy-load deps in modules/run_main.jsnodejs/node#45849* url: use private properties for brand checknodejs/node#46904* test: refactor `test-node-output-errors`nodejs/node#48992* assert: deprecate callTrackernodejs/node#47740* src: cast v8::Object::GetInternalField() return value to v8::Valuenodejs/node#48943* test: adapt test-v8-stats for V8 updatenodejs/node#45230* tls: ensure TLS Sockets are closed if the underlying wrapclosesnodejs/node#49327* test: deflake test-tls-socket-closenodejs/node#49575* net: fix crash due to simultaneous close/shutdown on JS Stream Socketsnodejs/node#49400* net: use asserts in JS Socket Stream to catch races in futurenodejs/node#49400* lib: fix BroadcastChannel initialization locationnodejs/node#46864* src: create BaseObject with node::Realmnodejs/node#44348* src: implement DataQueue and non-memory resident Blobnodejs/node#45258* sea: add support for V8 bytecode-only cachingnodejs/node#48191* chore: fixup patch indices* gyp: put filenames in variablesnodejs/node#46965* build: modify js2c.py into GN executable* fix: (WIP) handle string replacement of fs -> original-fs* [v20.x] backport vm-related memoryfixesnodejs/node#49874* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* src: avoid copying string in fs_permissionnodejs/node#47746* look upon my works ye mightyand dispair* chore: patch cleanup* [api] Remove AllCan Read/Writehttps://chromium-review.googlesource.com/c/v8/v8/+/5006387* fix: missing include for NODE_EXTERN* chore: fixup patch indices* fix: fail properly when js2c fails in Node.js* build: fix js2c root_gen_dir* fix: lib/fs.js -> lib/original-fs.js* build: fix original-fs file xforms* fixup! module: make CJS load from ESM loader* build: get rid of CppHeap for now* build: add patch to prevent extra fs lookup on esm load* build: greatly simplify js2c modificationsMoves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c* chore: update to handle moved internal/modules/helpers file* test: update @types/node test* feat: enable preventing cppgc heap creation* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler* fix: no cppgc initialization in the renderer* gyp: put filenames in variablesnodejs/node#46965* test: disable single executable tests* fix: nan tests failing on node headers missing file* tls,http2: send fatal alert on ALPN mismatchnodejs/node#44031* test: disable snapshot tests*nodejs/node#47887*nodejs/node#49684*nodejs/node#44193* build: use deps/v8 for v8/toolsNode.js hard depends on these in their builtins* test: fix edge snapshot stack tracesnodejs/node#49659* build: remove js2c //base dep* build: use electron_js2c_toolchain to build node_js2c* fix: don't create SafeSet outside packageResolveFixes failure in parallel/test-require-delete-array-iterator:=== release test-require-delete-array-iterator ===Path: parallel/test-require-delete-array-iteratornode:internal/per_context/primordials:426 constructor(i) { super(i); } // eslint-disable-line no-useless-constructor ^TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator)) at new Set (<anonymous>) at new SafeSet (node:internal/per_context/primordials:426:22)* fix: failing crashReporter tests on LinuxThese were failing because our change from node::InitializeNodeWithArgs tonode::InitializeOncePerProcess meant that we now inadvertently calledPlatformInit, which reset signal handling. This meant that our intentionalcrash function ElectronBindings::Crash no longer worked and the renderer processno longer crashed when process.crash() was called. We don't want to use Node.js'default signal handling in the renderer process, so we disable it by passingkNoDefaultSignalHandling to node::InitializeOncePerProcess.* build: only create cppgc heap on non-32 bit platforms* chore: clean up util:CompileAndCall* src: fix compatility with upcoming V8 12.1 APIsnodejs/node#50709* fix: use thread_local BuiltinLoader* chore: fixup v8 patch indices---------Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
* chore: upgrade to Node.js v20* src: allow embedders to override NODE_MODULE_VERSIONnodejs/node#49279* src: fix missing trailing ,nodejs/node#46909* src,tools: initialize cppgcnodejs/node#45704* tools: allow passing absolute path of config.gypi in js2cnodejs/node#49162* tools: port js2c.py to C++nodejs/node#46997* doc,lib: disambiguate the old term, NativeModulenodejs/node#45673* chore: fixup Node.js BSSL tests*nodejs/node#49492*nodejs/node#44498* deps: upgrade to libuv 1.45.0nodejs/node#48078* deps: update V8 to 10.7nodejs/node#44741* test: use gcUntil() in test-v8-serialize-leaknodejs/node#49168* module: make CJS load from ESM loadernodejs/node#47999* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* chore: address changes to CJS/ESM loading* module: make CJS load from ESM loader (nodejs/node#47999)* lib: improve esm resolve performance (nodejs/node#46652)* bootstrap: optimize modules loaded in the built-in snapshotnodejs/node#45849* test: mark test-runner-output as flakynodejs/node#49854* lib: lazy-load deps in modules/run_main.jsnodejs/node#45849* url: use private properties for brand checknodejs/node#46904* test: refactor `test-node-output-errors`nodejs/node#48992* assert: deprecate callTrackernodejs/node#47740* src: cast v8::Object::GetInternalField() return value to v8::Valuenodejs/node#48943* test: adapt test-v8-stats for V8 updatenodejs/node#45230* tls: ensure TLS Sockets are closed if the underlying wrapclosesnodejs/node#49327* test: deflake test-tls-socket-closenodejs/node#49575* net: fix crash due to simultaneous close/shutdown on JS Stream Socketsnodejs/node#49400* net: use asserts in JS Socket Stream to catch races in futurenodejs/node#49400* lib: fix BroadcastChannel initialization locationnodejs/node#46864* src: create BaseObject with node::Realmnodejs/node#44348* src: implement DataQueue and non-memory resident Blobnodejs/node#45258* sea: add support for V8 bytecode-only cachingnodejs/node#48191* chore: fixup patch indices* gyp: put filenames in variablesnodejs/node#46965* build: modify js2c.py into GN executable* fix: (WIP) handle string replacement of fs -> original-fs* [v20.x] backport vm-related memoryfixesnodejs/node#49874* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* src: avoid copying string in fs_permissionnodejs/node#47746* look upon my works ye mightyand dispair* chore: patch cleanup* [api] Remove AllCan Read/Writehttps://chromium-review.googlesource.com/c/v8/v8/+/5006387* fix: missing include for NODE_EXTERN* chore: fixup patch indices* fix: fail properly when js2c fails in Node.js* build: fix js2c root_gen_dir* fix: lib/fs.js -> lib/original-fs.js* build: fix original-fs file xforms* fixup! module: make CJS load from ESM loader* build: get rid of CppHeap for now* build: add patch to prevent extra fs lookup on esm load* build: greatly simplify js2c modificationsMoves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c* chore: update to handle moved internal/modules/helpers file* test: update @types/node test* feat: enable preventing cppgc heap creation* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler* fix: no cppgc initialization in the renderer* gyp: put filenames in variablesnodejs/node#46965* test: disable single executable tests* fix: nan tests failing on node headers missing file* tls,http2: send fatal alert on ALPN mismatchnodejs/node#44031* test: disable snapshot tests*nodejs/node#47887*nodejs/node#49684*nodejs/node#44193* build: use deps/v8 for v8/toolsNode.js hard depends on these in their builtins* test: fix edge snapshot stack tracesnodejs/node#49659* build: remove js2c //base dep* build: use electron_js2c_toolchain to build node_js2c* fix: don't create SafeSet outside packageResolveFixes failure in parallel/test-require-delete-array-iterator:=== release test-require-delete-array-iterator ===Path: parallel/test-require-delete-array-iteratornode:internal/per_context/primordials:426 constructor(i) { super(i); } // eslint-disable-line no-useless-constructor ^TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator)) at new Set (<anonymous>) at new SafeSet (node:internal/per_context/primordials:426:22)* fix: failing crashReporter tests on LinuxThese were failing because our change from node::InitializeNodeWithArgs tonode::InitializeOncePerProcess meant that we now inadvertently calledPlatformInit, which reset signal handling. This meant that our intentionalcrash function ElectronBindings::Crash no longer worked and the renderer processno longer crashed when process.crash() was called. We don't want to use Node.js'default signal handling in the renderer process, so we disable it by passingkNoDefaultSignalHandling to node::InitializeOncePerProcess.* build: only create cppgc heap on non-32 bit platforms* chore: clean up util:CompileAndCall* src: fix compatility with upcoming V8 12.1 APIsnodejs/node#50709* fix: use thread_local BuiltinLoader* chore: fixup v8 patch indices---------Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
Original commit message: [cppgc] expose wrapper descriptor on CppHeap This makes it possible for embedders to: 1. Avoid creating wrapper objects that happen to have a layout that leads V8 to consider the object cppgc-managed while it's not. Refs:nodejs#43521 2. Create cppgc-managed wrapper objects when they do not own the CppHeap. Refs:nodejs#45704 Bug: v8:13960 Change-Id: If31f4d56c5ead59dc0d56f937494d23d631f7438 Reviewed-on:https://chromium-review.googlesource.com/c/v8/v8/+/4598833 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#88490}Refs:v8/v8@9327503PR-URL:nodejs#48660Backport-PR-URL:nodejs#49187Reviewed-By: Chengzhong Wu <legendecas@gmail.com>Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Refs:nodejs#40786Refs:https://docs.google.com/document/d/1ny2Qz_EsUnXGKJRGxoA-FXIE2xpLgaMAN6jD7eAkqFQ/edit
glaubitz commentedMay 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This change broke NodeJS on big-endian ppc64 on Linux for me. (see:#58277) |
joyeecheung commentedMay 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I don't think V8 tests for ppc64be on their CI, nor does Node.js support ppc64be + Linux, from the stack trace it looks like a V8 support issue and the fix probably won't be in Node.js. |
Uh oh!
There was an error while loading.Please reload this page.
This patch:
kNoInitializeCppgc is not set
there isn't one already during IsolateData initialization.
The CppHeap is detached and terminated when IsolateData
is freed.
This allows C++ addons to start using cppgc to manage objects.
A helper node::SetCppgcReference() is also added to help addons
enable cppgc tracing in a user-defined object.
Refs:#40786
Refs:https://docs.google.com/document/d/1ny2Qz_EsUnXGKJRGxoA-FXIE2xpLgaMAN6jD7eAkqFQ/edit