Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

deps: update V8 to 10.8#45230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
targos wants to merge11 commits intonodejs:mainfromtargos:v8-108
Closed

deps: update V8 to 10.8#45230

targos wants to merge11 commits intonodejs:mainfromtargos:v8-108

Conversation

targos
Copy link
Member

@targostargos commentedOct 29, 2022
edited
Loading

Stable Release:
Tue, Nov 29, 2022

bricss and dnalborczyk reacted with thumbs up emojibricss, Xstoudi, and dnalborczyk reacted with hooray emojibricss, tniessen, and dnalborczyk reacted with heart emojibricss and dnalborczyk reacted with rocket emoji
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-botnodejs-github-bot added buildIssues and PRs related to build files or the CI. needs-ciPRs that need a full CI run. v8 engineIssues and PRs related to the V8 dependency. labelsOct 29, 2022
@targostargos added dont-land-on-v14.x request-ciAdd this label to start a Jenkins CI on a PR. labelsOct 29, 2022
@github-actionsgithub-actionsbot removed the request-ciAdd this label to start a Jenkins CI on a PR. labelOct 29, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@targos

This comment was marked as resolved.

@targos
Copy link
MemberAuthor

There's also a failure withtest-trace-gc-flag

12:10:45 not ok 1 v8-updates/test-trace-gc-flag12:10:45   ---12:10:45   duration_ms: 0.34812:10:45   severity: fail12:10:45   exitcode: 112:10:45   stack: |-12:10:45     node:assert:102712:10:45         throw err;12:10:45         ^12:10:45     12:10:45     AssertionError [ERR_ASSERTION]: The input did not match the regular expression /\bMark-sweep\b/. Input:12:10:45     12:10:45     '[41903:0x55803f320350]       93 ms: Mark-Compact 11.8 (18.1) -> 4.3 (14.1) MB, 4.3 / 0.0 ms  (average mu = 1.000, current mu = 1.000) testing; GC in old space requested'12:10:45     12:10:45         at /home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-trace-gc-flag.js:30:1212:10:45         at Array.forEach (<anonymous>)12:10:45         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-trace-gc-flag.js:29:9)12:10:45         at Module._compile (node:internal/modules/cjs/loader:1175:14)12:10:45         at Module._extensions..js (node:internal/modules/cjs/loader:1229:10)12:10:45         at Module.load (node:internal/modules/cjs/loader:1038:32)12:10:45         at Module._load (node:internal/modules/cjs/loader:879:12)12:10:45         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:82:12)12:10:45         at node:internal/main/run_main_module:23:47 {12:10:45       generatedMessage: true,12:10:45       code: 'ERR_ASSERTION',12:10:45       actual: '[41903:0x55803f320350]       93 ms: Mark-Compact 11.8 (18.1) -> 4.3 (14.1) MB, 4.3 / 0.0 ms  (average mu = 1.000, current mu = 1.000) testing; GC in old space requested',12:10:45       expected: /\bMark-sweep\b/,12:10:45       operator: 'match'12:10:45     }12:10:45     12:10:45     Node.js v20.0.0-pre12:10:45   ...

/cc@tony-go

@targos
Copy link
MemberAuthor

targos commentedOct 31, 2022
edited
Loading

@nodejs/platform-windows

x86 build fails on Windows:

12:15:17 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(344,35): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]12:15:17 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(345,28): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]12:15:17 C:\workspace\node-compile-windows\node\deps\v8\src\heap\large-spaces.h(59,33): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]

@StefanStojanovic
Copy link
Contributor

Hello,@targos. All failing asserts are manifestations of the same issue -MemoryChunkLayout::kMemoryChunkHeaderSize not being set to the correct value. I've foundthis commit in the v8 repo that fixes the problem. I've tried it locally and the build passes.

targos reacted with thumbs up emoji

@targos
Copy link
MemberAuthor

@StefanStojanovic thanks! I'll cherry-pick that commit

StefanStojanovic reacted with thumbs up emoji

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull requestNov 23, 2022
Refs:https://bugs.chromium.org/p/v8/issues/detail?id=12661Refs:nodejs#42375PR-URL:nodejs#42657Reviewed-By: Darshan Sen <raisinten@gmail.com>Reviewed-By: Richard Lau <rlau@redhat.com>Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Reviewed-By: Michael Dawson <midawson@redhat.com>PR-URL:nodejs#45230Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull requestNov 23, 2022
PR-URL:nodejs#44741Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Reviewed-By: James M Snell <jasnell@gmail.com>PR-URL:nodejs#45230Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull requestNov 23, 2022
PR-URL:nodejs#44741Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Reviewed-By: James M Snell <jasnell@gmail.com>PR-URL:nodejs#45230Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull requestNov 23, 2022
Original commit message:    [heap] Fix 32bit msvc builds    Size of ActiveSystemPages is 8 bytes even on 32bit builds, thus    forcing 8 bytes alignment for MemoryChunk.    Change-Id: I5ca1e18329d6e68a8b6811c3c27cb224c765cb63    Reviewed-on:https://chromium-review.googlesource.com/c/v8/v8/+/3966953    Commit-Queue: Omer Katz <omerkatz@chromium.org>    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>    Cr-Commit-Position: refs/heads/main@{#83845}Refs:v8/v8@92a7385PR-URL:nodejs#45230Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull requestNov 23, 2022
Original commit message:    [base] Fix SmartOS build    That platform doesn't have `malloc_usable_size`.    Refs:nodejs/node-v8#239    Change-Id: I011dd8449d02b27219a32cba00132cd068069f50    Reviewed-on:https://chromium-review.googlesource.com/c/v8/v8/+/4026402    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>    Commit-Queue: Michaël Zasso <mic.besace@gmail.com>    Cr-Commit-Position: refs/heads/main@{#84256}Refs:v8/v8@f1c888ePR-URL:nodejs#45230Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull requestNov 23, 2022
Original commit message:    Add an `v8::ArrayBuffer::WasDetached` method to the C++ API    V8's C++ API does not give a way to tell whether an ArrayBuffer has    been detached from the `v8::ArrayBuffer` class. In fact, as far as can    be told from the C++ API without running JS code, detached    ArrayBuffers behave the same as zero-sized ArrayBuffers and there is    no way to observe the difference. However, this difference can be    observed in JS because constructing a TypedArray from a detached    ArrayBuffer will throw.    This change adds a `WasDetached` method to the `v8::ArrayBuffer` class    to give embedders access to this information without having to run JS    code.    Bug: v8:13159    Change-Id: I2bb1e380cee1cecd31f6d48ec3d9f28c03a8a673    Reviewed-on:https://chromium-review.googlesource.com/c/v8/v8/+/3810345    Commit-Queue: Toon Verwaest <verwaest@chromium.org>    Reviewed-by: Toon Verwaest <verwaest@chromium.org>    Cr-Commit-Position: refs/heads/main@{#83963}Refs:v8/v8@9df5ef7PR-URL:nodejs#45474Reviewed-By: Michaël Zasso <targos@protonmail.com>Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>Reviewed-By: Luigi Pinca <luigipinca@gmail.com>Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>Reviewed-By: Rich Trott <rtrott@gmail.com>Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Reviewed-By: James M Snell <jasnell@gmail.com>PR-URL:nodejs#45230Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull requestNov 23, 2022
PR-URL:nodejs#45230Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull requestNov 23, 2022
PR-URL:nodejs#45230Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno added a commit that referenced this pull requestNov 24, 2022
Notable changes:buffer:  * (SEMVER-MINOR) introduce File (Khafra)#45139deps:  * update V8 to 10.8.168.20 (Michaël Zasso)#45230doc:  * deprecate use of invalid ports in `url.parse` (Antoine du Hamel)#45576util:  * add fast path for utf8 encoding (Yagiz Nizipli)#45412PR-URL: TBD
@ruyadornoruyadorno mentioned this pull requestNov 24, 2022
ruyadorno added a commit that referenced this pull requestNov 24, 2022
Notable changes:buffer:  * (SEMVER-MINOR) introduce File (Khafra)#45139deps:  * update V8 to 10.8.168.20 (Michaël Zasso)#45230doc:  * deprecate use of invalid ports in `url.parse` (Antoine du Hamel)#45576util:  * add fast path for utf8 encoding (Yagiz Nizipli)#45412PR-URL:#45615
ruyadorno added a commit that referenced this pull requestNov 25, 2022
Notable changes:buffer:  * (SEMVER-MINOR) introduce File (Khafra)#45139deps:  * update timezone to 2022f (Node.js GitHub Bot)#45289  * update V8 to 10.8.168.20 (Michaël Zasso)#45230doc:  * deprecate use of invalid ports in `url.parse` (Antoine du Hamel)#45576util:  * add fast path for utf8 encoding (Yagiz Nizipli)#45412PR-URL:#45615
ruyadorno added a commit that referenced this pull requestNov 25, 2022
Notable changes:buffer:  * (SEMVER-MINOR) introduce File (Khafra)#45139deps:  * update timezone to 2022f (Node.js GitHub Bot)#45289  * update V8 to 10.8.168.20 (Michaël Zasso)#45230doc:  * deprecate use of invalid ports in `url.parse` (Antoine du Hamel)#45576util:  * add fast path for utf8 encoding (Yagiz Nizipli)#45412PR-URL:#45615
anonrig pushed a commit to anonrig/node that referenced this pull requestNov 26, 2022
Original commit message:    [base] Fix SmartOS build    That platform doesn't have `malloc_usable_size`.    Refs:nodejs/node-v8#239    Change-Id: I011dd8449d02b27219a32cba00132cd068069f50    Reviewed-on:https://chromium-review.googlesource.com/c/v8/v8/+/4026402    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>    Commit-Queue: Michaël Zasso <mic.besace@gmail.com>    Cr-Commit-Position: refs/heads/main@{#84256}Refs:v8/v8@f1c888ePR-URL:nodejs#45230Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com># Conflicts:#common.gypi
nodejs-github-bot pushed a commit that referenced this pull requestNov 27, 2022
Original commit message:    [base] Fix SmartOS build    That platform doesn't have `malloc_usable_size`.    Refs:nodejs/node-v8#239    Change-Id: I011dd8449d02b27219a32cba00132cd068069f50    Reviewed-on:https://chromium-review.googlesource.com/c/v8/v8/+/4026402    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>    Commit-Queue: Michaël Zasso <mic.besace@gmail.com>    Cr-Commit-Position: refs/heads/main@{#84256}Refs:v8/v8@f1c888ePR-URL:#45230Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com># Conflicts:#common.gypiPR-URL:#45579Reviewed-By: Michaël Zasso <targos@protonmail.com>Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno added a commit that referenced this pull requestNov 29, 2022
Notable changes:buffer:  * (SEMVER-MINOR) introduce File (Khafra)#45139deps:  * update timezone to 2022f (Node.js GitHub Bot)#45289  * update V8 to 10.8.168.20 (Michaël Zasso)#45230doc:  * deprecate use of invalid ports in `url.parse` (Antoine du Hamel)#45576util:  * add fast path for utf8 encoding (Yagiz Nizipli)#45412PR-URL:#45615
ErickWendel pushed a commit to ErickWendel/node that referenced this pull requestNov 30, 2022
Original commit message:    [base] Fix SmartOS build    That platform doesn't have `malloc_usable_size`.    Refs:nodejs/node-v8#239    Change-Id: I011dd8449d02b27219a32cba00132cd068069f50    Reviewed-on:https://chromium-review.googlesource.com/c/v8/v8/+/4026402    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>    Commit-Queue: Michaël Zasso <mic.besace@gmail.com>    Cr-Commit-Position: refs/heads/main@{#84256}Refs:v8/v8@f1c888ePR-URL:nodejs#45230Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com># Conflicts:#common.gypiPR-URL:nodejs#45579Reviewed-By: Michaël Zasso <targos@protonmail.com>Reviewed-By: James M Snell <jasnell@gmail.com>
ErickWendel pushed a commit to ErickWendel/node that referenced this pull requestNov 30, 2022
Notable changes:buffer:  * (SEMVER-MINOR) introduce File (Khafra)nodejs#45139deps:  * update timezone to 2022f (Node.js GitHub Bot)nodejs#45289  * update V8 to 10.8.168.20 (Michaël Zasso)nodejs#45230doc:  * deprecate use of invalid ports in `url.parse` (Antoine du Hamel)nodejs#45576util:  * add fast path for utf8 encoding (Yagiz Nizipli)nodejs#45412PR-URL:nodejs#45615
@gengjiawengengjiawen mentioned this pull requestFeb 1, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 6, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 14, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 15, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 16, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 21, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 22, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 28, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 29, 2023
jkleinsc pushed a commit to electron/electron that referenced this pull requestNov 30, 2023
* chore: upgrade to Node.js v20* src: allow embedders to override NODE_MODULE_VERSIONnodejs/node#49279* src: fix missing trailing ,nodejs/node#46909* src,tools: initialize cppgcnodejs/node#45704* tools: allow passing absolute path of config.gypi in js2cnodejs/node#49162* tools: port js2c.py to C++nodejs/node#46997* doc,lib: disambiguate the old term, NativeModulenodejs/node#45673* chore: fixup Node.js BSSL tests*nodejs/node#49492*nodejs/node#44498* deps: upgrade to libuv 1.45.0nodejs/node#48078* deps: update V8 to 10.7nodejs/node#44741* test: use gcUntil() in test-v8-serialize-leaknodejs/node#49168* module: make CJS load from ESM loadernodejs/node#47999* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* chore: address changes to CJS/ESM loading* module: make CJS load from ESM loader (nodejs/node#47999)* lib: improve esm resolve performance (nodejs/node#46652)* bootstrap: optimize modules loaded in the built-in snapshotnodejs/node#45849* test: mark test-runner-output as flakynodejs/node#49854* lib: lazy-load deps in modules/run_main.jsnodejs/node#45849* url: use private properties for brand checknodejs/node#46904* test: refactor `test-node-output-errors`nodejs/node#48992* assert: deprecate callTrackernodejs/node#47740* src: cast v8::Object::GetInternalField() return value to v8::Valuenodejs/node#48943* test: adapt test-v8-stats for V8 updatenodejs/node#45230* tls: ensure TLS Sockets are closed if the underlying wrapclosesnodejs/node#49327* test: deflake test-tls-socket-closenodejs/node#49575* net: fix crash due to simultaneous close/shutdown on JS Stream Socketsnodejs/node#49400* net: use asserts in JS Socket Stream to catch races in futurenodejs/node#49400* lib: fix BroadcastChannel initialization locationnodejs/node#46864* src: create BaseObject with node::Realmnodejs/node#44348* src: implement DataQueue and non-memory resident Blobnodejs/node#45258* sea: add support for V8 bytecode-only cachingnodejs/node#48191* chore: fixup patch indices* gyp: put filenames in variablesnodejs/node#46965* build: modify js2c.py into GN executable* fix: (WIP) handle string replacement of fs -> original-fs* [v20.x] backport vm-related memoryfixesnodejs/node#49874* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* src: avoid copying string in fs_permissionnodejs/node#47746* look upon my works ye mightyand dispair* chore: patch cleanup* [api] Remove AllCan Read/Writehttps://chromium-review.googlesource.com/c/v8/v8/+/5006387* fix: missing include for NODE_EXTERN* chore: fixup patch indices* fix: fail properly when js2c fails in Node.js* build: fix js2c root_gen_dir* fix: lib/fs.js -> lib/original-fs.js* build: fix original-fs file xforms* fixup! module: make CJS load from ESM loader* build: get rid of CppHeap for now* build: add patch to prevent extra fs lookup on esm load* build: greatly simplify js2c modificationsMoves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c* chore: update to handle moved internal/modules/helpers file* test: update @types/node test* feat: enable preventing cppgc heap creation* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler* fix: no cppgc initialization in the renderer* gyp: put filenames in variablesnodejs/node#46965* test: disable single executable tests* fix: nan tests failing on node headers missing file* tls,http2: send fatal alert on ALPN mismatchnodejs/node#44031* test: disable snapshot tests*nodejs/node#47887*nodejs/node#49684*nodejs/node#44193* build: use deps/v8 for v8/toolsNode.js hard depends on these in their builtins* test: fix edge snapshot stack tracesnodejs/node#49659* build: remove js2c //base dep* build: use electron_js2c_toolchain to build node_js2c* fix: don't create SafeSet outside packageResolveFixes failure in parallel/test-require-delete-array-iterator:=== release test-require-delete-array-iterator ===Path: parallel/test-require-delete-array-iteratornode:internal/per_context/primordials:426    constructor(i) { super(i); } // eslint-disable-line no-useless-constructor                     ^TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator))    at new Set (<anonymous>)    at new SafeSet (node:internal/per_context/primordials:426:22)* fix: failing crashReporter tests on LinuxThese were failing because our change from node::InitializeNodeWithArgs tonode::InitializeOncePerProcess meant that we now inadvertently calledPlatformInit, which reset signal handling. This meant that our intentionalcrash function ElectronBindings::Crash no longer worked and the renderer processno longer crashed when process.crash() was called. We don't want to use Node.js'default signal handling in the renderer process, so we disable it by passingkNoDefaultSignalHandling to node::InitializeOncePerProcess.* build: only create cppgc heap on non-32 bit platforms* chore: clean up util:CompileAndCall* src: fix compatility with upcoming V8 12.1 APIsnodejs/node#50709* fix: use thread_local BuiltinLoader* chore: fixup v8 patch indices---------Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull requestDec 11, 2023
* chore: upgrade to Node.js v20* src: allow embedders to override NODE_MODULE_VERSIONnodejs/node#49279* src: fix missing trailing ,nodejs/node#46909* src,tools: initialize cppgcnodejs/node#45704* tools: allow passing absolute path of config.gypi in js2cnodejs/node#49162* tools: port js2c.py to C++nodejs/node#46997* doc,lib: disambiguate the old term, NativeModulenodejs/node#45673* chore: fixup Node.js BSSL tests*nodejs/node#49492*nodejs/node#44498* deps: upgrade to libuv 1.45.0nodejs/node#48078* deps: update V8 to 10.7nodejs/node#44741* test: use gcUntil() in test-v8-serialize-leaknodejs/node#49168* module: make CJS load from ESM loadernodejs/node#47999* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* chore: address changes to CJS/ESM loading* module: make CJS load from ESM loader (nodejs/node#47999)* lib: improve esm resolve performance (nodejs/node#46652)* bootstrap: optimize modules loaded in the built-in snapshotnodejs/node#45849* test: mark test-runner-output as flakynodejs/node#49854* lib: lazy-load deps in modules/run_main.jsnodejs/node#45849* url: use private properties for brand checknodejs/node#46904* test: refactor `test-node-output-errors`nodejs/node#48992* assert: deprecate callTrackernodejs/node#47740* src: cast v8::Object::GetInternalField() return value to v8::Valuenodejs/node#48943* test: adapt test-v8-stats for V8 updatenodejs/node#45230* tls: ensure TLS Sockets are closed if the underlying wrapclosesnodejs/node#49327* test: deflake test-tls-socket-closenodejs/node#49575* net: fix crash due to simultaneous close/shutdown on JS Stream Socketsnodejs/node#49400* net: use asserts in JS Socket Stream to catch races in futurenodejs/node#49400* lib: fix BroadcastChannel initialization locationnodejs/node#46864* src: create BaseObject with node::Realmnodejs/node#44348* src: implement DataQueue and non-memory resident Blobnodejs/node#45258* sea: add support for V8 bytecode-only cachingnodejs/node#48191* chore: fixup patch indices* gyp: put filenames in variablesnodejs/node#46965* build: modify js2c.py into GN executable* fix: (WIP) handle string replacement of fs -> original-fs* [v20.x] backport vm-related memoryfixesnodejs/node#49874* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* src: avoid copying string in fs_permissionnodejs/node#47746* look upon my works ye mightyand dispair* chore: patch cleanup* [api] Remove AllCan Read/Writehttps://chromium-review.googlesource.com/c/v8/v8/+/5006387* fix: missing include for NODE_EXTERN* chore: fixup patch indices* fix: fail properly when js2c fails in Node.js* build: fix js2c root_gen_dir* fix: lib/fs.js -> lib/original-fs.js* build: fix original-fs file xforms* fixup! module: make CJS load from ESM loader* build: get rid of CppHeap for now* build: add patch to prevent extra fs lookup on esm load* build: greatly simplify js2c modificationsMoves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c* chore: update to handle moved internal/modules/helpers file* test: update @types/node test* feat: enable preventing cppgc heap creation* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler* fix: no cppgc initialization in the renderer* gyp: put filenames in variablesnodejs/node#46965* test: disable single executable tests* fix: nan tests failing on node headers missing file* tls,http2: send fatal alert on ALPN mismatchnodejs/node#44031* test: disable snapshot tests*nodejs/node#47887*nodejs/node#49684*nodejs/node#44193* build: use deps/v8 for v8/toolsNode.js hard depends on these in their builtins* test: fix edge snapshot stack tracesnodejs/node#49659* build: remove js2c //base dep* build: use electron_js2c_toolchain to build node_js2c* fix: don't create SafeSet outside packageResolveFixes failure in parallel/test-require-delete-array-iterator:=== release test-require-delete-array-iterator ===Path: parallel/test-require-delete-array-iteratornode:internal/per_context/primordials:426    constructor(i) { super(i); } // eslint-disable-line no-useless-constructor                     ^TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator))    at new Set (<anonymous>)    at new SafeSet (node:internal/per_context/primordials:426:22)* fix: failing crashReporter tests on LinuxThese were failing because our change from node::InitializeNodeWithArgs tonode::InitializeOncePerProcess meant that we now inadvertently calledPlatformInit, which reset signal handling. This meant that our intentionalcrash function ElectronBindings::Crash no longer worked and the renderer processno longer crashed when process.crash() was called. We don't want to use Node.js'default signal handling in the renderer process, so we disable it by passingkNoDefaultSignalHandling to node::InitializeOncePerProcess.* build: only create cppgc heap on non-32 bit platforms* chore: clean up util:CompileAndCall* src: fix compatility with upcoming V8 12.1 APIsnodejs/node#50709* fix: use thread_local BuiltinLoader* chore: fixup v8 patch indices---------Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anonriganonriganonrig approved these changes

@gengjiawengengjiawengengjiawen approved these changes

Assignees

@targostargos

Labels
buildIssues and PRs related to build files or the CI.commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.needs-ciPRs that need a full CI run.notable-changePRs with changes that should be highlighted in changelogs.v8 engineIssues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@targos@nodejs-github-bot@StefanStojanovic@tony-go@anonrig@gengjiawen

[8]ページ先頭

©2009-2025 Movatter.jp