Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
src: support WeakReference, diagnostics_channel and net in the snapshot#44193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Review requested:
|
| } | ||
| runTest(fixtures.path('snapshot','weak-reference.js')); | ||
| runTest(fixtures.path('snapshot','weak-reference-gc.js')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I am not 100% sure that we should test this, because technically V8 does not guarantee that the object would actually be GC'ed after a gc() call, but we already have an internal test for WeakReference and it has not come up as flaky so far so 🤷.
mcollina approved these changesAug 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm
Uh oh!
There was an error while loading.Please reload this page.
10 tasks
legendecas approved these changesAug 10, 2022
Marking this as blocked since it depends on#44192. Please feel free to unmark it. |
Probably blocked on#44203 too unless we want to skip the weak reference test in the debug build.. |
Move util::WeakReference to a separate header and implement{de}serialization for it to be snapshotable.8b5a4e4 to9fc1cd7CompareLanded indab2057...fddc701 |
This comment was marked as outdated.
This comment was marked as outdated.
joyeecheung added a commit to joyeecheung/node that referenced this pull requestAug 25, 2022
Move util::WeakReference to a separate header and implement{de}serialization for it to be snapshotable.PR-URL:nodejs#44193Refs:nodejs#44014Refs:nodejs#37476Reviewed-By: Matteo Collina <matteo.collina@gmail.com>Reviewed-By: Chengzhong Wu <legendecas@gmail.com>joyeecheung added a commit to joyeecheung/node that referenced this pull requestAug 25, 2022
PR-URL:nodejs#44193Refs:nodejs#44014Refs:nodejs#37476Reviewed-By: Matteo Collina <matteo.collina@gmail.com>Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Fyko pushed a commit to Fyko/node that referenced this pull requestSep 15, 2022
Move util::WeakReference to a separate header and implement{de}serialization for it to be snapshotable.PR-URL:nodejs#44193Refs:nodejs#44014Refs:nodejs#37476Reviewed-By: Matteo Collina <matteo.collina@gmail.com>Reviewed-By: Chengzhong Wu <legendecas@gmail.com>Fyko pushed a commit to Fyko/node that referenced this pull requestSep 15, 2022
PR-URL:nodejs#44193Refs:nodejs#44014Refs:nodejs#37476Reviewed-By: Matteo Collina <matteo.collina@gmail.com>Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
joyeecheung added a commit to joyeecheung/node that referenced this pull requestOct 14, 2022
Move util::WeakReference to a separate header and implement{de}serialization for it to be snapshotable.PR-URL:nodejs#44193Refs:nodejs#44014Refs:nodejs#37476Reviewed-By: Matteo Collina <matteo.collina@gmail.com>Reviewed-By: Chengzhong Wu <legendecas@gmail.com>codebytere added a commit to electron/electron that referenced this pull requestJan 9, 2023
codebytere added a commit to electron/electron that referenced this pull requestJan 11, 2023
* chore: bump node in DEPS to v18.13.0* child_process: validate arguments for null bytesnodejs/node#44782* bootstrap: merge main thread and worker thread initializationsnodejs/node#44869* module: ensure relative requires work from deleted directoriesnodejs/node#42384* src: add support for externally shared js builtinsnodejs/node#44000* lib: disambiguate `native module` to `binding`nodejs/node#45673* test: convert test-debugger-pid to async/awaitnodejs/node#45179* deps: upgrade to libuv 1.44.2nodejs/node#42340* src: fix cppgc incompatibility in v8nodejs/node#43521* src: use qualified `std::move` call in node_http2nodejs/node#45555* build: fix env.h for cpp20nodejs/node#45516* test: remove experimental-wasm-threads flagnodejs/node#45074* src: iwyu in cleanup_queue.ccnodejs/node#44983* src: add missing include for `std::all_of`nodejs/node#45541* deps: update ICU to 72.1nodejs/node#45068* chore: fixup patch indices* chore: remove errant semicolons-nodejs/node#44179-nodejs/node#44193* src: add support for externally shared js builtinsnodejs/node#44376* chore: add missing GN filenames* deps: update nghttp2 to 1.51.0nodejs/node#45537* chore: disable more Node.js snapshot testsThe Snapshot feature is currently disabled* chore: disable ICU timezone testsNode.js uses a different version of ICU than Electron so theywill often be out of sync.* chore: disable threadpool event tracing testEvent tracing is not enabled in embedded Node.js* chore: fixup patch indices* chore: comments from reviewCo-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
khalwa pushed a commit to solarwindscloud/electron that referenced this pull requestFeb 22, 2023
* chore: bump node in DEPS to v18.13.0* child_process: validate arguments for null bytesnodejs/node#44782* bootstrap: merge main thread and worker thread initializationsnodejs/node#44869* module: ensure relative requires work from deleted directoriesnodejs/node#42384* src: add support for externally shared js builtinsnodejs/node#44000* lib: disambiguate `native module` to `binding`nodejs/node#45673* test: convert test-debugger-pid to async/awaitnodejs/node#45179* deps: upgrade to libuv 1.44.2nodejs/node#42340* src: fix cppgc incompatibility in v8nodejs/node#43521* src: use qualified `std::move` call in node_http2nodejs/node#45555* build: fix env.h for cpp20nodejs/node#45516* test: remove experimental-wasm-threads flagnodejs/node#45074* src: iwyu in cleanup_queue.ccnodejs/node#44983* src: add missing include for `std::all_of`nodejs/node#45541* deps: update ICU to 72.1nodejs/node#45068* chore: fixup patch indices* chore: remove errant semicolons-nodejs/node#44179-nodejs/node#44193* src: add support for externally shared js builtinsnodejs/node#44376* chore: add missing GN filenames* deps: update nghttp2 to 1.51.0nodejs/node#45537* chore: disable more Node.js snapshot testsThe Snapshot feature is currently disabled* chore: disable ICU timezone testsNode.js uses a different version of ICU than Electron so theywill often be out of sync.* chore: disable threadpool event tracing testEvent tracing is not enabled in embedded Node.js* chore: fixup patch indices* chore: comments from reviewCo-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
gecko19 pushed a commit to brightsign/electron that referenced this pull requestFeb 28, 2023
* chore: bump node in DEPS to v18.13.0* child_process: validate arguments for null bytesnodejs/node#44782* bootstrap: merge main thread and worker thread initializationsnodejs/node#44869* module: ensure relative requires work from deleted directoriesnodejs/node#42384* src: add support for externally shared js builtinsnodejs/node#44000* lib: disambiguate `native module` to `binding`nodejs/node#45673* test: convert test-debugger-pid to async/awaitnodejs/node#45179* deps: upgrade to libuv 1.44.2nodejs/node#42340* src: fix cppgc incompatibility in v8nodejs/node#43521* src: use qualified `std::move` call in node_http2nodejs/node#45555* build: fix env.h for cpp20nodejs/node#45516* test: remove experimental-wasm-threads flagnodejs/node#45074* src: iwyu in cleanup_queue.ccnodejs/node#44983* src: add missing include for `std::all_of`nodejs/node#45541* deps: update ICU to 72.1nodejs/node#45068* chore: fixup patch indices* chore: remove errant semicolons-nodejs/node#44179-nodejs/node#44193* src: add support for externally shared js builtinsnodejs/node#44376* chore: add missing GN filenames* deps: update nghttp2 to 1.51.0nodejs/node#45537* chore: disable more Node.js snapshot testsThe Snapshot feature is currently disabled* chore: disable ICU timezone testsNode.js uses a different version of ICU than Electron so theywill often be out of sync.* chore: disable threadpool event tracing testEvent tracing is not enabled in embedded Node.js* chore: fixup patch indices* chore: comments from reviewCo-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
gecko19 pushed a commit to brightsign/electron that referenced this pull requestMar 15, 2023
* chore: bump node in DEPS to v18.13.0* child_process: validate arguments for null bytesnodejs/node#44782* bootstrap: merge main thread and worker thread initializationsnodejs/node#44869* module: ensure relative requires work from deleted directoriesnodejs/node#42384* src: add support for externally shared js builtinsnodejs/node#44000* lib: disambiguate `native module` to `binding`nodejs/node#45673* test: convert test-debugger-pid to async/awaitnodejs/node#45179* deps: upgrade to libuv 1.44.2nodejs/node#42340* src: fix cppgc incompatibility in v8nodejs/node#43521* src: use qualified `std::move` call in node_http2nodejs/node#45555* build: fix env.h for cpp20nodejs/node#45516* test: remove experimental-wasm-threads flagnodejs/node#45074* src: iwyu in cleanup_queue.ccnodejs/node#44983* src: add missing include for `std::all_of`nodejs/node#45541* deps: update ICU to 72.1nodejs/node#45068* chore: fixup patch indices* chore: remove errant semicolons-nodejs/node#44179-nodejs/node#44193* src: add support for externally shared js builtinsnodejs/node#44376* chore: add missing GN filenames* deps: update nghttp2 to 1.51.0nodejs/node#45537* chore: disable more Node.js snapshot testsThe Snapshot feature is currently disabled* chore: disable ICU timezone testsNode.js uses a different version of ICU than Electron so theywill often be out of sync.* chore: disable threadpool event tracing testEvent tracing is not enabled in embedded Node.js* chore: fixup patch indices* chore: comments from reviewCo-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
gecko19 pushed a commit to brightsign/electron that referenced this pull requestMar 15, 2023
* chore: bump node in DEPS to v18.13.0* child_process: validate arguments for null bytesnodejs/node#44782* bootstrap: merge main thread and worker thread initializationsnodejs/node#44869* module: ensure relative requires work from deleted directoriesnodejs/node#42384* src: add support for externally shared js builtinsnodejs/node#44000* lib: disambiguate `native module` to `binding`nodejs/node#45673* test: convert test-debugger-pid to async/awaitnodejs/node#45179* deps: upgrade to libuv 1.44.2nodejs/node#42340* src: fix cppgc incompatibility in v8nodejs/node#43521* src: use qualified `std::move` call in node_http2nodejs/node#45555* build: fix env.h for cpp20nodejs/node#45516* test: remove experimental-wasm-threads flagnodejs/node#45074* src: iwyu in cleanup_queue.ccnodejs/node#44983* src: add missing include for `std::all_of`nodejs/node#45541* deps: update ICU to 72.1nodejs/node#45068* chore: fixup patch indices* chore: remove errant semicolons-nodejs/node#44179-nodejs/node#44193* src: add support for externally shared js builtinsnodejs/node#44376* chore: add missing GN filenames* deps: update nghttp2 to 1.51.0nodejs/node#45537* chore: disable more Node.js snapshot testsThe Snapshot feature is currently disabled* chore: disable ICU timezone testsNode.js uses a different version of ICU than Electron so theywill often be out of sync.* chore: disable threadpool event tracing testEvent tracing is not enabled in embedded Node.js* chore: fixup patch indices* chore: comments from reviewCo-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
codebytere added a commit to electron/electron that referenced this pull requestNov 17, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 21, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 22, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 28, 2023
codebytere added a commit to electron/electron that referenced this pull requestNov 29, 2023
jkleinsc pushed a commit to electron/electron that referenced this pull requestNov 30, 2023
* chore: upgrade to Node.js v20* src: allow embedders to override NODE_MODULE_VERSIONnodejs/node#49279* src: fix missing trailing ,nodejs/node#46909* src,tools: initialize cppgcnodejs/node#45704* tools: allow passing absolute path of config.gypi in js2cnodejs/node#49162* tools: port js2c.py to C++nodejs/node#46997* doc,lib: disambiguate the old term, NativeModulenodejs/node#45673* chore: fixup Node.js BSSL tests*nodejs/node#49492*nodejs/node#44498* deps: upgrade to libuv 1.45.0nodejs/node#48078* deps: update V8 to 10.7nodejs/node#44741* test: use gcUntil() in test-v8-serialize-leaknodejs/node#49168* module: make CJS load from ESM loadernodejs/node#47999* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* chore: address changes to CJS/ESM loading* module: make CJS load from ESM loader (nodejs/node#47999)* lib: improve esm resolve performance (nodejs/node#46652)* bootstrap: optimize modules loaded in the built-in snapshotnodejs/node#45849* test: mark test-runner-output as flakynodejs/node#49854* lib: lazy-load deps in modules/run_main.jsnodejs/node#45849* url: use private properties for brand checknodejs/node#46904* test: refactor `test-node-output-errors`nodejs/node#48992* assert: deprecate callTrackernodejs/node#47740* src: cast v8::Object::GetInternalField() return value to v8::Valuenodejs/node#48943* test: adapt test-v8-stats for V8 updatenodejs/node#45230* tls: ensure TLS Sockets are closed if the underlying wrapclosesnodejs/node#49327* test: deflake test-tls-socket-closenodejs/node#49575* net: fix crash due to simultaneous close/shutdown on JS Stream Socketsnodejs/node#49400* net: use asserts in JS Socket Stream to catch races in futurenodejs/node#49400* lib: fix BroadcastChannel initialization locationnodejs/node#46864* src: create BaseObject with node::Realmnodejs/node#44348* src: implement DataQueue and non-memory resident Blobnodejs/node#45258* sea: add support for V8 bytecode-only cachingnodejs/node#48191* chore: fixup patch indices* gyp: put filenames in variablesnodejs/node#46965* build: modify js2c.py into GN executable* fix: (WIP) handle string replacement of fs -> original-fs* [v20.x] backport vm-related memoryfixesnodejs/node#49874* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* src: avoid copying string in fs_permissionnodejs/node#47746* look upon my works ye mightyand dispair* chore: patch cleanup* [api] Remove AllCan Read/Writehttps://chromium-review.googlesource.com/c/v8/v8/+/5006387* fix: missing include for NODE_EXTERN* chore: fixup patch indices* fix: fail properly when js2c fails in Node.js* build: fix js2c root_gen_dir* fix: lib/fs.js -> lib/original-fs.js* build: fix original-fs file xforms* fixup! module: make CJS load from ESM loader* build: get rid of CppHeap for now* build: add patch to prevent extra fs lookup on esm load* build: greatly simplify js2c modificationsMoves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c* chore: update to handle moved internal/modules/helpers file* test: update @types/node test* feat: enable preventing cppgc heap creation* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler* fix: no cppgc initialization in the renderer* gyp: put filenames in variablesnodejs/node#46965* test: disable single executable tests* fix: nan tests failing on node headers missing file* tls,http2: send fatal alert on ALPN mismatchnodejs/node#44031* test: disable snapshot tests*nodejs/node#47887*nodejs/node#49684*nodejs/node#44193* build: use deps/v8 for v8/toolsNode.js hard depends on these in their builtins* test: fix edge snapshot stack tracesnodejs/node#49659* build: remove js2c //base dep* build: use electron_js2c_toolchain to build node_js2c* fix: don't create SafeSet outside packageResolveFixes failure in parallel/test-require-delete-array-iterator:=== release test-require-delete-array-iterator ===Path: parallel/test-require-delete-array-iteratornode:internal/per_context/primordials:426 constructor(i) { super(i); } // eslint-disable-line no-useless-constructor ^TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator)) at new Set (<anonymous>) at new SafeSet (node:internal/per_context/primordials:426:22)* fix: failing crashReporter tests on LinuxThese were failing because our change from node::InitializeNodeWithArgs tonode::InitializeOncePerProcess meant that we now inadvertently calledPlatformInit, which reset signal handling. This meant that our intentionalcrash function ElectronBindings::Crash no longer worked and the renderer processno longer crashed when process.crash() was called. We don't want to use Node.js'default signal handling in the renderer process, so we disable it by passingkNoDefaultSignalHandling to node::InitializeOncePerProcess.* build: only create cppgc heap on non-32 bit platforms* chore: clean up util:CompileAndCall* src: fix compatility with upcoming V8 12.1 APIsnodejs/node#50709* fix: use thread_local BuiltinLoader* chore: fixup v8 patch indices---------Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull requestDec 11, 2023
* chore: upgrade to Node.js v20* src: allow embedders to override NODE_MODULE_VERSIONnodejs/node#49279* src: fix missing trailing ,nodejs/node#46909* src,tools: initialize cppgcnodejs/node#45704* tools: allow passing absolute path of config.gypi in js2cnodejs/node#49162* tools: port js2c.py to C++nodejs/node#46997* doc,lib: disambiguate the old term, NativeModulenodejs/node#45673* chore: fixup Node.js BSSL tests*nodejs/node#49492*nodejs/node#44498* deps: upgrade to libuv 1.45.0nodejs/node#48078* deps: update V8 to 10.7nodejs/node#44741* test: use gcUntil() in test-v8-serialize-leaknodejs/node#49168* module: make CJS load from ESM loadernodejs/node#47999* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* chore: address changes to CJS/ESM loading* module: make CJS load from ESM loader (nodejs/node#47999)* lib: improve esm resolve performance (nodejs/node#46652)* bootstrap: optimize modules loaded in the built-in snapshotnodejs/node#45849* test: mark test-runner-output as flakynodejs/node#49854* lib: lazy-load deps in modules/run_main.jsnodejs/node#45849* url: use private properties for brand checknodejs/node#46904* test: refactor `test-node-output-errors`nodejs/node#48992* assert: deprecate callTrackernodejs/node#47740* src: cast v8::Object::GetInternalField() return value to v8::Valuenodejs/node#48943* test: adapt test-v8-stats for V8 updatenodejs/node#45230* tls: ensure TLS Sockets are closed if the underlying wrapclosesnodejs/node#49327* test: deflake test-tls-socket-closenodejs/node#49575* net: fix crash due to simultaneous close/shutdown on JS Stream Socketsnodejs/node#49400* net: use asserts in JS Socket Stream to catch races in futurenodejs/node#49400* lib: fix BroadcastChannel initialization locationnodejs/node#46864* src: create BaseObject with node::Realmnodejs/node#44348* src: implement DataQueue and non-memory resident Blobnodejs/node#45258* sea: add support for V8 bytecode-only cachingnodejs/node#48191* chore: fixup patch indices* gyp: put filenames in variablesnodejs/node#46965* build: modify js2c.py into GN executable* fix: (WIP) handle string replacement of fs -> original-fs* [v20.x] backport vm-related memoryfixesnodejs/node#49874* src: make BuiltinLoader threadsafe and non-globalnodejs/node#45942* src: avoid copying string in fs_permissionnodejs/node#47746* look upon my works ye mightyand dispair* chore: patch cleanup* [api] Remove AllCan Read/Writehttps://chromium-review.googlesource.com/c/v8/v8/+/5006387* fix: missing include for NODE_EXTERN* chore: fixup patch indices* fix: fail properly when js2c fails in Node.js* build: fix js2c root_gen_dir* fix: lib/fs.js -> lib/original-fs.js* build: fix original-fs file xforms* fixup! module: make CJS load from ESM loader* build: get rid of CppHeap for now* build: add patch to prevent extra fs lookup on esm load* build: greatly simplify js2c modificationsMoves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c* chore: update to handle moved internal/modules/helpers file* test: update @types/node test* feat: enable preventing cppgc heap creation* feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler* fix: no cppgc initialization in the renderer* gyp: put filenames in variablesnodejs/node#46965* test: disable single executable tests* fix: nan tests failing on node headers missing file* tls,http2: send fatal alert on ALPN mismatchnodejs/node#44031* test: disable snapshot tests*nodejs/node#47887*nodejs/node#49684*nodejs/node#44193* build: use deps/v8 for v8/toolsNode.js hard depends on these in their builtins* test: fix edge snapshot stack tracesnodejs/node#49659* build: remove js2c //base dep* build: use electron_js2c_toolchain to build node_js2c* fix: don't create SafeSet outside packageResolveFixes failure in parallel/test-require-delete-array-iterator:=== release test-require-delete-array-iterator ===Path: parallel/test-require-delete-array-iteratornode:internal/per_context/primordials:426 constructor(i) { super(i); } // eslint-disable-line no-useless-constructor ^TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator)) at new Set (<anonymous>) at new SafeSet (node:internal/per_context/primordials:426:22)* fix: failing crashReporter tests on LinuxThese were failing because our change from node::InitializeNodeWithArgs tonode::InitializeOncePerProcess meant that we now inadvertently calledPlatformInit, which reset signal handling. This meant that our intentionalcrash function ElectronBindings::Crash no longer worked and the renderer processno longer crashed when process.crash() was called. We don't want to use Node.js'default signal handling in the renderer process, so we disable it by passingkNoDefaultSignalHandling to node::InitializeOncePerProcess.* build: only create cppgc heap on non-32 bit platforms* chore: clean up util:CompileAndCall* src: fix compatility with upcoming V8 12.1 APIsnodejs/node#50709* fix: use thread_local BuiltinLoader* chore: fixup v8 patch indices---------Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The first commit comes from44192.
The support for net isn't complete, for example there is still work to be done to make the DNS code snapshotable. But it's already alright to snapshot sockets that have never fired DNS requests and are not actively open.
Refs:#44014
Refs:#37476