Commite0d213d

elliotgoodrich

authored and

marco-ippolito

committed

doc: fix module customization hook examples

When running these examples, `node` fails to return as this`MessagePort` keeps the event loop active in the main thread unlessit is `unref()`ed.Fixes:#52846PR-URL:#53637Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>Reviewed-By: Chemi Atlow <chemi@atlow.co.il>Reviewed-By: Luigi Pinca <luigipinca@gmail.com>Reviewed-By: James M Snell <jasnell@gmail.com>Reviewed-By: Moshe Atlow <moshe@atlow.co.il>Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

1 parent2d8490f commite0d213dCopy full SHA for e0d213d

File tree

1 file changed

-0

lines changed

doc/api
- module.md

1 file changed

-0

lines changed

`‎doc/api/module.md`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -321,6 +321,7 @@ const { port1, port2 } = new MessageChannel();`
`321`	`321`	`port1.on('message', (msg)=> {`
`322`	`322`	`console.log(msg);`
`323`	`323`	`});`
	`324`	`+port1.unref();`
`324`	`325`
`325`	`326`	`register('./my-hooks.mjs', {`
`326`	`327`	`parentURL:import.meta.url,`
`@@ -341,6 +342,7 @@ const { port1, port2 } = new MessageChannel();`
`341`	`342`	`port1.on('message', (msg)=> {`
`342`	`343`	`console.log(msg);`
`343`	`344`	`});`
	`345`	`+port1.unref();`
`344`	`346`
`345`	`347`	`register('./my-hooks.mjs', {`
`346`	`348`	`parentURL:pathToFileURL(__filename),`
`@@ -431,6 +433,7 @@ const { port1, port2 } = new MessageChannel();`
`431`	`433`	`port1.on('message', (msg)=> {`
`432`	`434`	`assert.strictEqual(msg,'increment: 2');`
`433`	`435`	`});`
	`436`	`+port1.unref();`
`434`	`437`
`435`	`438`	`register('./path-to-my-hooks.js', {`
`436`	`439`	`parentURL:import.meta.url,`
`@@ -453,6 +456,7 @@ const { port1, port2 } = new MessageChannel();`
`453`	`456`	`port1.on('message', (msg)=> {`
`454`	`457`	`assert.strictEqual(msg,'increment: 2');`
`455`	`458`	`});`
	`459`	`+port1.unref();`
`456`	`460`
`457`	`461`	`register('./path-to-my-hooks.js', {`
`458`	`462`	`parentURL:pathToFileURL(__filename),`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commite0d213d

File tree

1 file changed

1 file changed

`‎doc/api/module.md`

0 commit comments