Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitbe94e47

Browse files
lpincamarco-ippolito
authored andcommitted
test: deflake test-blob-file-backed
Avoid race conditions by using a different file for each subtest.Fixes:#51860PR-URL:#53920Reviewed-By: Richard Lau <rlau@redhat.com>Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parentc667fbd commitbe94e47

File tree

1 file changed

+17
-11
lines changed

1 file changed

+17
-11
lines changed

‎test/parallel/test-blob-file-backed.js

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,17 @@ const tmpdir = require('../common/tmpdir');
2121
consttestfile=tmpdir.resolve('test-file-backed-blob.txt');
2222
consttestfile2=tmpdir.resolve('test-file-backed-blob2.txt');
2323
consttestfile3=tmpdir.resolve('test-file-backed-blob3.txt');
24+
consttestfile4=tmpdir.resolve('test-file-backed-blob4.txt');
25+
consttestfile5=tmpdir.resolve('test-file-backed-blob5.txt');
2426
tmpdir.refresh();
2527

2628
constdata=`${'a'.repeat(1000)}${'b'.repeat(2000)}`;
2729

2830
writeFileSync(testfile,data);
29-
writeFileSync(testfile2,data.repeat(100));
30-
writeFileSync(testfile3,'');
31+
writeFileSync(testfile2,data);
32+
writeFileSync(testfile3,data.repeat(100));
33+
writeFileSync(testfile4,'');
34+
writeFileSync(testfile5,'');
3135

3236
(async()=>{
3337
constblob=awaitopenAsBlob(testfile);
@@ -69,7 +73,7 @@ writeFileSync(testfile3, '');
6973

7074
(async()=>{
7175
// Refs: https://github.com/nodejs/node/issues/47683
72-
constblob=awaitopenAsBlob(testfile);
76+
constblob=awaitopenAsBlob(testfile2);
7377
constres=blob.slice(10,20);
7478
constab=awaitres.arrayBuffer();
7579
strictEqual(res.size,ab.byteLength);
@@ -82,39 +86,41 @@ writeFileSync(testfile3, '');
8286

8387
constres1=blob.slice(995,1005);
8488
strictEqual(awaitres1.text(),data.slice(995,1005));
89+
awaitunlink(testfile2);
8590
})().then(common.mustCall());
8691

8792
(async()=>{
88-
constblob=awaitopenAsBlob(testfile2);
93+
constblob=awaitopenAsBlob(testfile3);
8994
conststream=blob.stream();
9095
constread=async()=>{
9196
// eslint-disable-next-line no-unused-vars
9297
forawait(const_ofstream){
93-
writeFileSync(testfile2,data+'abc');
98+
writeFileSync(testfile3,data+'abc');
9499
}
95100
};
96101

97102
awaitrejects(read(),{name:'NotReadableError'});
98103

99-
awaitunlink(testfile2);
104+
awaitunlink(testfile3);
100105
})().then(common.mustCall());
101106

102107
(async()=>{
103-
constblob=awaitopenAsBlob(testfile3);
108+
constblob=awaitopenAsBlob(testfile4);
104109
strictEqual(blob.size,0);
105110
strictEqual(awaitblob.text(),'');
106-
writeFileSync(testfile3,'abc');
111+
writeFileSync(testfile4,'abc');
107112
awaitrejects(blob.text(),{name:'NotReadableError'});
108-
awaitunlink(testfile3);
113+
awaitunlink(testfile4);
109114
})().then(common.mustCall());
110115

111116
(async()=>{
112-
constblob=awaitopenAsBlob(testfile3);
117+
constblob=awaitopenAsBlob(testfile5);
113118
strictEqual(blob.size,0);
114-
writeFileSync(testfile3,'abc');
119+
writeFileSync(testfile5,'abc');
115120
conststream=blob.stream();
116121
constreader=stream.getReader();
117122
awaitrejects(()=>reader.read(),{name:'NotReadableError'});
123+
awaitunlink(testfile5);
118124
})().then(common.mustCall());
119125

120126
(async()=>{

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp