Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
Commit43ede1a
test: mark 'test/parallel/test-sqlite.js' as flaky
The current test is large and can time out. It should be splitinto multiple smaller tests as done in#54014. However, thatapproach appears to change GC behavior such that the databasefiles are not cleaned up quickly enough on Windows. Forcingany unfinalized SQL statements to be GC'ed appears to fix theproblem. Mark the original test as flaky until the necessarycode changes are made.PR-URL:#54031Reviewed-By: Moshe Atlow <moshe@atlow.co.il>Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>Reviewed-By: Richard Lau <rlau@redhat.com>1 parent0d70c79 commit43ede1a
1 file changed
+3
-0
lines changedLines changed: 3 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
19 | 19 |
| |
20 | 20 |
| |
21 | 21 |
| |
| 22 | + | |
| 23 | + | |
| 24 | + | |
22 | 25 |
| |
23 | 26 |
| |
24 | 27 |
| |
|
0 commit comments
Comments
(0)