Commit206c668

cjihrig

authored and

marco-ippolito

committed

test_runner: remove plan option from run()

This commit removes the plan option to run(). I believe it wasadded by mistake. It is not documented, untested, and a testplan does not make sense in the context of run().This commit also fixes a minor formatting issue in a relatedfixture.Refs:#52860PR-URL:#53834Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>Reviewed-By: Luigi Pinca <luigipinca@gmail.com>Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>Reviewed-By: James M Snell <jasnell@gmail.com>Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

1 parent8660d48 commit206c668Copy full SHA for 206c668

File tree

2 files changed

-3

lines changed

lib/internal/test_runner
- runner.js
test/fixtures/test-runner/output
- test-runner-plan.js

2 files changed

-3

lines changed

`‎lib/internal/test_runner/runner.js`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -524,7 +524,6 @@ function run(options) {`
`524`	`524`	`watch,`
`525`	`525`	`setup,`
`526`	`526`	`only,`
`527`		`- plan,`
`528`	`527`	`}=options;`
`529`	`528`
`530`	`529`	`if(files!=null){`
`@@ -577,7 +576,7 @@ function run(options) {`
`577`	`576`	`});`
`578`	`577`	`}`
`579`	`578`
`580`		`-constroot=createTestTree({__proto__:null, concurrency, timeout, signal, plan});`
	`579`	`+constroot=createTestTree({__proto__:null, concurrency, timeout, signal});`
`581`	`580`	`root.harness.shouldColorizeTestFiles\|\|=shouldColorizeTestFiles(root);`
`582`	`581`
`583`	`582`	`if(process.env.NODE_TEST_CONTEXT!==undefined){`

`‎test/fixtures/test-runner/output/test-runner-plan.js`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,6 @@ test('planning with streams', (t, done) => {`
`74`	`74`	`});`
`75`	`75`
`76`	`76`	`stream.on('end',()=>{`
`77`		`-done();`
	`77`	`+done();`
`78`	`78`	`});`
`79`	`79`	`})`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit206c668

File tree

2 files changed

2 files changed

`‎lib/internal/test_runner/runner.js`

`‎test/fixtures/test-runner/output/test-runner-plan.js`

0 commit comments