Commit1cf4ad7

targos

authored and

nodejs-github-bot

committed

deps: silence irrelevant V8 warning

PR-URL:#44741Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>Reviewed-By: Jiawen Geng <technicalcute@gmail.com>Reviewed-By: James M Snell <jasnell@gmail.com>PR-URL:#45230Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

1 parentcecad3b commit1cf4ad7Copy full SHA for 1cf4ad7

File tree

2 files changed

-2

lines changed

common.gypi
deps/v8/include
- v8-persistent-handle.h

2 files changed

-2

lines changed

`‎common.gypi`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@`
`36`	`36`
`37`	`37`	`# Reset this number to 0 on major V8 upgrades.`
`38`	`38`	`# Increment by one for each non-official patch applied to deps/v8.`
`39`		`-'v8_embedder_string':'-node.2',`
	`39`	`+'v8_embedder_string':'-node.3',`
`40`	`40`
`41`	`41`	`##### V8 defaults for Node.js #####`
`42`	`42`

`‎deps/v8/include/v8-persistent-handle.h`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -252,7 +252,7 @@ class NonCopyablePersistentTraits {`
`252`	`252`	`* This will clone the contents of storage cell, but not any of the flags, etc.`
`253`	`253`	`*/`
`254`	`254`	`template<classT>`
`255`		`-structV8_DEPRECATED("Use v8::Global instead")CopyablePersistentTraits {`
	`255`	`+structCopyablePersistentTraits {`
`256`	`256`	`using CopyablePersistent = Persistent<T, CopyablePersistentTraits<T>>;`
`257`	`257`	`staticconstboolkResetInDestructor =true;`
`258`	`258`	`template<classS,classM>`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit1cf4ad7

File tree

2 files changed

2 files changed

`‎common.gypi`

`‎deps/v8/include/v8-persistent-handle.h`

0 commit comments