Commit0c24b91

tniessen

authored and

marco-ippolito

committed

src: fix error handling in ExportJWKAsymmetricKey

Because call sites check IsNothing() on the return value ofExportJWKAsymmetricKey() and ignore the boolean value if the returnvalue is Just (i.e., not nothing), this function must return Nothing()instead of Just(false) when throwing a JavaScript error.PR-URL:#53767Reviewed-By: Filip Skokan <panva.ip@gmail.com>Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent2a2620e commit0c24b91Copy full SHA for 0c24b91

File tree

1 file changed

-1

lines changed

src/crypto
- crypto_keys.cc

1 file changed

-1

lines changed

`‎src/crypto/crypto_keys.cc`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -505,7 +505,7 @@ Maybe<bool> ExportJWKAsymmetricKey(`
`505`	`505`	`case EVP_PKEY_X448:returnExportJWKEdKey(env, key, target);`
`506`	`506`	`}`
`507`	`507`	`THROW_ERR_CRYPTO_JWK_UNSUPPORTED_KEY_TYPE(env);`
`508`		`-returnJust(false);`
	`508`	`+returnNothing<bool>();`
`509`	`509`	`}`
`510`	`510`
`511`	`511`	`std::shared_ptr<KeyObjectData>ImportJWKAsymmetricKey(`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit0c24b91

File tree

1 file changed

1 file changed

`‎src/crypto/crypto_keys.cc`

0 commit comments