Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1k
Comments
Fix for allowing POST request with formdata-node using response.body stream as body#1719
Open
4miners wants to merge 4 commits intonode-fetch:mainfrom
Open
Fix for allowing POST request with formdata-node using response.body stream as body#17194miners wants to merge 4 commits intonode-fetch:mainfrom
4miners wants to merge 4 commits intonode-fetch:mainfrom
Conversation
jsmonkey approved these changesMar 18, 2023
jsmonkey left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good!
lorenzopolidori commentedMar 31, 2023
@4miners What is the timeline for this PR to be merged and this fix being released? |
Author
4miners commentedMar 31, 2023
@lorenzopolidori Sorry, it's hard to tell because I'm only a contributor, not a repository maintainer. |
Maxou44 commentedJan 16, 2024
Can someone merge this fix ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
It should be possible to use
response.bodyof onefetchrequest as the source body for the secondfetchrequest, usingformdata-node. This allows downloading file from one remote server and uploading it, as it's downloaded, to another remote server (on-the-fly, without writing to disc). This was not possible due to aCannot perform Construct on a detached ArrayBuffererror.Changes
previousChunkinstead of passing it by reference.TestServerinstance to allow new test cases.should allow POST request with formdata-node using response.body stream as bodytest case.Additional information