Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix v2.6.3 that did not send query params#1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jimmywarting merged 1 commit into2.xfromfix-v2.6.3
Sep 21, 2021
Merged

Conversation

@jimmywarting
Copy link
Collaborator

@jimmywartingjimmywarting commentedSep 21, 2021•
edited
Loading

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • New feature
  • Other, please explain:

closes#1300

ndelangen, erkenberg, ae86jack, AnastasiaSokolova, simllll, and kyaukyuai reacted with thumbs up emoji
@jimmywartingjimmywarting deleted the fix-v2.6.3 branchSeptember 21, 2021 09:01
@jimmywartingjimmywarting restored the fix-v2.6.3 branchSeptember 21, 2021 09:35
@jimmywartingjimmywarting changed the base branch frommain to2.xSeptember 21, 2021 09:36
@jimmywarting
Copy link
CollaboratorAuthor

jimmywarting commentedSep 21, 2021•
edited
Loading

This have already been released to npm
had to get it out quickly, it was breaking a few things.

So no other choice then to merge

vuilleumierc, melvinchng, mcat95, LinusU, and BenSjoberg reacted with thumbs up emoji

Copy link
Member

@LinusULinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for the quick follow up on this! ❤️

kyaukyuai reacted with heart emoji
@jimmywartingjimmywarting merged commit18193c5 into2.xSep 21, 2021
@jimmywartingjimmywarting deleted the fix-v2.6.3 branchSeptember 21, 2021 14:42
expect(json.url).to.equal('/inspect?month=2021-09')
})
})

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks for putting in a test to avoid future regressions 💐

This explains the mystery ofoctokit/rest.js#114 andsemantic-release/github#415

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gr2mgr2mgr2m left review comments

@LinusULinusULinusU approved these changes

@bitinnbitinnAwaiting requested review from bitinn

@RichienbRichienbAwaiting requested review from Richienb

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Problem with query params

4 participants

@jimmywarting@gr2m@LinusU
[8]ページ先頭
©2009-2025 Movatter.jp