Commit18193c5

authored

fix v2.6.3 that did not sending query params (#1301)

1 parentace7536 commit18193c5Copy full SHA for 18193c5

File tree

+15

-14

lines changed

+15

-14

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,10 @@ Changelog`
`5`	`5`
`6`	`6`	`#2.x release`
`7`	`7`
	`8`	`+##v2.6.4`
	`9`	`+`
	`10`	`+- Hotfix: fix v2.6.3 that did not sending query params`
	`11`	`+`
`8`	`12`	`##v2.6.3`
`9`	`13`
`10`	`14`	`- Fix: properly encode url with unicode characters`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name":"node-fetch",`
`3`		`-"version":"2.6.3",`
	`3`	`+"version":"2.6.4",`
`4`	`4`	`"description":"A light-weight module that brings window.fetch to node.js",`
`5`	`5`	`"main":"lib/index.js",`
`6`	`6`	`"browser":"./browser.js",`

Lines changed: 1 addition & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,19 +33,7 @@ function parseURL(urlStr) {`
`33`	`33`	`Absolute URL: https://tools.ietf.org/html/rfc3986#section-4.3`
`34`	`34`	`*/`
`35`	`35`	`if(/^[a-zA-Z][a-zA-Z\d+\-.]*:/.exec(urlStr)){`
`36`		`-consturl=newURL(urlStr);`
`37`		`-`
`38`		`-return{`
`39`		`-path:url.pathname,`
`40`		`-pathname:url.pathname,`
`41`		`-hostname:url.hostname,`
`42`		`-protocol:url.protocol,`
`43`		`-port:url.port,`
`44`		`-hash:url.hash,`
`45`		`-search:url.search,`
`46`		`-query:url.query,`
`47`		`-href:url.href,`
`48`		`-}`
	`36`	`+urlStr=newURL(urlStr).toString()`
`49`	`37`	`}`
`50`	`38`
`51`	`39`	`// Fallback to old implementation for arbitrary URLs`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2847,6 +2847,15 @@ describe('external encoding', () => {`
`2847`	`2847`	`});`
`2848`	`2848`
`2849`	`2849`	`describe('issue #1290',function(){`
	`2850`	`+`
	`2851`	`+it('should keep query params',function(){`
	`2852`	+returnfetch(`${base}inspect?month=2021-09`)
	`2853`	`+.then(res=>res.json())`
	`2854`	`+.then(json=>{`
	`2855`	`+expect(json.url).to.equal('/inspect?month=2021-09')`
	`2856`	`+})`
	`2857`	`+})`
	`2858`	`+`
`2850`	`2859`	`it('should handle escaped unicode in URLs',()=>{`
`2851`	`2860`	consturl=`${base}issues/1290/%E3%81%B2%E3%82%89%E3%81%8C%E3%81%AA`;
`2852`	`2861`	`returnfetch(url).then((res)=>{`

Comments

(0)