Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix letsencrypt tests, user type definition and getSubmodules function#69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
qknight merged 2 commits intonixcloud:masterfromMelkor333:master
Sep 22, 2020

Conversation

@Melkor333
Copy link
Contributor

This PRfixes#64.

I just tried to pretty much implement what@infinisil proposed in the issue as nix is still quite a bit of magic to me...

This PR only works for 20.03, NOT for 19.09 (the submodule magic from infinisil doesn't work without his change in nixpkgs..) and on unstable the test suite can't run through. Infinisil recommended to make it backwards compatible but I really don't know how to do this.
My approach would be to simply create different branches for the different channels as it seems like there are quite some things that have changed... Or create a19.09 Tag on the last commit that works on that channel...

I tried to fix the tests and itseems to me like they run successful on the 20.03 channel. I also use this commit on a personal mailserver without issues until now. On unstable the test suite seems to log this in an endless loop:

machine: running command: nc -z localhost 80machine: exit status 1(0.01 seconds)

after this:

machine# [   53.880305] systemd[1]: static-nginx-foo-nginx.service: Scheduled restart job, restart counter is at 4.machine# [   53.909956] systemd[1]: static-nginx-bar-nginx.service: Scheduled restart job, restart counter is at 4.machine# [   53.928762] systemd[1]: nixcloud.reverse-proxy.service: Scheduled restart job, restart counter is at 4.machine# [   53.942133] systemd[1]: Stopped Connects several webservers together and manages TLS and makes hosting easy!.machine# [   53.957899] systemd[1]: Starting Connects several webservers together and manages TLS and makes hosting easy!...machine# [   53.963556] nginx[1070]: nginx: [alert] could not open error log file: open() "/var/log/nginx/error.log" failed (2: No such file or directory)machine# [   53.970189] nginx[1070]: 2020/08/08 18:29:46 [warn] 1070#1070: the "user" directive makes sense only if the master process runs with super-user privileges, ignored in /nix/store/048z89pv9swzl0zxf6wb5xry3a08lmgj-nginx_check_config/static-nginx-bar.conf:1machine# [   53.975840] nginx[1070]: 2020/08/08 18:29:46 [emerg] 1070#1070: mkdir() "/var/cache/nginx/client_body" failed (2: No such file or directory)machine# [   53.981025] systemd[1]: Stopped Nginx HTTPD.machine# [   53.984588] nginx[1071]: nginx: [alert] could not open error log file: open() "/var/log/nginx/error.log" failed (2: No such file or directory)machine# [   53.989739] nginx[1071]: 2020/08/08 18:29:46 [warn] 1071#1071: the "user" directive makes sense only if the master process runs with super-user privileges, ignored in /nix/store/k3nrmia48dxp1flpvn6a1nn126lpsn7r-nginx_check_config/static-nginx-foo.conf:1machine# [   53.995229] nginx[1071]: 2020/08/08 18:29:46 [emerg] 1071#1071: mkdir() "/var/cache/nginx/client_body" failed (2: No such file or directory)machine# [   54.004386] systemd[1]: Started Nginx HTTPD.machine# [   54.009533] systemd[1]: Stopped Nginx HTTPD.machine# [   54.013562] systemd[1]: Started Nginx HTTPD.machine# [   54.017165] systemd[1]: static-nginx-foo-nginx.service: Main process exited, code=exited, status=1/FAILUREmachine# [   54.020886] systemd[1]: static-nginx-foo-nginx.service: Failed with result 'exit-code'.machine# [   54.024272] systemd[1]: static-nginx-bar-nginx.service: Main process exited, code=exited, status=1/FAILUREmachine# [   54.033648] systemd[1]: static-nginx-bar-nginx.service: Failed with result 'exit-code'.machine# [   54.037432] nginx[1080]: nginx: [alert] could not open error log file: open() "/var/log/nginx/error.log" failed (2: No such file or directory)machine# [   54.041009] nginx[1080]: 2020/08/08 18:29:46 [emerg] 1080#1080: mkdir() "/var/cache/nginx/client_body" failed (2: No such file or directory)machine# [   54.047841] systemd[1]: Started Connects several webservers together and manages TLS and makes hosting easy!.machine# [   54.051264] systemd[1]: nixcloud.reverse-proxy.service: Main process exited, code=exited, status=1/FAILUREmachine# [   54.054008] systemd[1]: nixcloud.reverse-proxy.service: Failed with result 'exit-code'.machine: running command: nc -z localhost 80machine: exit status 1(0.01 seconds)machine: running command: nc -z localhost 80machine: exit status 1(0.01 seconds)

I don't know what the problem is there, the tests are still a bit too much magic for me to understand. If you could help me with that and also run the tests on 20.03 I would be really glad.

I'd like to get rid of all the deprecation warnings (e.g. perl tests instead of python tests or users as list instead of set) so that the bump to 20.09 will work later on. But before that the tests should at least run successfully on unstable...

@qknight
Copy link
Member

Hi, wonder what to do here now.

@qknightqknight merged commit05701ee intonixcloud:masterSep 22, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing submodules in Nixos

2 participants

@Melkor333@qknight

[8]ページ先頭

©2009-2025 Movatter.jp