- Notifications
You must be signed in to change notification settings - Fork532
[FIX] LegacyMultiProc hangs up indefinitely#2773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This PR relates tonipy#2700, and should fix the problemunderlyingnipy#2548.I first considered adding a control thread that monitorsthe `Pool` of workers, but that would require a large overheadkeeping track of PIDs and polling very often.Just adding the core file of [bpo-22393](python/cpython#10441)shouldfixnipy#2548
(I haven't tested this yet, though) |
As the Python 3.8 version of this, I'm not sure how well this will play with 2.7 and 3.4, at the least. |
Yep, unfortunately, the fix is python +3.7. I'd say we start recommending switching to python 3.7 if the workflow is memory-hungry. |
Given the recentnumpy bug, I'm hesitant to suggest moving scientific applications to 3.7 until upstream projects have had a bit more time to find and fix critical bugs. How hard would this be to port to 3.6? I suspect if we get it working there, 3.5 and 3.4 will fall into place quickly. I'm okay with abandoning 2.7, as long as we don't break current usage further. |
Some thoughts:
|
codecov-io commentedNov 12, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #2773 +/- ##=========================================- Coverage 67.5% 64.1% -3.41%========================================= Files 340 338 -2 Lines 43271 43223 -48 Branches 5364 5362 -2 =========================================- Hits 29210 27707 -1503- Misses 13360 14446 +1086- Partials 701 1070 +369
Continue to review full report at Codecov.
|
This PR relates to#2700, and should fix the problem
underlying#2548.
I first considered adding a control thread that monitors
the
Pool
of workers, but that would require a large overheadkeeping track of PIDs and polling very often.
Just adding the core file ofbpo-22393
shouldfix#2548
Summary
Fixes # .
List of changes proposed in this PR (pull-request)
Acknowledgment