Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FIX] LegacyMultiProc hangs up indefinitely#2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

oesteban
Copy link
Contributor

This PR relates to#2700, and should fix the problem
underlying#2548.

I first considered adding a control thread that monitors
thePool of workers, but that would require a large overhead
keeping track of PIDs and polling very often.

Just adding the core file ofbpo-22393
shouldfix#2548

Summary

Fixes # .

List of changes proposed in this PR (pull-request)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

This PR relates tonipy#2700, and should fix the problemunderlyingnipy#2548.I first considered adding a control thread that monitorsthe `Pool` of workers, but that would require a large overheadkeeping track of PIDs and polling very often.Just adding the core file of [bpo-22393](python/cpython#10441)shouldfixnipy#2548
@oesteban
Copy link
ContributorAuthor

(I haven't tested this yet, though)

@effigies
Copy link
Member

As the Python 3.8 version of this, I'm not sure how well this will play with 2.7 and 3.4, at the least.

@oesteban
Copy link
ContributorAuthor

Yep, unfortunately, the fix is python +3.7. I'd say we start recommending switching to python 3.7 if the workflow is memory-hungry.

@effigies
Copy link
Member

Given the recentnumpy bug, I'm hesitant to suggest moving scientific applications to 3.7 until upstream projects have had a bit more time to find and fix critical bugs.

How hard would this be to port to 3.6? I suspect if we get it working there, 3.5 and 3.4 will fall into place quickly.

I'm okay with abandoning 2.7, as long as we don't break current usage further.

@oesteban
Copy link
ContributorAuthor

Some thoughts:

  • As per your link, anaconda fixed the bug in numpy 1.15.2, and it is fixed with 1.15.3 withPypi. I guess we should update the pinned versions if python == 3.7.
  • I'm not proposing to discontinue python <3.7, I would just make this fix available for python +3.7.
  • If nothing of the above works, then I'd say it should not be too hard to backport to 3.6 or even 3.5 (prior to 3.5 it would be harder). Although I'm not sure it is worthwhile.

@codecov-io
Copy link

codecov-io commentedNov 12, 2018
edited
Loading

Codecov Report

Merging#2773 intomaster willdecrease coverage by3.4%.
The diff coverage is100%.

Impacted file tree graph

@@            Coverage Diff            @@##           master   #2773      +/-   ##=========================================- Coverage    67.5%   64.1%   -3.41%=========================================  Files         340     338       -2       Lines       43271   43223      -48       Branches     5364    5362       -2     =========================================- Hits        29210   27707    -1503- Misses      13360   14446    +1086- Partials      701    1070     +369
FlagCoverage Δ
#smoketests?
#unittests64.1% <100%> (-0.82%)⬇️
Impacted FilesCoverage Δ
nipype/pipeline/plugins/legacymultiproc.py65.51% <100%> (+0.51%)⬆️
nipype/interfaces/nilearn.py40% <0%> (-56.67%)⬇️
nipype/utils/spm_docs.py25.92% <0%> (-44.45%)⬇️
nipype/interfaces/freesurfer/base.py49.59% <0%> (-30.9%)⬇️
nipype/utils/logger.py59.7% <0%> (-29.86%)⬇️
nipype/algorithms/rapidart.py35.39% <0%> (-29.21%)⬇️
nipype/interfaces/spm/base.py58.41% <0%> (-29.05%)⬇️
nipype/utils/provenance.py55.73% <0%> (-28.99%)⬇️
nipype/interfaces/fsl/model.py55.26% <0%> (-25.35%)⬇️
nipype/testing/fixtures.py77.33% <0%> (-21.34%)⬇️
... and42 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update199d9a6...b220c86. Read thecomment docs.

@oestebanoesteban changed the title[FIX] LegacyMultiProc hangs up indefenitely[FIX] LegacyMultiProc hangs up indefinitelyNov 13, 2018
@oestebanoesteban deleted the fix/legacy-multiproc-broken-pool branchNovember 13, 2018 17:24
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MultiProc goes into infinite loop (resource management related)
3 participants
@oesteban@effigies@codecov-io

[8]ページ先頭

©2009-2025 Movatter.jp