Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/nipyPublic

RF: refactor DCT-II into more visible function#417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
matthew-brett wants to merge1 commit intonipy:main
base:main
Choose a base branch
Loading
frommatthew-brett:add-dct-ii

Conversation

matthew-brett
Copy link
Member

Make DCT-II basis an API function, use this function for DCT-II drift in
design_matrix.

@jbpoline - would you mind having a look at this one?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 87.17% when pulling7fe43be on matthew-brett:add-dct-ii intodfbee72 on nipy:master.

@codecov-io
Copy link

codecov-io commentedSep 24, 2016•
edited
Loading

Codecov Report

Merging#417 intomaster willincrease coverage by-0.01%.

@@            Coverage Diff             @@##           master     #417      +/-   ##==========================================- Coverage   83.22%   83.22%   -0.01%==========================================  Files         301      301                Lines       28149    28140       -9       Branches     3279     3278       -1     ==========================================- Hits        23428    23419       -9  Misses       3719     3719                Partials     1002     1002
Impacted FilesCoverage Δ
nipy/modalities/fmri/design_matrix.py83.64% <100%> (-0.88%)❌

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatef135947...f3be3ee. Read thecomment docs.

@matthew-brett
Copy link
MemberAuthor

@bthirion - will the requirement for continuous samples in time be a problem for you?

https://github.com/nipy/nipy/pull/417/files#diff-9967264e8820787d766a0f3ee1e4ae67R42

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 87.174% when pullingeba5309 on matthew-brett:add-dct-ii intodfbee72 on nipy:master.

@matthew-brett
Copy link
MemberAuthor

@jbpoline - any comments?

@matthew-brett
Copy link
MemberAuthor

@jbpoline@bthirion - another friendly reminder asking for comments.

Use dedicated function for _cosine basis.This refactoring will require continuous times, otherwise it will raisean error.  In any case, I believe that the values returned when timesare not continuous are not valid:a) The current function assumes that all differences in volume times areequal to the difference in the first two volume times, and;b) The DCT values should (I believe) reflect the number of `dt`intervals, not the index into the time vector, as currently.
@matthew-brett
Copy link
MemberAuthor

Gentlemen - I think the current function will be incorrect when the frametimes are not all equally spaced, do you agree?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 86.634% when pullingf3be3ee on matthew-brett:add-dct-ii intof135947 on nipy:master.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@matthew-brett@coveralls@codecov-io
[8]ページ先頭
©2009-2025 Movatter.jp