- Notifications
You must be signed in to change notification settings - Fork269
RF: Unify Caret-XML-style metadata structure as dict-like#1091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedFeb 23, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1091 +/- ##==========================================+ Coverage 92.27% 92.29% +0.02%========================================== Files 99 100 +1 Lines 12228 12247 +19 Branches 2392 2393 +1 ==========================================+ Hits 11283 11303 +20 Misses 621 621+ Partials 324 323 -1
Continue to review full report at Codecov.
|
b91b697 toa95ff51Compare
jbteves left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM with the caveat that I'm not sure what the approval checklist for nibabel looks like 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM! A more parsable gifti metadata makes me really happy.
Reviewing guidelines:https://nipy.org/nibabel/devel/core_developer.html#reviewing |
a95ff51 to6bc86dfCompare
We have two implementations of the same structure in GIFTI and CIFTI-2. The Cifti one is much nicer to deal with, but also a little short of a straight drop-in replacement for
dict().Spurred by writing a parser for
CaretSpecFiles in#1090. Mostly used the Cifti implementation, but dropped thedifference_update()(not sure why this exists, so don't want to copy it without a use case). Used a private_dataobject to allow theGiftiMetaData.datato be a deprecated list view.Scheduled dropping most of the custom bits of each subclass for 6.0 to give a good long warning period.