- Notifications
You must be signed in to change notification settings - Fork269
-
Hi Does anyone know why To test this, I tried to convert a surface file (created during a
nibabel reads the metadata of
It turns out that it reads the |
BetaWas this translation helpful?Give feedback.
All reactions
Replies: 3 comments
-
The reason is that those were the only types of data anybody had available (or found to test with) when the feature was added. As the warning says, You're definitely welcome to propose a patch. I think just permitting |
BetaWas this translation helpful?Give feedback.
All reactions
-
Alright, I'll make a PR with minimal changes, i.e., allowing However, since reading the footer of an FS surface file is reading (tag, value) pairs, I think it would make sense to return a mapping of tag and values. Right now you get something like this when reading the metadata where head is (tag, value, tag) and then the values of latter tag (volume geometry) are expanded to the dict. For this, the API of the functions should probably be modified so it would be breaking. Perhaps for next major release. If you prefer to keep it low level, I understand. I just think that the current structure of the metadata is puzzling. |
BetaWas this translation helpful?Give feedback.
All reactions
-
PR is open#1420 |
BetaWas this translation helpful?Give feedback.