Typescript Enums#60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

itayronen wants to merge5 commits intoniieani:master

base:master

Choose a base branch

fromitayronen:ts-enums

Open

Typescript Enums#60

itayronen wants to merge5 commits intoniieani:masterfromitayronen:ts-enums

Conversation

Copy link

itayronen commentedAug 20, 2019•
edited
Loading

Added a typescript unique feature: Enums

Closes#57

Typescript Enums

3a634a7

Added a typescript unique feature: Enums

niieani requested changes

Aug 22, 2019

View reviewed changes

Copy link

Owner

niieani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It would be good to also coverconst enums before we merge.

You could also mention that this is one of few the places TypeScript deviates from ECMAScript specification, in that this is not just a type annotation, but this affects the emit too (simply stripping out the types isn't enough for TypeScriptenums).

README.md OutdatedShow resolvedHide resolved

Copy link

Contributor

oriSomething commentedAug 23, 2019

@niieani I'm not sure, "const enums" should be mentions, because time after time the TS team against using it in every issue arise about them

Copy link

Contributor

oriSomething commentedAug 23, 2019

There is missing about enums:

Enums are the only nominal types in TS
Aboutnumber enums: They are always mixed withstrings (unlike onlystring enums)

enum E { a, b } = { a: 0, b: 1, 0: "a", 1: "b" };

Copy link

Author

itayronen commentedAug 24, 2019

Agree const enum are not something worth covering. Its a bundle size optimization.
Number enums are not always mixes with string values, you can get the enum key by its value (and vice versa).

I'll add the info about the additional emitted code.
With that said, typescript emits more code than just enums, depends on the ES version you target. It might (Im not sure) be the only additional code if you target es7+.