Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

split nginx.tmpl to support stream module#2608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
lloydzhou wants to merge23 commits intonginx-proxy:main
base:main
Choose a base branch
Loading
fromlloydzhou:feature-split-dest-config

Conversation

@lloydzhou
Copy link

@lloydzhoulloydzhou commentedApr 10, 2025
edited
Loading

split nginx.tmpl to support stream module

nginx.tmpl with envTARGET=streamupstream -->stream.conf.d/10-upstream.conf
nginx.tmpl -->default.conf

then, can include upstream.conf instream block

#2606

usage

# stream.confstream {    include stream.conf.d/10-upstream.conf;    server {        listen     8000;        #TCP traffic will be forwarded to the specified server        proxy_pass web1.nginx-proxy.example;    }}docker run --detach \    --name nginx-proxy \    --publish 80:80 \    --publish 8000:8000 \    --volume /var/run/docker.sock:/tmp/docker.sock:ro \    --volume ./stream.conf:/etc/nginx/toplevel.conf.d/stream.conf:ro \    nginxproxy/nginx-proxy

@lloydzhoulloydzhouforce-pushed thefeature-split-dest-config branch fromfa95bcb to856a582CompareApril 12, 2025 05:52
@lloydzhoulloydzhou marked this pull request as draftApril 12, 2025 07:10
@lloydzhoulloydzhou marked this pull request as ready for reviewApril 12, 2025 08:35
@lloydzhoulloydzhou marked this pull request as draftApril 12, 2025 08:44
@lloydzhoulloydzhou marked this pull request as ready for reviewApril 12, 2025 13:13
@buchdag
Copy link
Member

Hi

Thanks for the PR.

Unfortunately I'm not fond of the approach of having thenginx.tmpl work in two different contexts with conditional logic, as this won't be maintainable long term.

Running multiple docker-gen processes in the container should also be avoided (a single process can render multiple templates).

@buchdagbuchdag added the type/featPR for a new feature labelAug 20, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type/featPR for a new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lloydzhou@buchdag

[8]ページ先頭

©2009-2025 Movatter.jp