- Notifications
You must be signed in to change notification settings - Fork3.1k
Proxy Protocol Support#2587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
antoniomika wants to merge2 commits intonginx-proxy:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
bvli commentedJun 11, 2025
I'd like to see this feature implemented as well.. Are there any reason for not merging this PR? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to#1487, I took a look at adding proxy-protocol support to this project.
The changes included here add a new
ENABLE_PROXY_PROTOCOLenv var, which will enable proxy-protocol support for all docker-gen created listeners. Because settingproxy_protocolon alistenenables the functionality for allserver's that use the same port, I opted to make this option global.Unlike the other PR, I decided to map the
x-forwarded-for(andx-forwarded-port) entry to conform with current use-cases. If setting the real ip module settings is desired, there already exists methods for adding other configurations to the template.I also added tests to verify this functionalityDOES NOT break or modify any of the current proxy header use cases. This feature is opt-in, as nginx will stop responding to HTTP requests that aren't made using the proxy protocol.