question: I'm not sure of what's get rendered here ifdefault_server andproxy_protocol both have a non blank value, aren't the two strings concatenated because of{{- ? 🤔

Nope, everything looks correct because of this:https://github.com/nginx-proxy/nginx-proxy/pull/2587/files/6baf7bbf57785df273cd5ed5871937b9a0a1da2d#diff-a2a77c71854a4489d896f49c59a5f864e5b1e290f6b1ba16f9f39c1a32829c57R887

I made this change so the spacing doesn't look all wonky if neither are enabled.

Here's a test if you're curious:

1. Run a proxy-protocol test case like so:

~$ make build-nginx-proxy-test-alpine build-webserver&& docker compose -f ./test/compose.base.yml -f ./test/test_proxy_protocol/test_proxy-protocol-global-enabled.yml up -d

2. Exec the container and check the proxy lines look okay:

~$ dockerexec nginx-proxy nginx -T2>&1| grep'listen.*proxy_protocol'    listen 80 proxy_protocol;    listen 443 ssl proxy_protocol;    listen 80 proxy_protocol;    listen 443 ssl proxy_protocol;

3. Add a default server by addingDEFAULT_HOST: "proxy-protocol-global-enabled.nginx-proxy.tld" to thenginx-proxy service' environment in./test/test_proxy_protocol/test_proxy-protocol-global-enabled.yml. Rerun the command in 1.
4. Re-grep to check the result:

~$ dockerexec nginx-proxy nginx -T2>&1| grep'listen.*proxy_protocol'    listen 80 default_server proxy_protocol;    listen 443 ssl default_server proxy_protocol;

5. Disable proxy protocol by setting theENABLE_PROXY_PROTOCOL environment var to false in the same file above. Rerun the command in step 1 and grep fordefault_server.

~$ dockerexec nginx-proxy nginx -T2>&1| grep'listen.*default_server'    listen 80 default_server;    listen 443 ssl default_server;

6. Finally with both disabled:

    listen 80;    listen 443 ssl;    listen 80;    listen 443 ssl;

Rerunning the steps above on main, default server disabled looks like this:

    listen 80;    listen 443 ssl;    listen 80 ;    listen 443 ssl ;

And enabled like this:

    listen 80 default_server;    listen 443 ssl default_server;

So you've actually fixed the pre existing spacing issue, thank you 👍