- Notifications
You must be signed in to change notification settings - Fork3.1k
fix: correctly enable TLSv1 and TLSv1.1#2510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
buchdag commentedSep 19, 2024
@liuxiaoy hi, could you provide a bit more context on the PR and explanations on the fix ? |
liuxiaoy commentedSep 26, 2024 • edited by buchdag
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by buchdag
Uh oh!
There was an error while loading.Please reload this page.
Hi, I want my site support TLSv1 TLSv1.1 TLSv1.2 TLSv1.3. |
liuxiaoy commentedSep 27, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
buchdag commentedSep 27, 2024
Thanks for the links 👍 However, I'm not able to confirm that this work locally using either Have you used it and confirmed that it does work, and if so how ? |
liuxiaoy commentedSep 28, 2024
I have test it with the shell below: curl --tls-max 1.0 https://your.com -Ik# oropenssl s_client -connect your.com:443 -tls1or test on the site online like |
liuxiaoy commentedSep 28, 2024
I used to use a lower version of nginx to solve the tlsv1 problem, which was v1.12. Later, in order to automate the certificate renewal, I found some discussions on this topic online. After experiments, I found that a higher version could also solve the problem, so I proposed this PR |
buchdag commentedSep 28, 2024
I think I identified why it can't validate it, seenginx/docker-nginx#858 (comment) for details, I'll think of a way we could handle this. |
buchdag commentedSep 30, 2024
@liuxiaoy regarding your message onnginx/docker-nginx#858 : nginx-proxy is built upon the upstream nginx Docker images, so if you can't enable TLSv1 / TLSv1.1 in the base nginx image, you will have the same issue in nginx-proxy, that's not something specific to the later. |
buchdag commentedSep 30, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The issue comes from the Currentlywe set We can either permanently replace this with the Mozilla-Old values, or dynamically use the Mozilla-Old values when at least one container use an |
buchdag commentedOct 2, 2024
@liuxiaoy could try image It's based on this change and should correctly enable TLSv1 / TLSv1.1 |
buchdag commentedOct 6, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@liuxiaoy I took the liberty to update your PR. |
liuxiaoy commentedOct 11, 2024
@buchdag Sorry for forgetting this. I have tried the If you can't test it there, we can communicate so that you can test it successfully. |
buchdag commentedOct 12, 2024
I was able to confirm that it work on my side, but I wanted to be sure that it worked for you too. The only limitation is the fact that it won't work with the Alpine variant of the image as I indicated in the docs (I could not manage to get it to work, if you have any idea on how to do it that would be welcome). This isn't realistically testable at the moment so I'll merge it as-is. Thanks for bringing the issue to light@liuxiaoy 👍 |
liuxiaoy commentedOct 15, 2024
@buchdag I have try the same on I also try it ok on Test record |
buchdag commentedOct 16, 2024
@liuxiaoy it does indeed work with the alpine version too, I probably mixed up something while testing. Thanks for the heads up, I'll update the docs 👍 |
No description provided.