- Notifications
You must be signed in to change notification settings - Fork3.1k
Add an environment variable to enable CORS requests with basic authentication#1779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
vemonet wants to merge1 commit intonginx-proxy:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…OPTIONS to enable CORS requests. The default behavior does not change, authentication for OPTIONS is still enabled by default
Needs tests |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Added the environment variable
ENABLE_CORS_AUTHto disable basic authentication for HTTP OPTIONS to enable CORS requests preflights.The default behavior does not change, authentication for OPTIONS is still enabled by default
This feature has been mentioned here:#1150
And a first pull request proposed here:#1176
I am not sure about the name of the env variable:
ENABLE_CORS_AUTHto disable auth when CORS OPTIONS... Might be a bit misleading. Could be alsoENABLE_PASS_CORS_AUTH, let me know if we should change itThanks@tkw1536 for the feedback on the issue
And thanks for this amazing project