- Notifications
You must be signed in to change notification settings - Fork3.1k
Add vhost.d includes to nginx.tmpl's https redirect server block#1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
dakotahawkins wants to merge1 commit intonginx-proxy:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Add vhost.d includes to nginx.tmpl's https redirect server block#1618
dakotahawkins wants to merge1 commit intonginx-proxy:mainfromdakotahawkins:https-redirect-customization-points
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Adds customization points to https redirect responses that are analogousto other response handling. This gives you the opportunity to addresponse headers or etc. before returning the 301 redirect.If `$host` or `default` exist in `/etc/nginx/vhost.d/`, we rely onnginx-proxy/acme-companion to add the Let's Encrypt acme challengelocation block there, so it's only included here if those files don'texist.New tests in `test_ssl` are similar to tests in `test_custom`, except theyexpect 301 responses along with custom configs.Fixesnginx-proxy#1613
8a9a267 to9bad218CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds customization points to https redirect responses that are analogous
to other response handling. This gives you the opportunity to add
response headers or etc. before returning the 301 redirect.
If
$hostordefaultexist in/etc/nginx/vhost.d/, we rely onnginx-proxy/acme-companion to add the Let's Encrypt acme challenge
location block there, so it's only included here if those files don't
exist.
New tests in
test_sslare similar to tests intest_custom, except theyexpect 301 responses along with custom configs.
Fixes#1613