NotificationsYou must be signed in to change notification settings
Fork3.1k
Star19.5k

support nginx_* env variables on nginx container and vhosts#1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

poma wants to merge1 commit intonginx-proxy:main

base:main

Choose a base branch

frompoma:master

Open

support nginx_* env variables on nginx container and vhosts#1326

poma wants to merge1 commit intonginx-proxy:mainfrompoma:master

Conversation

Copy link

poma commentedSep 5, 2019•
edited
Loading

Implementation of#1324 feature request. Environment variables starting withnginx_* are added as nginx config statements, for example:nginx_client_max_body_size=30M. Variables of jwilder/nginx-proxy container are added to the global config, and variables on others containers are added to the respective vhosts.

Exampledocker-compose.yml:

version:'2.1'services:nginx:image:jwilder/nginx-proxyports:      -80:80      -443:443volumes:      -/var/run/docker.sock:/var/run/docker.sock:roenvironment:nginx_client_max_body_size:42Mapp:image:appenvironment:VIRTUAL_HOST:example.comnginx_client_max_body_size:1337M

Currently only lower case variables are supported (untilnginx-proxy/docker-gen#306 is merged). Also if there is an easy way to mergeEnv dicts from all containers with the same vhost, we should do that, currentlyEnv map is taken from the first container for each vhost.

Copy link

pnbecker commentedOct 14, 2019

I like this PR and think it would be a helpful addition.

Copy link

Author

poma commentedDec 13, 2019

While we are waiting for this to be merged, you can use updated docker-gen from the repopoma/docker-gen that already contains this PR

bugficks pushed a commit to bugficks/nginx-proxy that referenced this pull request

Jul 16, 2020

support nginx_* env variables on nginx container and vhostsnginx-pro…

388ed38

…xy#1326nginx-proxy#1326

buchdag added kind/feature-request

Issue requesting a new feature

status/pr-needs-tests

This PR needs new or additional test(s)

status/pr-needs-docsThis PR needs new or additional documentation labels

Apr 5, 2021

buchdag added type/featPR for a new feature and removed kind/feature-requestIssue requesting a new feature labels

Apr 29, 2021

buchdag self-assigned this

Aug 8, 2021

support nginx_* env variables on nginx container and vhosts

26f55bf

Copy link

Author

poma commentedJun 14, 2022

Rebased PR onto the current master, now also supports upper case "NGINX_*" env vars.

One problem I've encountered is that some containers export export "NGINX_*" env vars that are invalid in the context of nginx conf and this might lead to broken nginx config generation. Notablynginx:alpine exports NGINX_VERSION which is an invalid in nginx config, this might happen if you want to put another nginx instance behind the main nginx proxy. There is a workaround of overriding exported value with an empty string. But it's still a breaking change that can break a working server when people update to it, so be careful.