Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Normalize location path to avoid multiple forward slashes & fix docs#99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
dav-pascual wants to merge2 commits intonginx:master
base:master
Choose a base branch
Loading
fromdav-pascual:master

Conversation

dav-pascual
Copy link
Contributor

@dav-pascualdav-pascual commentedFeb 27, 2023
edited
Loading

Fixes:#88 and docs

almereyda reacted with thumbs up emoji
Copy link
Collaborator

@dekobondekobon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for this PR! The integration tests are failing with the new changes. Can you please modify the integration tests such that they test for the new functionality?

@dekobon
Copy link
Collaborator

I've been doing some research on how to fix the integration tests and I've been unable to find a method of normalizing slashes using rewrite rules that will preserve the requested schema, hostname, and port. I think we may have to implement this in njs. I did a prototype in njs and it was relatively simple to normalize the uri requested to S3, but it does not result in a HTTP 302 redirect to the client. I'll update as I discover more.

dav-pascual reacted with heart emoji

@dav-pascual
Copy link
ContributorAuthor

I have not taken a a look yet at the integration tests yet, but if the njs solution serves the content correctly even if it doesn't rewrite the URL / redirect in the client I think that's a valid solution.

In a previous unsuccessful attempt in njs I was getting 404 errors after normalising "uri_path" variable.

@dav-pascualdav-pascualforce-pushed themaster branch 10 times, most recently from0cd76e7 toe6f9460CompareMarch 6, 2023 21:35
@dav-pascual
Copy link
ContributorAuthor

I tried updating the integration tests to expect a 302 code redirect when there is a double slash, but I am getting a error code return 7 from the run, without much detail

@dekobon
Copy link
Collaborator

@dav-pascual - I'm traveling right now, so it will be a while until I can engage on this.

dav-pascual reacted with thumbs up emoji

Copy link

@violethaze74violethaze74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

reviewed

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@violethaze74violethaze74violethaze74 left review comments

@dekobondekobondekobon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove double/multiple forward slashes from the request path
3 participants
@dav-pascual@dekobon@violethaze74

[8]ページ先頭

©2009-2025 Movatter.jp