Movatterモバイル変換

Skip to content

nginx/nginx-plus-go-clientPublic

NotificationsYou must be signed in to change notification settings
Fork26
Star48

Switch to DialContext() to address lint issue#530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

pdabelf5 merged 1 commit intomainfromchore/lint-fix

Aug 7, 2025

Merged

Switch to DialContext() to address lint issue#530

pdabelf5 merged 1 commit intomainfromchore/lint-fix

Aug 7, 2025

Conversation

@pdabelf5

Copy link

Collaborator

pdabelf5 commentedAug 7, 2025•
edited
Loading

Proposed changes

Address lint issue

[Go Lint: tests/client_test.go#L853](https://github.com/nginx/nginx-plus-go-client/pull/524/files#annotation_37540465072)net.Dial must not be called. use (*net.Dialer).DialContext (noctx)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

I have read theCONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have checked that all unit tests pass after adding my changes
I have updated necessary documentation
I have rebased my branch onto main
I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5

Switch to DialContext() to address lint issue

9d9f888

@pdabelf5

pdabelf5 self-assigned this

@pdabelf5

pdabelf5 requested a review froma team as acode owner

August 7, 2025 10:06

@pdabelf5

pdabelf5 added this toNGINX Ingress Controller

@github-project-automation

github-project-automationbot moved this toTodo ☑ inNGINX Ingress Controller

@pdabelf5

pdabelf5 added the chorePull requests for routine tasks label

@github-actions

github-actionsbot added the testsPull requests that update tests label

@pdabelf5

pdabelf5 moved this fromTodo ☑ toIn Review 👀 inNGINX Ingress Controller

vepatel

vepatel approved these changes

View reviewed changes

@pdabelf5

pdabelf5 added this to thev3.0.0 milestone

javorszky

javorszky approved these changes

View reviewed changes

@pdabelf5

pdabelf5 merged commita08437f intomain

14 checks passed

@pdabelf5

pdabelf5 deleted the chore/lint-fix branch

August 7, 2025 10:16

@github-project-automation

github-project-automationbot moved this fromIn Review 👀 toDone 🚀 inNGINX Ingress Controller

@pdabelf5

pdabelf5 removed the testsPull requests that update tests label

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

Pull requests for routine tasks

4 participants

@pdabelf5

@javorszky

@vepatel

[8]ページ先頭

©2009-2025 Movatter.jp