Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update servers improvements#448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sjberman merged 2 commits intonginx:mainfromdylan-way:update-servers-improvements
Jan 28, 2025

Conversation

@dylan-way
Copy link
Contributor

Proposed changes

UpdateUpdateHTTPServers andUpdateStreamServers:

  • No longer make extraGET requests for eachPUT andDELETE request.
  • Removes identical duplicate servers.
  • Returns errors for duplicate servers with different parameters.

AddsContent-Type header to NGINX clientPATCH requests.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read theCONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@dylan-waydylan-way requested a review froma team as acode ownerJanuary 24, 2025 21:31
@nginx-bot
Copy link

Hi@dylan-way! Welcome to the project! 🎉

Thanks for opening this pull request!
Be sure to check out ourContributing Guidelines while you wait for someone on the team to review this.

@nginx-botnginx-botbot added the communityIssues or PRs opened by an external contributor labelJan 24, 2025
@github-actionsgithub-actionsbot added the testsPull requests that update tests labelJan 24, 2025
@github-actions
Copy link

github-actionsbot commentedJan 24, 2025•
edited
Loading

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by theCLA Assistant Lite bot.

@dylan-way
Copy link
ContributorAuthor

I have hereby read the F5 CLA and agree to its terms

Update UpdateHTTPServers and UpdateStreamServers:- No longer make extra GET requests for each PUT and DELETE request.- Removes identical duplicate servers.- Returns errors for duplicate servers with different parameters.
@dylan-waydylan-wayforce-pushed theupdate-servers-improvements branch fromf625289 to30363d4CompareJanuary 28, 2025 16:53
@sjbermansjberman merged commitffec1a5 intonginx:mainJan 28, 2025
14 checks passed
@pdabelf5pdabelf5 added enhancementPull requests for new features/feature enhancements and removed testsPull requests that update tests labelsJan 29, 2025
@pdabelf5pdabelf5 mentioned this pull requestJan 29, 2025
1 task
@pdabelf5pdabelf5 added this to thev2.3.0 milestoneJan 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sjbermansjbermansjberman approved these changes

Assignees

No one assigned

Labels

communityIssues or PRs opened by an external contributorenhancementPull requests for new features/feature enhancements

Projects

None yet

Milestone

v2.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dylan-way@sjberman@pdabelf5
[8]ページ先頭
©2009-2025 Movatter.jp