- Notifications
You must be signed in to change notification settings - Fork7.7k
QUIC: handle ACK frames with ECN counts#949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
thebitbrine wants to merge1 commit intonginx:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
RFC 9000 section 19.3 requires implementations to accept both ACKframe types: 0x02 (without ECN counts) and 0x03 (with ECN counts).Previously, nginx would close the connection with "missing frame handler"error when receiving ACK frames with ECN counts, even though the parseralready correctly handles them.This adds the missing case to handle NGX_QUIC_FT_ACK_ECN frames, treatingthem identically to NGX_QUIC_FT_ACK frames. The ECN counters are parsedbut not used, which is compliant with the specification.Fixesnginx#945
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes#945
This PR fixes a bug where nginx closes QUIC connections when receiving ACK frames with ECN (Explicit Congestion Notification) counts.
Problem
RFC 9000 section 19.3 requires QUIC implementations to accept both ACK frame types:
Previously, nginx would close the connection with the error message
"quic missing frame handler"when receiving ACK frames with ECN counts (type 0x03), even though:Root Cause
The main frame handler switch statement in
ngx_quic_handle_frames()was missing the case forNGX_QUIC_FT_ACK_ECN, causing it to fall through to the default case and return an error.Solution
Added
case NGX_QUIC_FT_ACK_ECN:to the switch statement handling ACK frames, allowing both ACK types to use the same handler. The ECN counters are already parsed and logged by the existing code, but are not used (which is compliant with the RFC).Changes
src/event/quic/ngx_event_quic.cTesting
The fix has been verified to:
Impact
References