Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Add sni related config options to jwt policy#795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
javorszky wants to merge4 commits intonic-release-5.2
base:nic-release-5.2
Choose a base branch
Loading
fromnic/sni

Conversation

javorszky
Copy link
Contributor

@javorszkyjavorszky commentedJul 8, 2025•
edited
Loading

Proposed changes

Adds two new configuration options to the NIC / jwt policy options:sniEnabled andsniName.

Functionality PR for the underlying code isnginx/kubernetes-ingress#7993.

⚠️ Does not need to go live until the release that will have 7993 in it (5.2.0 probably)!

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read thecontributing guidelines
  • I have signed theF5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere toConventional Commits
  • I have ensured that documentation content adheres tothe style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updatedREADME.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer toour style guide for guidance about placeholder content.↩

@javorszkyjavorszky requested a review froma team as acode ownerJuly 8, 2025 13:01
@github-actionsgithub-actionsbot added documentationImprovements or additions to documentation product/nicNGINX Ingress Controller related issues labelsJul 8, 2025
@github-actionsGitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

NameLink
😎 Deploy Previewhttps://frontdoor-test-docs.nginx.com/previews/docs/795/

Copy link
Contributor

@ADubhlaoichADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Changes LGTM: if these are intended for an upcoming release, we could probably set-up the new release branch so that can be the target instead of main.

Otherwise, I'm somewhat inclined to keep this in draft just in case someone merges prematurely.

@javorszkyjavorszky marked this pull request as draftJuly 8, 2025 15:32
@javorszky
Copy link
ContributorAuthor

Otherwise, I'm somewhat inclined to keep this in draft just in case someone merges prematurely.

Excellent suggestion, thank you. I need to figure out how to not forget about this draft PR though 🤔

ADubhlaoich reacted with laugh emoji

@ADubhlaoichADubhlaoich changed the base branch frommain tonic-release-5.2July 10, 2025 16:16
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ADubhlaoichADubhlaoichADubhlaoich approved these changes

@y82y82y82 approved these changes

Assignees
No one assigned
Labels
documentationImprovements or additions to documentationproduct/nicNGINX Ingress Controller related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@javorszky@ADubhlaoich@y82
[8]ページ先頭
©2009-2025 Movatter.jp