Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Documenting config file size limits [Issue #63 - Document NGINX config file limits]#431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
DeeptiN1 wants to merge3 commits intonginx:main
base:main
Choose a base branch
Loading
fromDeeptiN1:issue-63-config-file-limit

Conversation

DeeptiN1
Copy link

@DeeptiN1DeeptiN1 commentedApr 18, 2025
edited
Loading

Proposed changes

Problem: Document NGINX config file limits (#63)

Solution:
Added config file size limits on theAdd a file to an instance page.

Testing: Tested on local machine on running the Hugo server locally. Screenshot of change:

NGINX_Config_file_size_limit_doc

Please focus on (optional): Proposed solution onIssue#63 was to add the config file size limits on theAdd an NGINX instance page.
However, theAdd a file to an instance page seems like a better place to add this information.@mjang Please could you review this and suggest changes?

If this PR addresses anissue on GitHub, ensure that you link to it here:

ClosesIssue#63

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • [ X] I have read thecontributing guidelines
  • I have signed theF5 Contributor License Agreement (CLA)
  • [ X] I have rebased my branch onto main
  • [ X] I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere toConventional Commits
  • [ X] I have ensured that documentation content adheres tothe style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updatedREADME.md andCHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer toour style guide for guidance about placeholder content.

@DeeptiN1DeeptiN1 requested a review froma team as acode ownerApril 18, 2025 23:40
@github-actionsGitHub Actions
Copy link

github-actionsbot commentedApr 18, 2025
edited
Loading

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by theCLA Assistant Lite bot.

@github-actionsgithub-actionsbot added documentationImprovements or additions to documentation product/nginx-oneNGINX One Console labelsApr 18, 2025
@DeeptiN1
Copy link
Author

I have hereby read the F5 CLA and agree to its terms

…dd-file.md to add config file size limits for Issuenginx#63 - Document NGINX config file limits
@mjang
Copy link
Contributor

Hi@DeeptiN1 . Thank you for setting up this PR! I'm consulting internally with a couple of SMEs before approving this change. Stand by.

DeeptiN1 reacted with thumbs up emoji

@mjangmjang added the questionFurther information is requested labelApr 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ADubhlaoichADubhlaoichADubhlaoich approved these changes

@y82y82y82 approved these changes

Assignees

@DeeptiN1DeeptiN1

Labels
communitydocumentationImprovements or additions to documentationproduct/nginx-oneNGINX One ConsolequestionFurther information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@DeeptiN1@mjang@ADubhlaoich@y82

[8]ページ先頭

©2009-2025 Movatter.jp